Volker Lendecke [Tue, 20 Jun 2006 09:16:53 +0000 (09:16 +0000)]
r16409: Fix Klocwork ID's.
1177
In reg_perfcount.c: 1200 1202 1203 1204
In regfio.c: 1243 1245 1246 1247 1251
Jerry, the reg_perfcount and regfio.c ones, can you take a look please? This
is really your code, and I'm not sure I did the right thing to return an
error.
smbcacls.c: 1377
srv_eventlog_nt.c: 1415 1416 1417
srv_lsa_nt.c: 1420 1421
srv_netlog_nt.c: 1429
srv_samr_nt: 1458 1459 1460
Volker
Volker
(This used to be commit
d6547d12b1c9f9454876665a5bdb010f46b9f5ff)
Jeremy Allison [Tue, 20 Jun 2006 02:38:28 +0000 (02:38 +0000)]
r16397: Fix Klocwork #11767 and drasticly simplify the
logic in smbd/process.c. All interested (Volker,
Jerry, James etc). PLEASE REVIEW THIS CHANGE.
The logic should be identical but *much* easier
to follow and change (and shouldn't confuse Klockwork :-).
Jeremy.
(This used to be commit
d357f8b33594472ffa78d0a112accccc2a8b1fe7)
Jeremy Allison [Tue, 20 Jun 2006 01:32:50 +0000 (01:32 +0000)]
r16396: Klocwork #1170. Null deref.
Jeremy.
(This used to be commit
220627ab70977a9a26dc0e010f73195c2c87ec96)
Jeremy Allison [Tue, 20 Jun 2006 01:27:39 +0000 (01:27 +0000)]
r16393: Klocwork #1164. Null deref.
Jeremy.
(This used to be commit
c9a4ce51ed85686a35f350f4681b95d68adebbd6)
Jeremy Allison [Tue, 20 Jun 2006 01:25:31 +0000 (01:25 +0000)]
r16392: Klockwork #1168. Protect against null deref.
Jeremy.
(This used to be commit
cab256d72a91f59432e28e9623c10384d9ca2b5e)
Jeremy Allison [Tue, 20 Jun 2006 01:20:38 +0000 (01:20 +0000)]
r16390: Klocwork #604 - ensure if NULL pointer we assert
if len != 0.
Jeremy.
(This used to be commit
e99cedfb0cabe3863797c8bd4594ee0826022d2e)
Jeremy Allison [Tue, 20 Jun 2006 01:12:44 +0000 (01:12 +0000)]
r16388: Klocwork #320. Null deref.
Jeremy.
(This used to be commit
ceea8e21006bd6bae9e203a672f82e4d066bba28)
Jeremy Allison [Tue, 20 Jun 2006 01:08:57 +0000 (01:08 +0000)]
r16386: Klockwork #lots. Ensure talloc_get_type_abort aborts
if handed a NULL pointer, not returns NULL.
Jeremy.
(This used to be commit
d47ec4dc25bffa6f605c0f6fa1d9c046dbc520a7)
Jeremy Allison [Tue, 20 Jun 2006 01:03:04 +0000 (01:03 +0000)]
r16383: Klocwork #1086. No null deref.
Jeremy.
(This used to be commit
7b68a2acfc583d1559c02461cab13419185bcd74)
Jeremy Allison [Tue, 20 Jun 2006 01:00:39 +0000 (01:00 +0000)]
r16381: Now samu can't be null don't check it on set. Klockwork
related fix.
Jeremy.
(This used to be commit
2e5a88147826113f78ee0d8845c704692942cebf)
Jeremy Allison [Tue, 20 Jun 2006 00:21:39 +0000 (00:21 +0000)]
r16378: Klocwork #1079. Allow BUFFER5 to cope with a NULL
dependentfiles pointer.
Jeremy.
(This used to be commit
05c50d99a4b1d2bc11a83e07902082227d7c074a)
Jeremy Allison [Mon, 19 Jun 2006 23:21:47 +0000 (23:21 +0000)]
r16377: Klocwork #1077.
Jeremy.
(This used to be commit
72709a8465caf5b7d95911250234f203b0ff4675)
Jeremy Allison [Mon, 19 Jun 2006 23:19:24 +0000 (23:19 +0000)]
r16375: Klocwork #1670.
Jeremy.
(This used to be commit
99605ce296663b7697d737fd521f0e4d8436d1f2)
Jeremy Allison [Mon, 19 Jun 2006 22:59:03 +0000 (22:59 +0000)]
r16373: Fix Klocwork #1071.
Jeremy
(This used to be commit
080464b93d965a583b2b5f248a2bb8a7fb516e6f)
Jeremy Allison [Mon, 19 Jun 2006 22:55:03 +0000 (22:55 +0000)]
r16371: Fix Klocwork #1048.
Jeremy.
(This used to be commit
5057e90db32adf4395fc2a3fce26a7f64c780828)
Jeremy Allison [Mon, 19 Jun 2006 21:47:46 +0000 (21:47 +0000)]
r16369: Klocwork #1035.
Jeremy.
(This used to be commit
6924d1cd443e4f7eb7b634c97c92effd6373ff12)
Jeremy Allison [Mon, 19 Jun 2006 21:42:07 +0000 (21:42 +0000)]
r16367: Missed one, Klocwork #915.
Jeremy.
(This used to be commit
b581fee9824712b9385e9975739a8ddbb297bca8)
Jeremy Allison [Mon, 19 Jun 2006 21:36:19 +0000 (21:36 +0000)]
r16365: Fix Klocwork #895, #898, #899, #915, #932, #938 and a
few other problems Klocwork missed.
Jeremy.
(This used to be commit
fe05769a1a85f924c67be7e5dcee4871a86948d7)
Volker Lendecke [Mon, 19 Jun 2006 20:00:51 +0000 (20:00 +0000)]
r16363: Fix Klocwork ID 981 1652
Volker
(This used to be commit
ce1d8423ef7cd86fc64200002fde707bca621d44)
Volker Lendecke [Mon, 19 Jun 2006 19:56:22 +0000 (19:56 +0000)]
r16362: That's the best way to fix a Klocwork bug: Remove the (unused...;-) code
altogether. This was essentially a second implementation if string_to_sid.
Klocwork ID 1038
Volker
(This used to be commit
e35f901067b702f5e61733a6edabc610a7dd5aab)
Volker Lendecke [Mon, 19 Jun 2006 19:41:56 +0000 (19:41 +0000)]
r16361: Fix Klocwork ID 1731 1770 1771 1775 1796
Volker
(This used to be commit
8a5cebc19e4709399976efe9e3ba3bf29249620a)
Volker Lendecke [Mon, 19 Jun 2006 19:07:39 +0000 (19:07 +0000)]
r16360: Fix Klocwork ID 136 520 521 522 523 542 574 575 576 607
in net_rpc.c: 715 716 732 734 735 736 737 738 739 749
in net_rpc_audit.c: 754 755 756
in net_rpc_join.c: 757
in net_rpc_registry: 766 767
in net_rpc_samsync.c: 771 773
in net_sam.c: 797 798
Volker
(This used to be commit
3df0bf7d6050fd7c9ace72487d4f74d92e30a584)
Jeremy Allison [Mon, 19 Jun 2006 18:49:51 +0000 (18:49 +0000)]
r16358: ALWAYS compile this stuff on a 64-bit box before
checking in. size_t != uint32 on a 64-bit machine.
Jeremy.
(This used to be commit
09c89732869eae0d8c8971ac78235d34e4dcecb9)
Jeremy Allison [Mon, 19 Jun 2006 17:23:54 +0000 (17:23 +0000)]
r16356: Helping derrell out. Jeremy.
Only set the DFS capability flag if the share is a DFS root. Fixes bug 3814.
(This used to be commit
6193f1170819096ea8a646e5a456f627df83872d)
Jeremy Allison [Mon, 19 Jun 2006 17:22:53 +0000 (17:22 +0000)]
r16355: Remove derrell-test created by mistake.
Jeremy.
(This used to be commit
1dea2ab8562696e4435de2de46877d821b3eb232)
Derrell Lipman [Mon, 19 Jun 2006 16:48:59 +0000 (16:48 +0000)]
r16354: r14595@cabra: derrell | 2006-05-09 00:00:35 -0400
Made a trivial change to the file so I can have one more check-in
(This used to be commit
9b562e919a4a369d7767a444229487a83ae9f6f5)
Derrell Lipman [Mon, 19 Jun 2006 16:48:51 +0000 (16:48 +0000)]
r16353: r14594@cabra: derrell | 2006-05-08 23:59:42 -0400
Added first draft of README file, testing SVK's --patch facility
(This used to be commit
d11238ecf8ef63b967648ce54e98e57858be95f7)
Günther Deschner [Mon, 19 Jun 2006 16:25:19 +0000 (16:25 +0000)]
r16350: Fix the build.
GUenther
(This used to be commit
3203ce3b49e6f21ed690e9d7393e98419de54c27)
Günther Deschner [Mon, 19 Jun 2006 16:00:32 +0000 (16:00 +0000)]
r16349: Another fix to make winbind more robust in large domains:
We may only feed rpc_useraliases with chunks of 1024 entries. This is
important as the token generation otherwise fails when a user is member
of more then 1024 groups.
Volker, please check.
Guenther
(This used to be commit
d8fd94648f965eb043f957b154ce63b245a90328)
Günther Deschner [Mon, 19 Jun 2006 10:02:04 +0000 (10:02 +0000)]
r16346: Allow to exit a "net rpc shell" with 'quit' or 'exit'.
Guenther
(This used to be commit
232566e1cb1eaaa6ae09e9de8a8a82d91acdfda7)
Günther Deschner [Mon, 19 Jun 2006 10:01:02 +0000 (10:01 +0000)]
r16345: Improve the chance that our users can discover one of the coolest 'net'
features.
Guenther
(This used to be commit
446d79a0007d3d99c73eb758216f18f64036f11d)
Günther Deschner [Mon, 19 Jun 2006 09:54:00 +0000 (09:54 +0000)]
r16344: Allow to set passwords directly when creating users via "net rpc user
add" (as the documentation says, and currently onle "net ads user add"
did). Fixes #3843.
Guenther
(This used to be commit
5d776d5fabded9b713080789aefc6058510b51f6)
Volker Lendecke [Sun, 18 Jun 2006 09:56:45 +0000 (09:56 +0000)]
r16340: Commit Bjoern's fix for the AIX PIC suffix. 'make test' still does the first
tests, and vfstest is still able to load modules. Looks like this is ok :-)
Volker
(This used to be commit
c08bfdf87a1368a5d6c9a58ddb8ba379d969941d)
Volker Lendecke [Sun, 18 Jun 2006 09:45:18 +0000 (09:45 +0000)]
r16339: Fix Klocwork ID
277 278 (cmd_*)
485 487 488 (ldap.c)
Volker
(This used to be commit
5b1eba76b3ec5cb9b896a9a5641b4d83bdbdd4cf)
Volker Lendecke [Sun, 18 Jun 2006 09:26:05 +0000 (09:26 +0000)]
r16338: Fix Klocwork ID 150
(This used to be commit
ded2952e00fec712ce612cf6aaabf85c1a6f4488)
Volker Lendecke [Sun, 18 Jun 2006 08:35:27 +0000 (08:35 +0000)]
r16337: Add configure fixes by Bjoern Jacke <samba@j3e.de>.
Volker
(This used to be commit
1b3a24732df19addb8c2dfaae99f5fbf5bbccc44)
Volker Lendecke [Sun, 18 Jun 2006 07:54:06 +0000 (07:54 +0000)]
r16336: Fix Klocwork ID's 1087, 1095, 1096, 1098, 1099, 1101, 1102, 1105, 1107, 1109,
1111
Volker
(This used to be commit
def075baf873b24c522d09ddc0141d84431a1fae)
Volker Lendecke [Sat, 17 Jun 2006 07:43:56 +0000 (07:43 +0000)]
r16335: Fix Klocwork IDs 107 108 109 111 112 113 114 116 117 118 121
(This used to be commit
555984ea772730a5752905f1130e0bf6ec48207f)
Volker Lendecke [Sat, 17 Jun 2006 07:20:47 +0000 (07:20 +0000)]
r16334: Fix Klocwork ID's 1087, 1095, 1096, 1098, 1099, 1101, 1102, 1105, 1107, 1109,
1111
Volker
(This used to be commit
d3f5acb16e14ec394f1af41fa2f9e27fdca937db)
Jeremy Allison [Fri, 16 Jun 2006 23:26:48 +0000 (23:26 +0000)]
r16326: Klocwork #509. Always check return allocs.
Jeremy.
(This used to be commit
7e397b534a5ca5809facf5aa84acbfb0b8c9a5b4)
Jeremy Allison [Fri, 16 Jun 2006 23:21:36 +0000 (23:21 +0000)]
r16324: Klocwork #499. Allways check results from alloc.
Jeremy.
(This used to be commit
2b69d436da7b2902ea419f3bcc45c7b5a5c571fb)
Jeremy Allison [Fri, 16 Jun 2006 23:14:12 +0000 (23:14 +0000)]
r16322: Klocwork #481., Don't deref null on malloc fail.
Jeremy.
(This used to be commit
dd31f3fc0e044fdae139aefcb21773249c30eb74)
Jeremy Allison [Fri, 16 Jun 2006 23:07:42 +0000 (23:07 +0000)]
r16320: Ensure variable is not null before calling fclose.
Klocwork #412.
Jeremy.
(This used to be commit
fed55d653a73d09550a90a4904023580dd46ae76)
Jeremy Allison [Fri, 16 Jun 2006 23:04:13 +0000 (23:04 +0000)]
r16317: Klocwork #300. Check for error return on malloc.
Jeremy.
(This used to be commit
aa0d739834a286aeee88f76048dc347dd2852d09)
Jeremy Allison [Fri, 16 Jun 2006 22:44:28 +0000 (22:44 +0000)]
r16313: Not a problem - but ensure Klocwork is quiet (#872).
Jeremy.
(This used to be commit
22a345deed6caa5750e2bb233a20422ad7b90d94)
Jeremy Allison [Fri, 16 Jun 2006 22:40:07 +0000 (22:40 +0000)]
r16311: Check for NULL return. Klocwork #998.
Jeremy.
(This used to be commit
c430730f5a0dc00626b9b924e88adfb84cd48869)
Jeremy Allison [Fri, 16 Jun 2006 22:36:12 +0000 (22:36 +0000)]
r16309: Fix Klocwork #1596. Check for NULL on talloc.
Jeremy.
(This used to be commit
34b6b6723b1c87e19b0a51ef785a614d86bd5cef)
Jeremy Allison [Fri, 16 Jun 2006 22:29:53 +0000 (22:29 +0000)]
r16307: Make sure we know we must pass a valid pointer here.
Klocwork #1129.
Jeremy.
(This used to be commit
e8d86362ba8762a5e4180e7320f5ac8bb37c203d)
Jeremy Allison [Fri, 16 Jun 2006 22:25:17 +0000 (22:25 +0000)]
r16306: Error handling in this asn1 code *sucks*. Fix a generic
class of memory leak bugs on error found by Klocwork (#123).
Many of these functions didn't free allocated memory on
error exit.
Jeremy.
(This used to be commit
8ef11a7c6de74024b7d535d959db2d462662a86f)
Volker Lendecke [Fri, 16 Jun 2006 21:10:19 +0000 (21:10 +0000)]
r16301: Fix a memleak
(This used to be commit
21aaede518503e6722ba5ccfdb2c77007d12ddee)
Jeremy Allison [Fri, 16 Jun 2006 20:44:49 +0000 (20:44 +0000)]
r16299: Fix another "dereferencing type-punned pointer will break
strict-aliasing rules" gcc4 warning.
Jeremy.
(This used to be commit
ee77dde9b6375423f95f31455d06cef7303400be)
Jeremy Allison [Fri, 16 Jun 2006 18:50:01 +0000 (18:50 +0000)]
r16298: On request of jiri sasek - Sun Microsystems - Prague Czech Republic <Jiri.Sasek@Sun.COM>
change priv_op and priv_info to names that don't
conflict with the solaris namespace.
Jeremy.
(This used to be commit
db5b4e3f13bceeb2f078f412bdd4666516eedc5c)
Jeremy Allison [Fri, 16 Jun 2006 18:42:39 +0000 (18:42 +0000)]
r16295: Fix gcc4 "warning: dereferencing type-punned pointer will break
strict-aliasing rules" warning.
Jeremy.
(This used to be commit
7ac5aee88cae3400fb6400b3628544da2e474560)
Lars Müller [Fri, 16 Jun 2006 14:34:36 +0000 (14:34 +0000)]
r16294: Fix syntax error.
Credits to Andreas Schwab from SUSE Linux for this fix.
(This used to be commit
da4c5c3b75e6fd4f9e661cbcbe7d38024a02d344)
Volker Lendecke [Fri, 16 Jun 2006 12:30:39 +0000 (12:30 +0000)]
r16290: Fix Coverity bugs 298 and 298
(This used to be commit
b96808bb623c01f2515fdbdede8b4e9edebff23b)
James Peach [Fri, 16 Jun 2006 04:44:59 +0000 (04:44 +0000)]
r16289: Fix smbclient test hang. This is caused by readline refusing to believe
the end of file it receives when reading from a pipe after we force
interactive mode.
(This used to be commit
3eee12645883df21efa5175b10854a965fc90422)
Jeremy Allison [Fri, 16 Jun 2006 02:23:02 +0000 (02:23 +0000)]
r16287: Use intptr_t to return an integer of an unknown type cast
to void *.
Jeremy.
(This used to be commit
e24361ecddef8a48a42a356775b93ce5c4027fae)
Jeremy Allison [Fri, 16 Jun 2006 02:01:29 +0000 (02:01 +0000)]
r16285: On a 64-bit box, size_t != uint32. Ensure we use
the right parameter type.
Jeremy.
(This used to be commit
938545f5352161b4fe195c2a826a26db5236f851)
Jeremy Allison [Fri, 16 Jun 2006 01:47:02 +0000 (01:47 +0000)]
r16284: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
(This used to be commit
face01ef01e1a3c96eae17c56cadf01020d4cb46)
Jeremy Allison [Fri, 16 Jun 2006 01:35:08 +0000 (01:35 +0000)]
r16281: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
(This used to be commit
c49ad9200bf3fdd8b9404d93182c2e04e662190a)
Jeremy Allison [Fri, 16 Jun 2006 01:33:13 +0000 (01:33 +0000)]
r16280: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned
int
in a format string.
Jeremy.
(This used to be commit
45d5cad8c2438c032d9f11c62a50a04d0637bf6c)
Jeremy Allison [Fri, 16 Jun 2006 01:32:19 +0000 (01:32 +0000)]
r16277: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int
in a format string.
Jeremy.
(This used to be commit
3a15fff21988b426a514ad28060eaf0ddc17ef6b)
Jeremy Allison [Fri, 16 Jun 2006 01:30:42 +0000 (01:30 +0000)]
r16275: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsigned int
in a format string.
Jeremy.
(This used to be commit
952547471f03bd2da1eda0247471b17aa1ff15de)
James Peach [Thu, 15 Jun 2006 23:51:20 +0000 (23:51 +0000)]
r16274: Fix the smbclient prompting behaviour for both systems that have
libreadline and those that don't. We always use the built-in readline
replacement for non-interactive mode. Interactive prompts are always
emitted to stdout and non-interactive mode never prompts at all.
Introduce x_fdup to avoid spuriously closing stdout when a logfile is
specified on the command line and setup_logging is called a second time.
(This used to be commit
848ac756f651a4be231e5635580c0fd5f3d3fa0e)
James Peach [Thu, 15 Jun 2006 23:47:41 +0000 (23:47 +0000)]
r16273: Add smbclient tests to verify that
in interactive mode, smbclient always prompts on stdout
in non-interactive mode, smbclient never prompts
(This used to be commit
dff1eba81ed4bdd6dbf2df6e7c28b0da74a39615)
Günther Deschner [Thu, 15 Jun 2006 21:59:25 +0000 (21:59 +0000)]
r16272: Fix memleak.
Guenther
(This used to be commit
afdb1189029e01a132f16fea48624126ec65cd77)
Jeremy Allison [Thu, 15 Jun 2006 21:46:15 +0000 (21:46 +0000)]
r16270: Fix Klocwork #706 - ensure sscanf has correct format
specifier.
Jeremy.
(This used to be commit
dc53d35b0a1491da94e231943a81547be4c75631)
Günther Deschner [Thu, 15 Jun 2006 21:45:10 +0000 (21:45 +0000)]
r16269: Fix the build.
Guenther
(This used to be commit
546710d58c07acdaa175caa48cec4d3f2bc657ad)
Günther Deschner [Thu, 15 Jun 2006 21:25:57 +0000 (21:25 +0000)]
r16268: Add TCP fallback for our implementation of the CHANGEPW kpasswd calls.
This patch is mainly based on the work of Todd Stecher
<tstecher@isilon.com> and has been reviewed by Jeremy.
I sucessfully tested and valgrinded it with MIT 1.4.3, 1.3.5, Heimdal
0.7.2 and 0.6.1rc3.
Guenther
(This used to be commit
535d03cbe8b021e9aa6d74b62d81b867c494c957)
Jeremy Allison [Thu, 15 Jun 2006 21:03:40 +0000 (21:03 +0000)]
r16267: Fix Klocwork #401, #402 - ensure format specifier
limited. Fix memleak in printing gencache contents.
Jeremy.
(This used to be commit
81731e1f68cdf4af80733338238aeae0a7d108c0)
Günther Deschner [Thu, 15 Jun 2006 16:09:31 +0000 (16:09 +0000)]
r16261: Smaller fixes for net ads password.
Guenther
(This used to be commit
689ae22c80a890278610d9ada1eb4fa5e37bd5ce)
Gerald Carter [Thu, 15 Jun 2006 12:37:05 +0000 (12:37 +0000)]
r16255: Fix 'net ads join' when the workgroup is set incorrectly
in smb.conf. This did work before the join rewrite.
Samba will have problems if you try to run any of the daemons
with an incorrect workgroup but it should not fail to join.
The summary is that a member server should always use it's
own machine name when setting up schannel since that is
the only account it has. Thanks to Volker for the discussion.
(This used to be commit
95763b94f709fe1ad9e381dbc6b364c2f3759024)
Günther Deschner [Thu, 15 Jun 2006 11:58:13 +0000 (11:58 +0000)]
r16253: Fix another host/ UPN case in (the currently unused)
cli_rpc_pipe_open_krb5.
Guenther
(This used to be commit
fa19099112490daa085bb310f2f4ed877bb22b40)
Volker Lendecke [Thu, 15 Jun 2006 11:44:57 +0000 (11:44 +0000)]
r16252: Fix Klocwork ID 1119, 1121.
Volker
(This used to be commit
678bbcf06109b276d3e4514c3788a9fb31348de0)
Volker Lendecke [Thu, 15 Jun 2006 11:24:01 +0000 (11:24 +0000)]
r16251: for i in `seq 1 1000`
do
echo "I will always compile before commit :-)"
done
Also fix Klokwork ID 806.
Volker
(This used to be commit
4974c598c00abc20cfb73eee12a7c49c279e0f54)
Volker Lendecke [Thu, 15 Jun 2006 11:17:57 +0000 (11:17 +0000)]
r16250: Fix Klokwork IDs 148, 151, 152, 154.
Volker
(This used to be commit
d7a75ee94db009085165c062f73b68162a8b6da8)
Volker Lendecke [Thu, 15 Jun 2006 10:48:53 +0000 (10:48 +0000)]
r16249: Fix Klokwork ID 130
(This used to be commit
09586824f6568fb3305e3e59ba6bc8f5f632fb56)
Volker Lendecke [Thu, 15 Jun 2006 10:12:29 +0000 (10:12 +0000)]
r16248: Fix Coverity ID 297
(This used to be commit
e56e3c19e1244e2b7409d57a030ca8b7ec446932)
Volker Lendecke [Thu, 15 Jun 2006 10:06:09 +0000 (10:06 +0000)]
r16247: Fix Coverity ID 296
(This used to be commit
b82c95cb438b57bb8910e26657f8ffb590fe02df)
Jeremy Allison [Thu, 15 Jun 2006 05:32:21 +0000 (05:32 +0000)]
r16245: Cope with string being zero len. Klocwork bug #410.
Jeremy.
(This used to be commit
afe2d4c49333309b940cec8408ccd37ed3747cb7)
Jeremy Allison [Thu, 15 Jun 2006 05:20:21 +0000 (05:20 +0000)]
r16243: Fix Klocwork bugs #581 and #706, ensure we check
the end of array first in the loop. Reformat to
modern standards.
Jeremy.
(This used to be commit
66275bd3bc56e67759dbabe77cb2ba019c6f4887)
Jeremy Allison [Thu, 15 Jun 2006 01:54:09 +0000 (01:54 +0000)]
r16241: Fix Klocwork #106 and others like it.
Make 2 important changes. pdb_get_methods()
returning NULL is a *fatal* error. Don't try
and cope with it just call smb_panic. This
removes a *lot* of pointless "if (!pdb)" handling
code. Secondly, ensure that if samu_init()
fails we *always* back out of a function. That
way we are never in a situation where the pdb_XXX()
functions need to start with a "if (sampass)"
test - this was just bad design, not defensive
programming.
Jeremy.
(This used to be commit
a0d368197d6ae6777b7c2c3c6e970ab8ae7ca2ae)
Jeremy Allison [Wed, 14 Jun 2006 21:36:49 +0000 (21:36 +0000)]
r16230: Fix Klocwork #861 and others. localtime and asctime
can return NULL. Ensure we check all returns correctly.
Jeremy.
(This used to be commit
6c61dc8ed6d84f310ef391fb7700e93ef42c4afc)
Günther Deschner [Wed, 14 Jun 2006 14:43:15 +0000 (14:43 +0000)]
r16222: Fix DEBUG statements.
Guenther
(This used to be commit
5ecfaf7d505e6acc23a06dd64d00f5e6fb8efe6f)
Günther Deschner [Wed, 14 Jun 2006 14:38:59 +0000 (14:38 +0000)]
r16221: No need for friednly error messages at log level 10.
Guenther
(This used to be commit
58a7c0900325065cc969eb4f2f4c85d41e27bc89)
Gerald Carter [Wed, 14 Jun 2006 12:00:53 +0000 (12:00 +0000)]
r16219: BUG 3836, 3837, 3004: compile warning fixes from Jason Mader.
(This used to be commit
6c1f1c091f5e87bf9464fe8ad7eb2cb683819a62)
Jeremy Allison [Wed, 14 Jun 2006 02:06:28 +0000 (02:06 +0000)]
r16216: Add debug messages to make it possible to try and
debug why a job pause or resume command is not being
done.
Jeremy.
(This used to be commit
e6aacb1426bd04c4006f7be66228f9f8d9a7065d)
Jeremy Allison [Wed, 14 Jun 2006 00:37:52 +0000 (00:37 +0000)]
r16213: Fix Klocwork #852. iface_n_ip can potentially
return NULL. Ensure we don't deref.
Jeremy.
(This used to be commit
c2f0ea2ff2f6ad925cee9c85110c6ad828ffb7a9)
Jeremy Allison [Tue, 13 Jun 2006 21:21:44 +0000 (21:21 +0000)]
r16209: Klocwork bug #66, ensure no null deref.
Jeremy.
(This used to be commit
79e693798cf322071ea64a4014a01ad9eaba73e8)
Jeremy Allison [Tue, 13 Jun 2006 21:01:08 +0000 (21:01 +0000)]
r16207: Ensure we don't allocate an OID string unless
we know we don't have an error. Klocwork #6.
Jeremy.
(This used to be commit
2c1a2d7b40e7ef353461f97f5c69c2079b5670ab)
Gerald Carter [Tue, 13 Jun 2006 20:29:00 +0000 (20:29 +0000)]
r16206: Don Meyer <dlmeyer@uiuc.edu> pointed out that RHEL4 rpms use 'Epoch: 0' so work around that
(This used to be commit
304b7913cd25a024269fecdd541af06836816f68)
Gerald Carter [Tue, 13 Jun 2006 20:02:50 +0000 (20:02 +0000)]
r16205: Fix 'make install' when srcdir != builddir
(This used to be commit
44d4bab991d5fc88005a542d2490ae3254a0f5b5)
Volker Lendecke [Tue, 13 Jun 2006 19:56:26 +0000 (19:56 +0000)]
r16204: Fix Klocwork # 14
localtime() can return NULL.
Volker
(This used to be commit
07c5dcb8633e6fadb596dc5a22d8d31b2e16a3ef)
Volker Lendecke [Tue, 13 Jun 2006 19:40:28 +0000 (19:40 +0000)]
r16203: Fix potentially writing one result of strtok beyond the end of alt_path.
Found by Klocwork, ID 653.
Volker
(This used to be commit
4cb8cf221f986b15de3ac608b173310c14248533)
Jeremy Allison [Tue, 13 Jun 2006 18:15:03 +0000 (18:15 +0000)]
r16202: Fix Klocwork #3. Strange - was already fixed in HEAD.
Jeremy.
(This used to be commit
319f80bbf0455cfaf80eab51313a56db4ed04ac5)
Volker Lendecke [Tue, 13 Jun 2006 18:09:37 +0000 (18:09 +0000)]
r16201: Fix Klocwork 439
(This used to be commit
b369d0891afe8b777b837eaac317131232568ca7)
Jeremy Allison [Tue, 13 Jun 2006 18:09:04 +0000 (18:09 +0000)]
r16199: Fix Klocwork #1 - ensure we test the first
strtok for NULL.
Jeremy.
(This used to be commit
98751e8190317416de56b4a19a489c5f4b7d6bc9)
Volker Lendecke [Tue, 13 Jun 2006 18:06:12 +0000 (18:06 +0000)]
r16198: Fix Klocwork 1023
(This used to be commit
3a7d01afbebe5c4c36935b6128998e1327c8f856)
Volker Lendecke [Tue, 13 Jun 2006 18:01:58 +0000 (18:01 +0000)]
r16197: Fix Klocwork id 1338
(This used to be commit
963ae5bd144b90e71331a88029698a1a6dc52190)
Volker Lendecke [Tue, 13 Jun 2006 17:55:39 +0000 (17:55 +0000)]
r16196: A bit of defensive programming:
Klocwork ID 1773 complained about oldest being dereferenced in line 2275 where
it could be NULL. I think you can construct extreme racy conditions where this
actually could happen.
Volker
(This used to be commit
b5602cc4f1d77ed48ddca0f7f42b28706160c923)