lib/ldb Remove talloc_free() that causes double-free in callbacks.

[kai/samba.git] / source4 / lib / ldb / ldb_tdb / ldb_index.c

diff --git a/source4/lib/ldb/ldb_tdb/ldb_index.c b/source4/lib/ldb/ldb_tdb/ldb_index.c
index 71cffb90b3449aae7cf23bffb62423db3bb0fe9c..02e4acbbdef9ecd0e89da7d20de026a6a1ad8895 100644 (file)
--- a/source4/lib/ldb/ldb_tdb/ldb_index.c
+++ b/source4/lib/ldb/ldb_tdb/ldb_index.c
@@ -966,7 +966,9 @@ static int ltdb_index_filter(const struct dn_list *dn_list,
 
                ret = ldb_module_send_entry(ac->req, msg, NULL);
                if (ret != LDB_SUCCESS) {
-                       talloc_free(msg);
+                       /* Regardless of success or failure, the msg
+                        * is the callbacks responsiblity, and should
+                        * not be talloc_free()'ed */
                        ac->request_terminated = true;
                        return ret;
                }