s3: in sys_popen(), untangle function call from result check

[kai/samba.git] / source3 / lib / system.c

diff --git a/source3/lib/system.c b/source3/lib/system.c
index 94603305370a96bb98e8520a975ddadbe6ffeb6a..58f7b478ad4e4e1f90d0065443af11b3e838afe6 100644 (file)
--- a/source3/lib/system.c
+++ b/source3/lib/system.c
@@ -1188,8 +1188,10 @@ int sys_popen(const char *command)
         * Extract the command and args into a NULL terminated array.
         */
 
-       if(!(argl = extract_args(NULL, command)))
+       argl = extract_args(NULL, command);
+       if (argl == NULL) {
                goto err_exit;
+       }
 
        entry->child_pid = fork();