dbcheck: Abandon dbcheck if we get an error during a transaction
authorAndrew Bartlett <abartlet@samba.org>
Fri, 26 Aug 2016 03:53:19 +0000 (15:53 +1200)
committerStefan Metzmacher <metze@samba.org>
Mon, 29 Aug 2016 10:46:21 +0000 (12:46 +0200)
commitdb32a0e5ea8f652857e45480cc31ecb1ef884c1a
tree0f02c603574fe00318d0013c19134dd56531ca89
parent9d0c869e36ba2f43fd2ed4cd090b48102d499bc8
dbcheck: Abandon dbcheck if we get an error during a transaction

Otherwise, anything that the transaction has already done to the DB will be left in the DB
even despite the failure.  For example, if a fix wrote to the DB, but then failed a post-write
check, then the fix will not be unrolled.

This is because we do not have nested transactions in TDB.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12178

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Aug 29 12:46:21 CEST 2016 on sn-devel-144
python/samba/dbchecker.py
testprogs/blackbox/dbcheck-oldrelease.sh