KCC: fix is_bridgehead_failed() according to documentation
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 20 Mar 2015 03:40:05 +0000 (16:40 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 29 May 2015 04:58:26 +0000 (06:58 +0200)
commit59af1b51755086d12aed19737a4e84f86fd3b889
tree53f2bcb7121c8479e590ee958248a2cd8bf01276
parentbb945df0ef3cb9ee73cbba58e2a5ac9267073872
KCC: fix is_bridgehead_failed() according to documentation

Throughout the KCC specification `detectFailedDCs` is documented along
the lines of "true to detect failed DCs", and it gets passed down to
this function. And what do we see here? It is used as a default value
when a stale link is not detected. That is entirely different. So who is
right -- the comments or the pseudo-code?

This commit follows the comments. It works!

   Documentation 1,  Pseudo-code 0

See [MS-ADTS] — v20140502, section 6.2.2.3.4.4, page 569.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/scripting/bin/samba_kcc