spoolss: return the spoolss job ID in notifications
authorDavid Disseldorp <ddiss@samba.org>
Fri, 20 Sep 2013 03:31:37 +0000 (20:31 -0700)
committerDavid Disseldorp <ddiss@samba.org>
Mon, 18 Nov 2013 15:03:59 +0000 (16:03 +0100)
commit24d025f85d6eea272bff5e1040d4fd2ba0e6b8f3
tree7f0f3fd4c70890f28f5f544bbac166baf689acbf
parent7e01e4bc64a80ee43f1fe845e0e2eed523f235fa
spoolss: return the spoolss job ID in notifications

Print job notifications currently carry the system print job identifier
from the queue structure. Instead, the spoolss job identifier should be
resolved and returned.

Print clients can use notification job-ids in subsequent spoolss SetJob
requests. Returning an incorrect identifier can result in the failure of
such requests, e.g. spoolss_SetJob(SPOOLSS_JOB_CONTROL_DELETE).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=10271

Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
source3/include/printing.h
source3/printing/printing.c
source3/rpc_server/spoolss/srv_spoolss_nt.c