Stefan Metzmacher [Sat, 23 Oct 2010 09:03:41 +0000 (11:03 +0200)]
s4:rpc_server/netlogon: netr_ServerAuthenticate3 should return NO_TRUST_SAM_ACCOUNT
If we can't find the account we should return NT_STATUS_NO_TRUST_SAM_ACCOUNT
instead of NT_STATUS_ACCESS_DENIED.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Oct 23 10:05:35 UTC 2010 on sn-devel-104
Stefan Metzmacher [Sat, 23 Oct 2010 09:02:43 +0000 (11:02 +0200)]
s4:rpc_server/netlogon: netr_ServerAuthenticate3 should reject invalid sec_channel_types early
metze
Stefan Metzmacher [Sat, 23 Oct 2010 09:01:43 +0000 (11:01 +0200)]
s4:rpc_server/netlogon: netr_ServerAuthenticate3 should check the challenge after the account
metze
Stefan Metzmacher [Wed, 29 Sep 2010 22:33:18 +0000 (00:33 +0200)]
s4:rpc_server/netlogon: fix comment in netr_DsRGetDCName()
metze
Stefan Metzmacher [Wed, 29 Sep 2010 22:29:48 +0000 (00:29 +0200)]
s4:rpc_server/netlogon: handle DC_RETURN_NETBIOS and DC_RETURN_DNS in netr_DsRGetDCNameEx2()
metze
Stefan Metzmacher [Wed, 29 Sep 2010 22:27:52 +0000 (00:27 +0200)]
s4:rpc_server/netlogon: validate flags in netr_DsRGetDCNameEx2() and callers
Thanks to Tarun Chopra for the help of looking up all the bits in
the docs.
metze
Stefan Metzmacher [Wed, 29 Sep 2010 18:36:40 +0000 (20:36 +0200)]
s4:rpc_server/netlogon: netr_GetDcName should return WERR_DCNOTFOUND for invalid names
Only netbios domain names are allowed.
metze
Stefan Metzmacher [Sat, 23 Oct 2010 08:55:49 +0000 (10:55 +0200)]
misc.idl: add SEC_CHAN_LOCAL and SEC_CHAN_LANMAN
MsvApSecureChannel and UasServerSecureChannel in [MS-NRPC]
metze
Kai Blin [Fri, 22 Oct 2010 14:40:38 +0000 (16:40 +0200)]
lib/util: Add tevent WERROR wrappers
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Sat Oct 23 07:35:28 UTC 2010 on sn-devel-104
Stefan Metzmacher [Thu, 21 Oct 2010 21:31:41 +0000 (23:31 +0200)]
tsocket: let tstream_inet_tcp_connect_recv() optionally return the used local address
tstream_inet_tcp_connect_send() usually only gets no local port number
and it may use the wildcard address '0.0.0.0' or '::'.
tstream_inet_tcp_connect_recv() provides the used local address and port
which are used on the wire.
metze
Stefan Metzmacher [Thu, 21 Oct 2010 21:26:14 +0000 (23:26 +0200)]
tsocket: ask the kernel for the specific local address after a tcp connect
metze
Stefan Metzmacher [Fri, 22 Oct 2010 12:41:47 +0000 (14:41 +0200)]
lib/replace: use snprintf() in test code to avoid warnings in the IBM-Checker
metze
Stefan Metzmacher [Fri, 22 Oct 2010 06:44:29 +0000 (08:44 +0200)]
lib/replace: fix rep_strtoull() prototype
metze
Jeremy Allison [Fri, 22 Oct 2010 22:58:40 +0000 (15:58 -0700)]
Revert "Wrap security_token_has_privilege() with a check for lp_enable_privileges(). Needed"
Not needed - privileges code prevents "enable privileges = no" from adding privileges
anyway.
This reverts commit
a8b95686a7bde3f96f141b6938e24e101567ef54.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct 22 23:41:36 UTC 2010 on sn-devel-104
Kamen Mazdrashki [Fri, 22 Oct 2010 21:13:09 +0000 (00:13 +0300)]
s4-dsdb_syntax: Setup "String(Case Sensitive)" syntax
Currently it is mapped to Octet String LDAP syntax
for comparison purposes.
According to LDAP rfc we should be using same comparison
as Directory String (LDB_SYNTAX_DIRECTORY_STRING), but case sensitive.
But according to ms docs binary compare should do the job:
http://msdn.microsoft.com/en-us/library/
cc223200(v=PROT.10).aspx
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Fri Oct 22 22:19:50 UTC 2010 on sn-devel-104
Jeremy Allison [Fri, 22 Oct 2010 17:31:06 +0000 (10:31 -0700)]
Wrap security_token_has_privilege() with a check for lp_enable_privileges(). Needed
to maintain compatibility with smb.conf manpage.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct 22 18:15:48 UTC 2010 on sn-devel-104
Jeremy Allison [Thu, 21 Oct 2010 19:50:33 +0000 (12:50 -0700)]
Fix const warning. Allocate off NULL as we always talloc_free().
Kamen Mazdrashki [Wed, 20 Oct 2010 10:49:46 +0000 (13:49 +0300)]
s4-dsdb/schema_syntax: Separate validation for numericoid OID values
This implementation doesn't use prefixMap/Schema to validate
numericoid OIDs. We may not have this OID yet, so I see no point
checking schema for if we have it.
Side effect of using prefixMap/Schema for validating numericoids
is that we mistakenly add the OID to the prefixMap.
This led to a corrupted prefixMap in LDB.
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Thu Oct 21 23:32:26 UTC 2010 on sn-devel-104
Kamen Mazdrashki [Wed, 20 Oct 2010 10:46:34 +0000 (13:46 +0300)]
asn1_tests: Implement negative unit-tests for ber_write_OID_String()
Kamen Mazdrashki [Wed, 20 Oct 2010 10:45:59 +0000 (13:45 +0300)]
asn1: ber_write_OID_String() to be more picky about supplied OID
Now function will check for invalid OID handling cases where:
- sub-identifier has invalid characters (non-digit)
- 'dot' separator found on unexpected place. For instance
'.' at start or end of the OID. Two '.' in a row.
Matthieu Patou [Thu, 21 Oct 2010 21:01:53 +0000 (01:01 +0400)]
waf: Mark the replacement zlib private so that it can build on machine without a system zlib
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Thu Oct 21 21:47:46 UTC 2010 on sn-devel-104
Matthieu Patou [Wed, 20 Oct 2010 22:14:39 +0000 (02:14 +0400)]
replace: use replace for non 'samba' compliant strptime
Matthieu Patou [Wed, 20 Oct 2010 20:13:54 +0000 (00:13 +0400)]
replace: use a wrapper around strtoll if it didn't behave as expected
Jelmer Vernooij [Thu, 21 Oct 2010 19:43:13 +0000 (21:43 +0200)]
Lowercase socket_wrapper name.
Avoid linking against socket_wrapper outside of developer mode.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Oct 21 20:26:11 UTC 2010 on sn-devel-104
Andrew Bartlett [Thu, 21 Oct 2010 10:08:45 +0000 (21:08 +1100)]
s4-dsdb extended_dn_out: Move lazy dereference control creation to lazy-init
We didn't seem to get the control created by the time we do searches here.
Andrew Bartlett
Autobuild-User: Anatoliy Atanasov <anatoliy@samba.org>
Autobuild-Date: Thu Oct 21 12:29:54 UTC 2010 on sn-devel-104
Jelmer Vernooij [Thu, 21 Oct 2010 09:51:37 +0000 (11:51 +0200)]
tdb: Set _PUBLIC_ in C file rather than header files (Debian bug 600898)
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu Oct 21 11:47:22 UTC 2010 on sn-devel-104
Andrew Tridgell [Thu, 21 Oct 2010 10:17:57 +0000 (21:17 +1100)]
s4-waf: we don't need the smbtorture.static for s3 any more
this breaks the build farm
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Oct 21 11:04:21 UTC 2010 on sn-devel-104
Andrew Tridgell [Thu, 21 Oct 2010 09:41:06 +0000 (20:41 +1100)]
autobuild: don't cleanup the pid file within the retry loop
if we rebase and retry we need to keep the pid file
Andrew Tridgell [Thu, 21 Oct 2010 09:21:10 +0000 (20:21 +1100)]
waf: RPC_NDR_WINBIND is samba4 specific
this caused problems with the s3 waf build
Matthias Dieter Wallnöfer [Thu, 21 Oct 2010 08:28:32 +0000 (10:28 +0200)]
ldb:ldb_modules.c - "dlclose" could cause inference on "dlerror"
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Oct 21 09:28:19 UTC 2010 on sn-devel-104
Andrew Tridgell [Thu, 21 Oct 2010 07:36:41 +0000 (18:36 +1100)]
waf: check the linker accepts a set of ldflags before using them
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Oct 21 08:45:49 UTC 2010 on sn-devel-104
Andrew Tridgell [Thu, 21 Oct 2010 07:17:59 +0000 (18:17 +1100)]
s4-dsdb: force LDB_ERR_NO_SUCH_ATTRIBUTE on missing schemaInfo
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 06:55:24 +0000 (17:55 +1100)]
s4-ldb: make ldb_options_find() public
we need to make this symbol public to allow for -Wl,-no-undefined, as
otherwise the pyldb module can't find the symbol when it creates the
module
Andrew Tridgell [Thu, 21 Oct 2010 06:45:23 +0000 (17:45 +1100)]
waf: loosen the restriction on depending on python libs
the pidl generated python code can generate dependencies between two
python modules, so we have to allow this for now
Andrew Tridgell [Thu, 21 Oct 2010 06:44:32 +0000 (17:44 +1100)]
waf-python: make the pyext flag add the pyembed features for libraries
this is rather strange, but we get build errors without it. There may
be a bug in the waf python tool, or I may misunderstand how to use it
Andrew Tridgell [Thu, 21 Oct 2010 06:41:42 +0000 (17:41 +1100)]
waf: fixed the handling of -Wl,-no-undefined
this flag was not being propogated to our link rules, so we were not
in fact enforcing no undefined symbols in libraries.
Andrew Tridgell [Thu, 21 Oct 2010 06:36:15 +0000 (17:36 +1100)]
s4-librpc: fixed depenencies for libcli/security
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 06:34:55 +0000 (17:34 +1100)]
libcli: LIBSECURITY depends on NDR_SECURITY
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 06:14:10 +0000 (17:14 +1100)]
s4-dsdb: fixed depenencies for -no-undefined
added some depenencies needed for -Wl,-no-undefined
Andrew Tridgell [Thu, 21 Oct 2010 06:13:26 +0000 (17:13 +1100)]
s4-events: LIBEVENTS depends on LIBSAMBA-UTIL
it needs it for the debug code
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 06:12:31 +0000 (17:12 +1100)]
s4-rpc_server: split out DCERPC_SHARE as a separate subsystem
this avoids a problem with -Wl,-no-undefined in the ntvfs layer
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 06:11:20 +0000 (17:11 +1100)]
s4-python: python_samba needs pyext
Andrew Tridgell [Thu, 21 Oct 2010 04:30:27 +0000 (15:30 +1100)]
waf: show duplicate objects in python modules as well as libraries
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 04:27:50 +0000 (15:27 +1100)]
s4-waf: removed the dependency loop between ntvfs and dcerpc_server
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 04:27:25 +0000 (15:27 +1100)]
librpc: added a few more NDR_* targets to NDR_SAMBA
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 04:26:38 +0000 (15:26 +1100)]
s4-ldb: make pyldb_util a private library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 04:26:20 +0000 (15:26 +1100)]
librpc: added RPC_NDR_SAMBA grouping library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 04:26:00 +0000 (15:26 +1100)]
lib: make WRAP_XATTR a private library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 04:25:44 +0000 (15:25 +1100)]
waf: added pyext option to SAMBA_LIBRARY()
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 03:58:14 +0000 (14:58 +1100)]
librpc: added NDR_XATTR and NDR_UNIXINFO to the NDR_SAMBA grouping library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 03:57:34 +0000 (14:57 +1100)]
s4-python: added a samba_python grouping library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 03:56:59 +0000 (14:56 +1100)]
s4-param: added a libshares grouping library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 03:56:36 +0000 (14:56 +1100)]
s3-waf: mark some libraries as private
public libraries must have a vnum specified
Andrew Tridgell [Thu, 21 Oct 2010 03:55:19 +0000 (14:55 +1100)]
waf: raise an error on a dependency on a python module
it is never correct to list a dependency on a python module
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 03:54:11 +0000 (14:54 +1100)]
s4-waf: don't depend directly on python modules
build rules should not list dependencies on python modules. Instead,
if code needs the module it should use the python API import calls to
access the module.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 03:52:25 +0000 (14:52 +1100)]
s4-waf: removed the XATTR and SASL aliases
these were hangovers from the old build system names
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 02:52:47 +0000 (13:52 +1100)]
waf: prevent the global deps list creating depenency loops
this prevents a loop between SOCKET_WRAPPER and replace in the s3 waf
build
Andrew Tridgell [Thu, 21 Oct 2010 02:52:15 +0000 (13:52 +1100)]
s4-libcli: make LIBSECURITY_SESSION a private library
Andrew Tridgell [Thu, 21 Oct 2010 02:51:55 +0000 (13:51 +1100)]
s4-socket: make LIBNETIF a private library
Andrew Tridgell [Thu, 21 Oct 2010 02:51:40 +0000 (13:51 +1100)]
s4-events: make LIBEVENTS a private library
Andrew Tridgell [Thu, 21 Oct 2010 02:51:21 +0000 (13:51 +1100)]
s4-kdc: make DB_GLUE a private library
Andrew Tridgell [Thu, 21 Oct 2010 02:51:02 +0000 (13:51 +1100)]
s4-dsdb: make ldb_password_hash depend on hdb not HEIMDAL_HDB_KEYS
this prevents a duplicate object file
Andrew Tridgell [Thu, 21 Oct 2010 02:50:13 +0000 (13:50 +1100)]
nsswitch: make LIBWINBIND-CLIENT a private library
Andrew Tridgell [Thu, 21 Oct 2010 02:49:55 +0000 (13:49 +1100)]
nsswitch: make LIBWBCLIENT a private library
Andrew Tridgell [Thu, 21 Oct 2010 01:58:31 +0000 (12:58 +1100)]
lib: add UTIL_TEVENT to samba_sockets grouping library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 01:57:56 +0000 (12:57 +1100)]
s4-libcli: make LIBSAMBA-ERRORS a private library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 01:57:36 +0000 (12:57 +1100)]
s4-lib: make SMBPASSWD a private library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 01:47:57 +0000 (12:47 +1100)]
s4-dsdb: moved a bunch of fuctions from schema/schema_info_attr.c to samdb/ldb_modules/schema_util.c
these functions operate on ldb_modules, so they should be in the
ldb_modules directory. They also should return ldb errors codes, not
WERROR codes, as otherwise the error can be hidden from the ldap
caller
This re-arrangement fixes a dependency loop in the schema/samdb code.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Pair-Programmed-With: Kamen Mazdrashki <kamenim@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 00:29:46 +0000 (11:29 +1100)]
s4-waf: make NDR_STANDARD a grouping library and add NDR_SAMBA4
this collects a number of subsystems into logical groups
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 00:28:58 +0000 (11:28 +1100)]
s4-build: make LIBSAMBA-NET a private library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 00:28:27 +0000 (11:28 +1100)]
waf-build: create a NDR_SAMBA grouping library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 00:28:05 +0000 (11:28 +1100)]
waf-build: create a samba_sockets grouping library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Thu, 21 Oct 2010 00:25:59 +0000 (11:25 +1100)]
s4-waf: removed dependencies on missing subsystems
these were left over from the old config.mk system
Andrew Tridgell [Thu, 21 Oct 2010 00:22:36 +0000 (11:22 +1100)]
waf: replace the is_bundled option with private_library
'private_library' better captures what we are trying to get at when we
bundle a library
Andrew Tridgell [Thu, 21 Oct 2010 00:19:09 +0000 (11:19 +1100)]
waf: added the concept of a grouping_library
a grouping library is one which 'groups' a set of subsystems. This
means that if a target depends on a subsystem that is within a
grouping library then that dependency is replaced with a dependency on
the grouping library.
This gives us a powerful method to avoid duplicated object files
between libraries.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 20 Oct 2010 21:59:06 +0000 (08:59 +1100)]
s4-build: fixed some formatting
indentation was far too deep
Andrew Tridgell [Wed, 20 Oct 2010 21:58:35 +0000 (08:58 +1100)]
build: subunit and popt need to be marked as private libraries
they have no vnum
Andrew Tridgell [Wed, 20 Oct 2010 21:54:36 +0000 (08:54 +1100)]
waf: cope with libraries with a specified version number
this fixes a problem with libnss_winbind.so.2. Thanks to Jelmer for
spotting this.
Andrew Tridgell [Wed, 20 Oct 2010 21:30:55 +0000 (08:30 +1100)]
s4-libcli: make LIBCLI_LDAP a private library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 20 Oct 2010 21:30:39 +0000 (08:30 +1100)]
s4-auth: make auth a private library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 20 Oct 2010 21:30:15 +0000 (08:30 +1100)]
replace: make libreplace a private library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 20 Oct 2010 21:29:24 +0000 (08:29 +1100)]
s4-ndr: make NDR_TABLE a private library
this greatly reduces the size of ndrdump, and saves us a fair bit of
duplication
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 20 Oct 2010 21:28:35 +0000 (08:28 +1100)]
libcli: make LIBCLI_NBT a private library
Andrew Tridgell [Wed, 20 Oct 2010 21:28:12 +0000 (08:28 +1100)]
wrapper: make socket_wrapper, uid_wrapper and nss_wrapper private libs
this prevents double instantiation
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 20 Oct 2010 21:27:07 +0000 (08:27 +1100)]
waf: re-work the module alias code
we now create a base library, and then create the alias modules as
wrappers around that base. That prevents double instantiation of any
object files in the modules
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 20 Oct 2010 07:19:55 +0000 (18:19 +1100)]
s4-dsdb: make SAMDB_COMMON into a private library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 20 Oct 2010 07:19:31 +0000 (18:19 +1100)]
libcli: make the LIBSECURITY subsystem into a private library
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 20 Oct 2010 07:17:52 +0000 (18:17 +1100)]
waf: fixed expansion of direct_objects and direct_libs
these do not need to be expanded in break_dependency_loops()
Andrew Tridgell [Wed, 20 Oct 2010 07:17:13 +0000 (18:17 +1100)]
waf: allows libraries to be marked as private_library=True
this is for libraries where we make no promises about the API, but
where we wish it to be a library to allow our binaries to use common
code.
These libraries always get the project suffix added to the library
name, to ensure we are in a separate namespace
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 20 Oct 2010 07:11:31 +0000 (18:11 +1100)]
waf: rework expand_subsystem_deps()
make the variable names a lot clearer, and restrict the expansion of
subsystem deps to object style subsystems and modules. If a subsystem
or a module is built as a library then we don't need to expand the
dependencies across that boundary
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Andrew Tridgell [Wed, 20 Oct 2010 07:09:45 +0000 (18:09 +1100)]
waf: added --show-deps and --show-duplicates
these options make it easier to examine our depenency tree, by showing
any objects linked into more than one library, and by showing the
dependency tree for a chosen target
Matthias Dieter Wallnöfer [Thu, 21 Oct 2010 06:51:46 +0000 (08:51 +0200)]
ldb:ldb_modules.c - if we don't find the associated dynamic object then please close the handle
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Oct 21 07:52:44 UTC 2010 on sn-devel-104
Matthias Dieter Wallnöfer [Thu, 21 Oct 2010 07:03:31 +0000 (09:03 +0200)]
ldb:ldb_tdb/ldb_cache.c - remove a superflous "talloc_free"
Didn't realise that this is already called by "ltdb_attributes_unload".
Matthias Dieter Wallnöfer [Thu, 21 Oct 2010 06:45:06 +0000 (08:45 +0200)]
ldb:ldb_tdb/ldb_cache.c - in this function we don't use LDB return codes
Matthias Dieter Wallnöfer [Wed, 20 Oct 2010 17:55:28 +0000 (19:55 +0200)]
s4:lib/util/charset/iconv.c - remove a distinction which can never happen
"ret->cd_direct" is never set before. It is set in the "if" upperwards but
then the function is terminated with "return".
Jeremy Allison [Thu, 21 Oct 2010 00:51:13 +0000 (17:51 -0700)]
Now we have SeSystemSecurity, remove the source3-only #ifdef.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Oct 21 01:35:00 UTC 2010 on sn-devel-104
Jeremy Allison [Wed, 20 Oct 2010 23:31:18 +0000 (16:31 -0700)]
Add code to implement SeSecurityPrivilege in net rpc rights, and in the
open and get/set NT security descriptor code.
Jeremy.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Oct 21 00:15:57 UTC 2010 on sn-devel-104
Kamen Mazdrashki [Fri, 8 Oct 2010 01:21:07 +0000 (04:21 +0300)]
pytalloc: use talloc_unlink() to free py_talloc objects
Those type of objects are referenced every time we assign
them to other py_talloc objects, which leads to runtime
warnings that we are trying to free an object with references
Wrap talloc_unlink() in SMB_ASSERT() to ensure we catch possible failure
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org>
Autobuild-Date: Wed Oct 20 21:37:06 UTC 2010 on sn-devel-104
Simo Sorce [Wed, 20 Oct 2010 17:09:57 +0000 (13:09 -0400)]
talloc: make header C++ safe
Autobuild-User: Simo Sorce <idra@samba.org>
Autobuild-Date: Wed Oct 20 18:15:09 UTC 2010 on sn-devel-104
James Peach [Wed, 20 Oct 2010 17:07:33 +0000 (10:07 -0700)]
smbtorture: Fix typo in status message.