r25142: Panic if setting the group list fails while switching security

[ira/wip.git] / source3 / smbd / sec_ctx.c

diff --git a/source3/smbd/sec_ctx.c b/source3/smbd/sec_ctx.c
index 67b15dc014cb748b2bbd00df1f33c300681c03e7..108d1794c71403b19ffe45e8c93296817d86e60d 100644 (file)
--- a/source3/smbd/sec_ctx.c
+++ b/source3/smbd/sec_ctx.c
@@ -239,7 +239,9 @@ static void set_unix_security_ctx(uid_t uid, gid_t gid, int ngroups, gid_t *grou
        /* Start context switch */
        gain_root();
 #ifdef HAVE_SETGROUPS
-       sys_setgroups(gid, ngroups, groups);
+       if (sys_setgroups(gid, ngroups, groups) != 0) {
+               smb_panic("sys_setgroups failed");
+       }
 #endif
        become_id(uid, gid);
        /* end context switch */
@@ -282,6 +284,7 @@ static void set_unix_security_ctx(uid_t uid, gid_t gid, int ngroups, gid_t *grou
                DEBUG(0, ("WARNING: failed to set group list "
                        "(%d groups) for UID %ld: %s\n",
                        ngroups, uid, strerror(errno)));
+               smb_panic("sys_setgroups failed");
        }
 
        become_uid(uid);