Matthias Dieter Wallnöfer [Thu, 27 May 2010 15:00:50 +0000 (17:00 +0200)]
s4:regshell - don't use negative exit codes
Matthias Dieter Wallnöfer [Thu, 27 May 2010 14:59:14 +0000 (16:59 +0200)]
s4:client/client.c - fix "asprintf"s
Fix the result values or change them into "talloc_asprintf"s where possible
see bug #6404
Andrew Bartlett [Fri, 28 May 2010 05:20:03 +0000 (15:20 +1000)]
waf Read VERSION file inside WAF to set package version
This replaces the call to mkversion.sh in both the Samba3 and Samba4
WAF builds.
Andrew Bartlett
Günther Deschner [Thu, 27 May 2010 22:02:15 +0000 (00:02 +0200)]
s3-lanman: Fix api_RNetUserGetInfo level 2 marshalling offset calculation.
54 + 4 = 58 (and not 60).
Found by torture test.
Guenther
Günther Deschner [Fri, 28 May 2010 00:47:12 +0000 (02:47 +0200)]
s3-auth: fix c++ buildwarnings.
Guenther
Günther Deschner [Fri, 28 May 2010 00:20:21 +0000 (02:20 +0200)]
s3-build: remove duplicate ndr_krb5pac.h inclusion.
Guenther
Günther Deschner [Fri, 28 May 2010 00:20:02 +0000 (02:20 +0200)]
s3-build: use ndr_misc.h where needed.
Guenther
Günther Deschner [Fri, 28 May 2010 00:18:21 +0000 (02:18 +0200)]
s3-build: only use ndr_samr.h where needed.
Guenther
Günther Deschner [Fri, 28 May 2010 00:16:38 +0000 (02:16 +0200)]
s3-idl: fix some missing dependencies to other IDL files.
Guenther
Günther Deschner [Thu, 27 May 2010 23:19:25 +0000 (01:19 +0200)]
s3-rpc_client: move protos to init_netlogon.h
Guenther
Simo Sorce [Fri, 28 May 2010 00:40:22 +0000 (20:40 -0400)]
s3:auth Add comment to clarify usage of session keys.
Explain why we have what looks like a duplicate of session keys.
It is in fact not a duplicate.
Simo Sorce [Thu, 27 May 2010 23:41:07 +0000 (19:41 -0400)]
s3:auth remove login_server from server info
It is not used anymore, we have that information in
info3->base.logon_server already
Simo Sorce [Thu, 27 May 2010 23:22:02 +0000 (19:22 -0400)]
Fix Out of memory checks
Günther pushed an older version of the patch "s3:auth add function to copy a
netr_SamInfo3 structure" that was missing these fixes.
Simo Sorce [Thu, 27 May 2010 07:21:35 +0000 (03:21 -0400)]
s3:auth add function to convert wbcAuthUserInfo to netr_SamInfo3
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Thu, 27 May 2010 09:31:45 +0000 (05:31 -0400)]
s3:auth Free sampass as soon as we have server_info
We don't keep sampass in server_info anymore
So it makes no sense to keep it around.
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Thu, 27 May 2010 07:41:56 +0000 (03:41 -0400)]
s3:auth use info3 in auth_serversupplied_info
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Thu, 27 May 2010 06:40:59 +0000 (02:40 -0400)]
s3:auth add function to copy a netr_SamInfo3 structure
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Thu, 27 May 2010 06:07:33 +0000 (02:07 -0400)]
s3:auth: add function to convert samu to netr_SamInfo3
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Thu, 27 May 2010 14:10:10 +0000 (16:10 +0200)]
s4-smbtorture: finally test all levels in rap_NetUserGetInfo RAP-SAM test.
Guenther
Günther Deschner [Thu, 29 Apr 2010 21:34:27 +0000 (23:34 +0200)]
s4-smbtorture: remove obsolete handmarshalled rap code.
Guenther
Günther Deschner [Thu, 29 Apr 2010 23:09:46 +0000 (01:09 +0200)]
s4-smbtorture: we can fully use autogenerated code to pull info unions now.
Guenther
Günther Deschner [Thu, 29 Apr 2010 23:08:07 +0000 (01:08 +0200)]
libndr: add support for relative_rap_convert.
Will not harm anyone, is only used for rare short (2byte) relative pointers, and
relative_rap_convert is always 0 so far (as all init functions using struct
ndr_pull will zero the struct).
Guenther
Kai Blin [Thu, 27 May 2010 20:45:13 +0000 (22:45 +0200)]
s3-waf: Fix typo
Sorry for the noise
Kai Blin [Thu, 27 May 2010 20:42:23 +0000 (22:42 +0200)]
s3-waf: Also set "developer" env when building in developer mode
Volker Lendecke [Thu, 27 May 2010 16:12:30 +0000 (18:12 +0200)]
s3: Fix a bad memleak in the async echo responder
Günther Deschner [Thu, 27 May 2010 15:09:39 +0000 (17:09 +0200)]
s3-waf: fix the build after tstream changes.
Guenther
Volker Lendecke [Thu, 27 May 2010 12:27:58 +0000 (14:27 +0200)]
s3: Remove an unused variable
Günther Deschner [Wed, 26 May 2010 21:36:33 +0000 (23:36 +0200)]
s3-lanman: use samr for api_RNetUserGetInfo.
Following MS-RAP 3.2.5.13 NetUserGetInfo Command.
Guenther
Günther Deschner [Thu, 27 May 2010 11:25:31 +0000 (13:25 +0200)]
s4-smbtorture: create the user to test in test_usergetinfo() in RAP-SAM.
Guenther
Holger Hetterich [Sun, 23 May 2010 21:18:58 +0000 (23:18 +0200)]
vfs_smb_traffic_analyzer.c: set the len variable when running protocol v1.
Signed-off-by: Andreas Schneider <asn@samba.org>
Stefan Metzmacher [Tue, 27 Apr 2010 13:15:09 +0000 (15:15 +0200)]
s3:rpc_server: make use of the npa_tstream code to connect to named pipes
This way we use the newest protocol, which is able to pass
the local and remote address of the SMB connection.
And we correctly support message mode named pipes
without the hack that analyzes the content for DCERPC pdus.
metze
Stefan Metzmacher [Tue, 27 Apr 2010 13:08:02 +0000 (15:08 +0200)]
s3:Makefile.in: add npa_tstream.o to the build of smbd
metze
Stefan Metzmacher [Tue, 27 Apr 2010 13:12:32 +0000 (15:12 +0200)]
s3:rpc_server: pass down local and remote tsocket_address to np_open()
metze
Stefan Metzmacher [Wed, 28 Apr 2010 13:15:23 +0000 (15:15 +0200)]
s3:smbd: add PIPE_BUSY handling for SMBtrans calls on named pipes
metze
Stefan Metzmacher [Wed, 28 Apr 2010 13:05:30 +0000 (15:05 +0200)]
s3:rpc_server: add np_read_in_progress() function
metze
Stefan Metzmacher [Wed, 26 May 2010 08:43:19 +0000 (10:43 +0200)]
s3:rpc_server: make sure we don't send uninitialized memory for the named_pipe_auth handshake
metze
Günther Deschner [Wed, 26 May 2010 21:17:35 +0000 (23:17 +0200)]
s3-net: fix the build.
Guenther
Günther Deschner [Wed, 26 May 2010 19:22:13 +0000 (21:22 +0200)]
s4-smbtorture: add usergetinfo to RAP-SAM.
Guenther
Günther Deschner [Wed, 26 May 2010 20:55:45 +0000 (22:55 +0200)]
rap: use rap_LogonHours in rap_NetUserInfo11 as well.
Guenther
Günther Deschner [Wed, 26 May 2010 11:29:35 +0000 (13:29 +0200)]
s3-waf: more work on krb5 build.
Guenther
Kai Blin [Tue, 25 May 2010 15:53:16 +0000 (17:53 +0200)]
s3-waf: Allow to build with kerberos support
Günther Deschner [Wed, 26 May 2010 20:49:01 +0000 (22:49 +0200)]
s3-lanman: remove defines now provided by IDL.
Guenther
Günther Deschner [Wed, 26 May 2010 20:48:32 +0000 (22:48 +0200)]
rap: fix typo in IDL.
Guenther
Günther Deschner [Wed, 26 May 2010 20:32:32 +0000 (22:32 +0200)]
s3-waf: fix the build after chgpasswd.c changes.
Guenther
Günther Deschner [Wed, 26 May 2010 18:59:40 +0000 (20:59 +0200)]
s4-smbtorture: add smbcli_rap_netusergetinfo().
Guenther
Günther Deschner [Wed, 26 May 2010 18:54:50 +0000 (20:54 +0200)]
rap: add rap_NetUserGetInfo IDL.
Guenther
Günther Deschner [Tue, 18 May 2010 10:06:23 +0000 (12:06 +0200)]
s3-samr: move chgpasswd.c out of smbd and into the samr server.
Guenther
Günther Deschner [Fri, 7 May 2010 17:26:06 +0000 (19:26 +0200)]
s3-smbd: remove unused change/check_lanman_password.
Guenther
Günther Deschner [Tue, 11 May 2010 00:24:43 +0000 (02:24 +0200)]
s3-lanman: parse encrypted and min_pwd_length in api_SetUserPassword().
Guenther
Günther Deschner [Fri, 7 May 2010 12:37:25 +0000 (14:37 +0200)]
s3-lanman: use samr for api_SetUserPassword().
Guenther
Matthias Dieter Wallnöfer [Wed, 26 May 2010 15:41:50 +0000 (17:41 +0200)]
flags.h - fix comment for "GTYPE_SECURITY_UNIVERSAL_GROUP" constant
Björn Jacke [Wed, 26 May 2010 15:22:24 +0000 (17:22 +0200)]
s3:Makefile: add missing linker flags for smbfilter
this should fix the AIX build
Björn Jacke [Wed, 26 May 2010 15:18:59 +0000 (17:18 +0200)]
s3:Makefile: fix a typo in flag variable name
Günther Deschner [Wed, 26 May 2010 13:14:20 +0000 (15:14 +0200)]
s3-printing: fix buildwarning in publishing code after registry changes.
Guenther
Simo Sorce [Wed, 28 Apr 2010 14:23:48 +0000 (10:23 -0400)]
s3-lanman: Migrated to rpc_connect_spoolss_pipe().
Signed-off-by: Günther Deschner <gd@samba.org>
Simo Sorce [Wed, 28 Apr 2010 13:51:12 +0000 (09:51 -0400)]
s3-rpc_server: Created a per connection spoolss pipe.
This way all code can reuse the same connection to spoolss
and not have to deal with the creation of a new pipe all over the
code every time we need to ask a service off spoolss.
Signed-off-by: Günther Deschner <gd@samba.org>
Kai Blin [Wed, 26 May 2010 12:09:39 +0000 (14:09 +0200)]
s3-waf: Build smbclient binary
Kai Blin [Wed, 26 May 2010 12:09:06 +0000 (14:09 +0200)]
s3-waf: Fix the naming of some variables introduced recently
Kamen Mazdrashki [Wed, 26 May 2010 01:22:34 +0000 (04:22 +0300)]
s4/test: Connect SAMR and LDARPC pipes before calling libnet_ functions
In multi-DC environment, NBT name resolution may resolv
domain name to any of DCs.
This make this test to fail, as we are modifying the user account
on one DC and query user info immediately after that on another DC.
Kamen Mazdrashki [Wed, 26 May 2010 10:32:13 +0000 (13:32 +0300)]
s4/test: remove unused code
There is no need anymore to modify samAccountName
of the testing user to original value as test_cleanup()
will spot the right samAccountName to delete
Kamen Mazdrashki [Wed, 26 May 2010 10:27:07 +0000 (13:27 +0300)]
s4/test: make test_cleanup() in libnet_user library more robust
test_cleanup() is called always with RDN name of the user to be deleted.
When modify-user test fails however, we end up with a user
with RDN = libnetusertest and samAccountName = random_name.
This way we can not delete the user and the error message is
quite misleading (I've spent a *lot* of time trying to figure out
if the database is corrupted because of this error).
Kamen Mazdrashki [Tue, 25 May 2010 14:24:45 +0000 (17:24 +0300)]
s4/test: rename enum test_fields{} member names to be more descriptive
Kamen Mazdrashki [Sat, 22 May 2010 02:03:16 +0000 (05:03 +0300)]
s4/test: Replace hand-made field count to test
This patch replaces hand-make count of fields to be tested
with defines for FIRST-LAST value for corresponding fields
to test with.
As a side-effect, 'acct_flags' is now included in tests.
Björn Jacke [Wed, 26 May 2010 08:18:03 +0000 (10:18 +0200)]
s3:configure: use the right AC_CACHE_CHECK variable
Simo Sorce [Fri, 21 May 2010 16:29:22 +0000 (12:29 -0400)]
s4:smbd: Use tstream_npa_accept_existing to accept named pipe connections
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Simo Sorce [Fri, 21 May 2010 14:34:58 +0000 (10:34 -0400)]
s4:smbd: Add tstream to the stream_connection structure
Simo Sorce [Wed, 19 May 2010 21:02:52 +0000 (17:02 -0400)]
named_pipe_auth: implement tstream_npa_accept_existing_send/recv
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Kai Blin [Tue, 25 May 2010 22:16:10 +0000 (00:16 +0200)]
s3-waf: Check for additional options on *xattr
Kai Blin [Tue, 25 May 2010 21:57:41 +0000 (23:57 +0200)]
s3-waf: Add darwin to the host_os-specific checks
Kai Blin [Tue, 25 May 2010 21:53:04 +0000 (23:53 +0200)]
s3-waf: Don't hardcode the name of the awk executable in wscript_build
Jeremy Allison [Tue, 25 May 2010 18:39:46 +0000 (11:39 -0700)]
Standardize debug messages for read and write.
Jeremy.
Michael Adam [Tue, 25 May 2010 15:28:05 +0000 (17:28 +0200)]
s3:fix the waf build after registry changes.
Günther Deschner [Tue, 25 May 2010 10:43:00 +0000 (12:43 +0200)]
s3-net: fix a "dereferencing type-punned pointer will break strict-aliasing rules" warning.
Guenther
Günther Deschner [Tue, 25 May 2010 10:27:02 +0000 (12:27 +0200)]
s3-waf: very simple start on getting krb5 build to work.
Guenther
Matthias Dieter Wallnöfer [Tue, 25 May 2010 09:21:46 +0000 (11:21 +0200)]
s4:torture/rpc/samr.c: Fix the "ValidatePassword" test
It was failing randomly due to an uninitialised "status" variable.
Michael Adam [Tue, 25 May 2010 08:53:17 +0000 (10:53 +0200)]
s3:registry: add C for substantial changes to reg_objects
Michael Adam [Tue, 25 May 2010 08:32:51 +0000 (10:32 +0200)]
s3:registry:reg_objects: Remove use of uint{8,16,32} in favour of C99 types
Michael Adam [Tue, 25 May 2010 06:54:29 +0000 (08:54 +0200)]
s3:registry: add comment header block to registry.h
Michael Adam [Mon, 24 May 2010 23:00:37 +0000 (01:00 +0200)]
s3:registry: move reg_objects.h to registry/ and use it only where needed
Every place outside of registry/ where this is used, should probably
be changed to use pure reg_api.c code.
Michael Adam [Mon, 24 May 2010 22:42:50 +0000 (00:42 +0200)]
s3:registry: move non-reg_objects definitions from reg_objects.h to registry.h
Michael Adam [Sun, 23 May 2010 22:05:26 +0000 (00:05 +0200)]
s3:registry: hide definition of regval_ctr and regval_blob in reg_objects.c
Michael Adam [Mon, 24 May 2010 13:10:48 +0000 (15:10 +0200)]
s3:net rpc registry: use regval_ctr_init() instead of direct allocation
Michael Adam [Mon, 24 May 2010 13:08:58 +0000 (15:08 +0200)]
s3:profiles: use regval_ctr_init() instead of direct allocation
Michael Adam [Mon, 24 May 2010 13:07:47 +0000 (15:07 +0200)]
s3:rpcclient:spoolss: use regval_ctr/blob accessor functions.
Michael Adam [Mon, 24 May 2010 12:48:31 +0000 (14:48 +0200)]
s3:net_rpc_printer: use regval_blob/ctr accessor functions
Michael Adam [Mon, 24 May 2010 12:18:21 +0000 (14:18 +0200)]
s3:net rpc printer: fix use of a possibly uninitialized variable
Michael Adam [Mon, 24 May 2010 12:08:01 +0000 (14:08 +0200)]
s3:nt_printing: use regval_ctr_init().
Michael Adam [Mon, 24 May 2010 12:06:20 +0000 (14:06 +0200)]
s3:srv_ntsvcs: use regval_ctr/blob accessor functions
Michael Adam [Mon, 24 May 2010 12:03:46 +0000 (14:03 +0200)]
s3:services_db: use regval_ctr_init() instead of direct allocation
Michael Adam [Mon, 24 May 2010 11:57:35 +0000 (13:57 +0200)]
s3:libads:use regval_ctr/blob accessor functions in ldap_printer.c
Michael Adam [Sun, 23 May 2010 21:59:34 +0000 (23:59 +0200)]
s3:registry: use regval_ctr/blob accessor functoin in reg_eventlog.c
Michael Adam [Sun, 23 May 2010 21:58:28 +0000 (23:58 +0200)]
s3:registry: user regval_ctr/blob accessor functions in reg_backend_db.c
Michael Adam [Sun, 23 May 2010 21:56:40 +0000 (23:56 +0200)]
s3:registry: use regval_ctr/blob accessor functions in reg_api.c
Michael Adam [Sun, 23 May 2010 20:55:12 +0000 (22:55 +0200)]
s3:registry:reg_objects: add regval_ctr_set_seqnum()
Michael Adam [Sun, 23 May 2010 20:53:44 +0000 (22:53 +0200)]
s3:registry:reg_objects: add regval_ctr_get_seqnum()
Michael Adam [Sun, 23 May 2010 20:47:53 +0000 (22:47 +0200)]
s3:registry:reg_objects: add regval_ctr_init()
Michael Adam [Mon, 24 May 2010 22:31:01 +0000 (00:31 +0200)]
s3:registry: move definition of registry_hook to reg_init_full.c - it's only user
Michael Adam [Mon, 24 May 2010 22:15:52 +0000 (00:15 +0200)]
s3:registry: extract registry_pull/push_value prototypes into own header
reg_util_marshalling.h and use them only where needed.
Michael Adam [Mon, 24 May 2010 22:08:15 +0000 (00:08 +0200)]
s3:registry: rename lib/util_reg_api.c to registry/reg_util_marshalling.c
Michael Adam [Mon, 24 May 2010 22:04:13 +0000 (00:04 +0200)]
s3:registry: rename reg_util.{c,h} to reg_util_internal.{c,h}