netcmd: Split 'domain passwordsettings' into a super-command
authorTim Beale <timbeale@catalyst.net.nz>
Thu, 3 May 2018 00:12:04 +0000 (12:12 +1200)
committerGarming Sam <garming@samba.org>
Fri, 11 May 2018 04:01:24 +0000 (06:01 +0200)
commit7255e0ced33826d1e528c3e465105e7e194eb36e
tree59a801a60f0d5b1a885cadaf305a8bd93441e0a8
parent0da9dbbf5a762f0953f1860b8b04810d33557094
netcmd: Split 'domain passwordsettings' into a super-command

The show and set options are not really related to each other at all, so
it makes sense to split the code into 2 separate commands.

We also want to add separate sub-commands for PSOs in a subsequent
patch.

Because of the way the sub-command was implemented previously, it meant
that you could specify other command-line options before the 'set' or
'show' keyword, and the command would still be accepted. However, now
that it's a super-command 'set'/'show' needs to be specified before any
additional arguments, so we need to update the test code to reflect
this.

Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
python/samba/netcmd/domain.py
source4/setup/tests/blackbox_setpassword.sh
testprogs/blackbox/test_kinit_heimdal.sh
testprogs/blackbox/test_kinit_mit.sh
testprogs/blackbox/test_kpasswd_heimdal.sh
testprogs/blackbox/test_kpasswd_mit.sh
testprogs/blackbox/test_password_settings.sh