From 5c918d40bdc701d2eea384bd2890e7e4c5e490ca Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 27 May 2020 19:09:51 +0200 Subject: [PATCH] libsmb: Use tevent_req_received() in cli_qfileinfo_recv() That takes care of doing the early talloc_free(state) Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Thu May 28 20:35:41 UTC 2020 on sn-devel-184 --- source3/libsmb/clifile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c index 314893b4cf6..f2b12475b5b 100644 --- a/source3/libsmb/clifile.c +++ b/source3/libsmb/clifile.c @@ -6551,12 +6551,12 @@ NTSTATUS cli_qfileinfo_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx, } if (rdata != NULL) { *rdata = talloc_move(mem_ctx, &state->rdata); - } else { - TALLOC_FREE(state->rdata); } if (num_rdata != NULL) { *num_rdata = state->num_rdata; } + + tevent_req_received(req); return NT_STATUS_OK; } -- 2.34.1