arm64/sysreg: refactor deprecated strncpy
authorJustin Stitt <justinstitt@google.com>
Fri, 11 Aug 2023 16:33:51 +0000 (16:33 +0000)
committerWill Deacon <will@kernel.org>
Wed, 16 Aug 2023 14:50:55 +0000 (15:50 +0100)
commitd232606773a0b09ec7f1ffc25f63abe801d011fd
tree4acee58567032dbe83d5ff4df70e13cb1460aac7
parent18b8f57a7f51b4c834e5e974ec38133c02e9eb58
arm64/sysreg: refactor deprecated strncpy

`strncpy` is deprecated for use on NUL-terminated destination strings
[1]. Which seems to be the case here due to the forceful setting of `buf`'s
tail to 0.

A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on its destination buffer argument which is
_not_ the case for `strncpy`!

In this case, we can simplify the logic and also check for any silent
truncation by using `strscpy`'s return value.

This should have no functional change and yet uses a more robust and
less ambiguous interface whilst reducing code complexity.

Link: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings[1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://github.com/KSPP/linux/issues/90
Suggested-by: Kees Cook <keescook@chromium.org>
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Link: https://lore.kernel.org/r/20230811-strncpy-arch-arm64-v2-1-ba84eabffadb@google.com
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/kernel/idreg-override.c