metze/old/v3-2-winbind-ndr.git
17 years agoMake regsubkey_ctr_addkey return WERROR. Nobody checks this so far, but this
vlendec [Sat, 18 Nov 2006 17:46:32 +0000 (17:46 +0000)]
Make regsubkey_ctr_addkey return WERROR. Nobody checks this so far, but this
will change.

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19777 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoHmmm. I should have done one instead of three commits. Sorry :-)
vlendec [Sat, 18 Nov 2006 17:07:15 +0000 (17:07 +0000)]
Hmmm. I should have done one instead of three commits. Sorry :-)

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19776 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix typo
vlendec [Sat, 18 Nov 2006 17:06:43 +0000 (17:06 +0000)]
Fix typo

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19775 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix typo
vlendec [Sat, 18 Nov 2006 17:06:02 +0000 (17:06 +0000)]
Fix typo

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19774 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoTALLOC_FREE checks for NULL itself
vlendec [Sat, 18 Nov 2006 17:05:50 +0000 (17:05 +0000)]
TALLOC_FREE checks for NULL itself

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19773 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix a const-warning. Jerry, what did you want to fix with this line?
vlendec [Sat, 18 Nov 2006 11:29:29 +0000 (11:29 +0000)]
Fix a const-warning. Jerry, what did you want to fix with this line?

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19766 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoset version in 3.0 branch to 3.0.25
jerry [Fri, 17 Nov 2006 23:31:45 +0000 (23:31 +0000)]
set version in 3.0 branch to 3.0.25

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19764 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agolibaddns/*[ch] code fixes donated by Centeris Corporation
jerry [Fri, 17 Nov 2006 21:46:26 +0000 (21:46 +0000)]
libaddns/*[ch] code fixes donated by Centeris Corporation
(http://www.centeris.com/) under my copyright.

* Rework error reporting to use DNS_ERROR instead
  of int32
* Convert memory allocation to use talloc()
* Generalize the DNS request/response packet marshalling
* Fix the secure update requests

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19762 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoremove the LDAP_SCOPE_ONELEVEL define (not needed after svnup)
jerry [Fri, 17 Nov 2006 01:25:23 +0000 (01:25 +0000)]
remove the LDAP_SCOPE_ONELEVEL define (not needed after svnup)

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19758 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years ago* When using a krb5 session setup, we don't fill in the server_name
jerry [Thu, 16 Nov 2006 23:48:46 +0000 (23:48 +0000)]
* When using a krb5 session setup, we don't fill in the server_name
  string the clis_state struct.  So call saf_store() after we
  have the short domain name in the lsa_query_inof_policy code.

* Remove unused server string in saf_delete()

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19754 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoEnsure to link against the required libraries.
lmuelle [Thu, 16 Nov 2006 18:29:36 +0000 (18:29 +0000)]
Ensure to link against the required libraries.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19748 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoEnsure to link with the required objects.
lmuelle [Thu, 16 Nov 2006 18:16:57 +0000 (18:16 +0000)]
Ensure to link with the required objects.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19747 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFor the fun of it, add an CLDAP client written in perl.
gd [Thu, 16 Nov 2006 11:55:16 +0000 (11:55 +0000)]
For the fun of it, add an CLDAP client written in perl.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19745 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agomerge from samba4
metze [Thu, 16 Nov 2006 11:18:05 +0000 (11:18 +0000)]
merge from samba4

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19744 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agofix compiler warnings
metze [Thu, 16 Nov 2006 11:11:09 +0000 (11:11 +0000)]
fix compiler warnings

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19741 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agofix compiler warning
metze [Thu, 16 Nov 2006 11:02:34 +0000 (11:02 +0000)]
fix compiler warning

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19739 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoas libreplace always provides dlopen(), we need to always define SHLIBEXT
metze [Thu, 16 Nov 2006 06:29:18 +0000 (06:29 +0000)]
as libreplace always provides dlopen(), we need to always define SHLIBEXT

this fix the build on hpisgr8 HPUX 11.23

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19730 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agosync samba3's ldb with samba4
metze [Wed, 15 Nov 2006 17:34:20 +0000 (17:34 +0000)]
sync samba3's ldb with samba4

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19725 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agodefine SHLIBEXT (prepare ldb merge from samba4)
metze [Wed, 15 Nov 2006 15:31:11 +0000 (15:31 +0000)]
define SHLIBEXT (prepare ldb merge from samba4)

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19718 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix memory leak in get_conf_item_string(). As
jra [Wed, 15 Nov 2006 02:06:58 +0000 (02:06 +0000)]
Fix memory leak in get_conf_item_string(). As
we're just doing strchr on a const string there's
no need to strdup it before, we're never modifying
it. Just remove the variable "parm".
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19710 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix bug #4224 - deadtime timeout was broken
jra [Wed, 15 Nov 2006 01:06:45 +0000 (01:06 +0000)]
Fix bug #4224 - deadtime timeout was broken
because of this. Probably a show-stopper for 3.0.23d.
Thanks to Alain GORLIER <alain.gorlier@altissemiconductor.com>
for the fix.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19709 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix blocker bug for 3.0.23d - find_forced_group could
jra [Tue, 14 Nov 2006 20:21:23 +0000 (20:21 +0000)]
Fix blocker bug for 3.0.23d - find_forced_group could
return an uninitialized sid.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19705 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoDon't free a string if you want to return it!
idra [Tue, 14 Nov 2006 16:50:29 +0000 (16:50 +0000)]
Don't free a string if you want to return it!

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19703 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAnother fix.
idra [Mon, 13 Nov 2006 14:22:56 +0000 (14:22 +0000)]
Another fix.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19692 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix the build
idra [Mon, 13 Nov 2006 14:01:15 +0000 (14:01 +0000)]
Fix the build

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19691 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoRemove this ancient module, I never realized it was ported over.
idra [Mon, 13 Nov 2006 13:38:04 +0000 (13:38 +0000)]
Remove this ancient module, I never realized it was ported over.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19690 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix a NULL dereference found by coverity (the call to strlen).
vlendec [Mon, 13 Nov 2006 10:50:55 +0000 (10:50 +0000)]
Fix a NULL dereference found by coverity (the call to strlen).

Jerry, please check this. The way I understood alpha_strcpy the last arg needs
to be the size of the target, not of the source.

Thanks,

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19689 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix a deadcode warning by Coverity.
vlendec [Mon, 13 Nov 2006 10:43:12 +0000 (10:43 +0000)]
Fix a deadcode warning by Coverity.

Simo, I'm not sure this is the correct fix. So I'd like you to look at it and
merge to 4 if appropriate.

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19688 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix uninitialized variables found by Coverity (and gcc -O1... ;-))
vlendec [Mon, 13 Nov 2006 10:34:59 +0000 (10:34 +0000)]
Fix uninitialized variables found by Coverity (and gcc -O1... ;-))

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19687 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix the build
vlendec [Mon, 13 Nov 2006 09:58:51 +0000 (09:58 +0000)]
Fix the build

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19686 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoTwo changes inspired by problems with huge tdbs. tdbtool's list command now
vlendec [Mon, 13 Nov 2006 09:34:55 +0000 (09:34 +0000)]
Two changes inspired by problems with huge tdbs. tdbtool's list command now
prints the hash on every record for easier awk'ing, and tdbbackup allows a
different hash chain length on the backed up tdb.

Jeremy, Günther, this might be interesting for you huge domains. Not only
locking.tdb, also the winbind ones might grow huge.

In the installation I fixed with this winbind spent a huge amount of CPU
spinning through a degenerated winbindd_idmap.tdb with entries for more than
15.000 users. With a default number of hash chains of 131 on that tdb you can
imagine that the lists get large.

Not merging to 4, I don't get tdbbackup to compile there right now.

What about changing the global default hash chain number to be dramatically
larger? Disk is cheap these days.

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19685 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoset_share_security does not need a mem_ctx passed
vlendec [Sat, 11 Nov 2006 18:07:51 +0000 (18:07 +0000)]
set_share_security does not need a mem_ctx passed

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19669 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoConvert the locking params to use struct share_param instead of snum
vlendec [Sat, 11 Nov 2006 17:05:11 +0000 (17:05 +0000)]
Convert the locking params to use struct share_param instead of snum

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19668 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix incorrect null check
vlendec [Sat, 11 Nov 2006 17:04:08 +0000 (17:04 +0000)]
Fix incorrect null check

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19667 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoTalloc_guide text on multithreading by Remi Turboult
vlendec [Sat, 11 Nov 2006 17:02:08 +0000 (17:02 +0000)]
Talloc_guide text on multithreading by Remi Turboult

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19666 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix a memleak
vlendec [Sat, 11 Nov 2006 16:50:38 +0000 (16:50 +0000)]
Fix a memleak

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19665 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix bug #4187. Possible crash in signing on/off code.
jra [Sat, 11 Nov 2006 00:23:44 +0000 (00:23 +0000)]
Fix bug #4187. Possible crash in signing on/off code.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19659 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoCorrectly check for malloc failure
vlendec [Fri, 10 Nov 2006 15:56:20 +0000 (15:56 +0000)]
Correctly check for malloc failure

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19657 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoCorrectly check for malloc failure
vlendec [Fri, 10 Nov 2006 15:55:06 +0000 (15:55 +0000)]
Correctly check for malloc failure

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19656 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoJeremy, please review:
jmcd [Fri, 10 Nov 2006 15:43:29 +0000 (15:43 +0000)]
Jeremy, please review:

I updated the vfs version in 3.0.24 from 16 to 17, beacuse 16 was the
latest released code, but on SAMBA_3_0, I reverted my earlier change
back from 19 to 18, because we've not had any released code with 18.

This is related to the kernel_flock call addition.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19655 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoTrying to track down which caller tries to store a 0 length domain name
gd [Fri, 10 Nov 2006 13:46:19 +0000 (13:46 +0000)]
Trying to track down which caller tries to store a 0 length domain name
in the affinity cache (which happens all the time here).

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19652 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix interesting bug with the automatic site coverage in Active Directory:
gd [Fri, 10 Nov 2006 12:42:50 +0000 (12:42 +0000)]
Fix interesting bug with the automatic site coverage in Active Directory:

When having DC-less sites, AD assigns DCs from other sites to that site
that does not have it's own DC. The most reliable way for us to identify
the nearest DC - in that and all other cases - is the closest_dc flag in
the CLDAP reply.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19651 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agowhoops, forgot to increment the vfs version number with the added flock
jmcd [Thu, 9 Nov 2006 21:40:40 +0000 (21:40 +0000)]
whoops, forgot to increment the vfs version number with the added flock
call.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19648 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAdd some GPFS support in a vfs mod. Also adds the kernel flock op to
jmcd [Thu, 9 Nov 2006 20:29:31 +0000 (20:29 +0000)]
Add some GPFS support in a vfs mod.  Also adds the kernel flock op to
the vfs layer, since gpfs supports it.  Thanks to Volker, Christian,
Mathias, Chetan, and Peter.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19647 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix memleak in the default_ou_string handling. Thanks to David Hu
gd [Thu, 9 Nov 2006 10:16:38 +0000 (10:16 +0000)]
Fix memleak in the default_ou_string handling. Thanks to David Hu
<david.hu@hp.com>. Fixes #4212.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19646 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix for bug #4211 - logic error in acl_group_override()
jra [Tue, 7 Nov 2006 18:35:41 +0000 (18:35 +0000)]
Fix for bug #4211 - logic error in acl_group_override()
function. Fix from Jim Wang of Wesoft.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19627 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoCoalesce usage of DUMP_CORE. Fix formatting on chdir error message
jpeach [Tue, 7 Nov 2006 17:18:00 +0000 (17:18 +0000)]
Coalesce usage of DUMP_CORE. Fix formatting on chdir error message
in core dump path.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19626 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix protection from invalid struct tm values.
jra [Tue, 7 Nov 2006 02:33:10 +0000 (02:33 +0000)]
Fix protection from invalid struct tm values.
Backport from Samba4.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19601 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoUse `import' and `include' in the IDL and regenerate.
jelmer [Mon, 6 Nov 2006 23:20:35 +0000 (23:20 +0000)]
Use `import' and `include' in the IDL and regenerate.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19591 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoBUG 4075: patch from Dmitry Butskoy <dmitry@butskoy.name>.
jerry [Mon, 6 Nov 2006 19:46:50 +0000 (19:46 +0000)]
BUG 4075: patch from Dmitry Butskoy <dmitry@butskoy.name>.
Allow smbd to use winbindd to lookup uids/gids outside the
idmap range if 'winbind trusted domains only = yes'

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19579 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix from Nils Nordman for bug #4085. Thanks !
jra [Mon, 6 Nov 2006 19:21:44 +0000 (19:21 +0000)]
Fix from Nils Nordman for bug #4085. Thanks !
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19577 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoCorrect trivial typo.
jpeach [Mon, 6 Nov 2006 18:39:48 +0000 (18:39 +0000)]
Correct trivial typo.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19576 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix names of known failing tests.
jelmer [Sat, 4 Nov 2006 13:28:19 +0000 (13:28 +0000)]
Fix names of known failing tests.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19552 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoRegenerate IDL.
jelmer [Fri, 3 Nov 2006 20:00:14 +0000 (20:00 +0000)]
Regenerate IDL.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19542 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAdd a suffix to the program name if this is a process with a
jra [Thu, 2 Nov 2006 09:37:52 +0000 (09:37 +0000)]
Add a suffix to the program name if this is a process with a
non-default configuration file name.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19533 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAdded showacls togle. Previously was vendor-specific code.
jra [Wed, 1 Nov 2006 17:18:08 +0000 (17:18 +0000)]
Added showacls togle. Previously was vendor-specific code.
Merging these in - should have been merged back before (will
be tidied up later).
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19529 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix container handling for "net ads user" and "net ads group" functions
gd [Wed, 1 Nov 2006 11:19:33 +0000 (11:19 +0000)]
Fix container handling for "net ads user" and "net ads group" functions
along with some memleaks.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19528 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix double free in "net ads group add".
gd [Wed, 1 Nov 2006 11:08:05 +0000 (11:08 +0000)]
Fix double free in "net ads group add".

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19527 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix minor memleak.
gd [Wed, 1 Nov 2006 11:04:28 +0000 (11:04 +0000)]
Fix minor memleak.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19526 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix the same error in "net ads group delete".
gd [Wed, 1 Nov 2006 10:59:28 +0000 (10:59 +0000)]
Fix the same error in "net ads group delete".

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19525 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoStop "net ads user delete" from doing funny things.
gd [Wed, 1 Nov 2006 10:38:54 +0000 (10:38 +0000)]
Stop "net ads user delete" from doing funny things.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19524 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix the DN, to make searches using the domain as base
idra [Tue, 31 Oct 2006 12:57:56 +0000 (12:57 +0000)]
Fix the DN, to make searches using the domain as base
the DN must be rid,domain and not domain,rid

Also use member and not memberOf for group members
following conventions.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19516 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoThought I already fixes the etags target. Ignore .svn
jerry [Wed, 25 Oct 2006 16:19:42 +0000 (16:19 +0000)]
Thought I already fixes the etags target.  Ignore .svn
and not CVS (since we don't use CVS anymore

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19497 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoWhen building with a static Heimdal, make sure not to link against
gd [Wed, 25 Oct 2006 12:50:10 +0000 (12:50 +0000)]
When building with a static Heimdal, make sure not to link against
-lgssapi_krb5. With that change I could sucessfully verify that Heimdal
support is still working nicely after the changes from jpeach.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19494 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoThere is no point in prompting for a user's password in "net ads" when
gd [Wed, 25 Oct 2006 12:10:48 +0000 (12:10 +0000)]
There is no point in prompting for a user's password in "net ads" when
we can't find a domain controller at all.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19493 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agobackport changes from samba4
idra [Wed, 25 Oct 2006 02:06:05 +0000 (02:06 +0000)]
backport changes from samba4

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19491 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix coverity # 313
vlendec [Tue, 24 Oct 2006 20:23:14 +0000 (20:23 +0000)]
Fix coverity # 313

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19487 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoProbably Coverity is wrong here, but this fixes their ID 317. Not sure whether
vlendec [Tue, 24 Oct 2006 20:20:39 +0000 (20:20 +0000)]
Probably Coverity is wrong here, but this fixes their ID 317. Not sure whether
to merge it to 4_0. I want it in 3_0 because it took a bit to persuade myself
that el can not be NULL here.

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19486 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix Coverity # 319
vlendec [Tue, 24 Oct 2006 20:15:13 +0000 (20:15 +0000)]
Fix Coverity # 319

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19485 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix Coverity #329
vlendec [Tue, 24 Oct 2006 20:12:38 +0000 (20:12 +0000)]
Fix Coverity #329

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19484 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoPatch from Huang Dejin Eugene <hdejin@yahoo.com>.
jpeach [Tue, 24 Oct 2006 03:23:19 +0000 (03:23 +0000)]
Patch from Huang Dejin Eugene <hdejin@yahoo.com>.

Add configure option --enable-fam so that FAM support can explicitly
be controlled at build time. Default behaviour is to autodetect.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19477 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAnother user of NetShareEnum
vlendec [Mon, 23 Oct 2006 20:13:53 +0000 (20:13 +0000)]
Another user of NetShareEnum

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19469 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix some potential NULL dereferences
vlendec [Mon, 23 Oct 2006 20:11:12 +0000 (20:11 +0000)]
Fix some potential NULL dereferences

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19468 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAnother cleanup of 18802. Referring to structures after the block has been
vlendec [Sun, 22 Oct 2006 10:30:46 +0000 (10:30 +0000)]
Another cleanup of 18802. Referring to structures after the block has been
left is not a good idea.

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19451 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix smbtree's use of netshareenum.
vlendec [Sun, 22 Oct 2006 10:01:55 +0000 (10:01 +0000)]
Fix smbtree's use of netshareenum.

Jelmer, how much of r18802 did you actually test??

Volker

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19450 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoConvert delete_share_security to struct share_params plus some cleanups
vlendec [Sat, 21 Oct 2006 17:00:47 +0000 (17:00 +0000)]
Convert delete_share_security to struct share_params plus some cleanups

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19448 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoDo not throw away information
vlendec [Sat, 21 Oct 2006 16:52:25 +0000 (16:52 +0000)]
Do not throw away information

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19447 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoComment can be NULL now
vlendec [Sat, 21 Oct 2006 16:46:30 +0000 (16:46 +0000)]
Comment can be NULL now

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19446 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAttempt to fix net rpc share
vlendec [Sat, 21 Oct 2006 16:27:38 +0000 (16:27 +0000)]
Attempt to fix net rpc share

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19445 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agomerge from samba4:
metze [Sat, 21 Oct 2006 11:50:52 +0000 (11:50 +0000)]
merge from samba4:

reset trap when we have removed the test specifc files already

metze

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19444 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agomerge recent talloc performance improvements from Samba4
tridge [Sat, 21 Oct 2006 00:23:27 +0000 (00:23 +0000)]
merge recent talloc performance improvements from Samba4

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19431 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agomerge recent ldb changes from Samba4. This includes memory leak fixes
tridge [Sat, 21 Oct 2006 00:10:19 +0000 (00:10 +0000)]
merge recent ldb changes from Samba4. This includes memory leak fixes
and significant speedups

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19430 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agomoved tdb/common/tdbutil.c into lib/util_tdb.c
tridge [Fri, 20 Oct 2006 23:46:59 +0000 (23:46 +0000)]
moved tdb/common/tdbutil.c into lib/util_tdb.c

see discussion on samba-technical

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19429 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agomerge nearly all the differences between Samba3 tdb and Samba4
tridge [Fri, 20 Oct 2006 09:55:47 +0000 (09:55 +0000)]
merge nearly all the differences between Samba3 tdb and Samba4
tdb. This includes:

 - the new tdb_lockall and tdb_lockall_read code, which will be needed
   for the ldb speedups

 - the tdb logging changes. This is an intermediate step to keep the
   differences between the two branches small. The plan is still to
   move to a tdb_init()/tdb_set_logging_function()/tdb_attach() style
   of open which will make things much cleaner.

 - the updated test suites and standalone tdb build code

 - use libreplace headers

There are still some small differences I haven't merged. I'll discuss
those on the list.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19426 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoProtect against username == NULL
jra [Fri, 20 Oct 2006 08:14:38 +0000 (08:14 +0000)]
Protect against username == NULL
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19424 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoDoh ! Put the krb5 user@realm code in the right place.
jra [Fri, 20 Oct 2006 07:44:09 +0000 (07:44 +0000)]
Doh ! Put the krb5 user@realm code in the right place.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19422 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoBUG 3868: Patch from Timur Bakeyev <timur@com.bat.ru> to prevent
jerry [Thu, 19 Oct 2006 22:48:03 +0000 (22:48 +0000)]
BUG 3868: Patch from Timur Bakeyev <timur@com.bat.ru> to prevent
--with-aio-support from trimping on the $LIBS variable

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19421 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoRemove strequal and use strcmp() instead. Meant to
jerry [Thu, 19 Oct 2006 22:41:11 +0000 (22:41 +0000)]
Remove strequal and use strcmp() instead.  Meant to
make the change before theprevious commit.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19420 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoBUG 4109: Patch from Timur Bakeyev. Fix bug causing smbd to turn off
jerry [Thu, 19 Oct 2006 22:34:58 +0000 (22:34 +0000)]
BUG 4109: Patch from Timur Bakeyev.  Fix bug causing smbd to turn off
winbindd and fail to disable the _NO_WINBIND environment.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19419 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoBUG 3856: patch from Timur Bakeyev <timur@com.bat.ru> to include setting the nss...
jerry [Thu, 19 Oct 2006 22:28:55 +0000 (22:28 +0000)]
BUG 3856: patch from Timur Bakeyev <timur@com.bat.ru> to include setting the nss soname version on FreeBSD

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19417 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix some c++ warnings.
gd [Thu, 19 Oct 2006 21:47:11 +0000 (21:47 +0000)]
Fix some c++ warnings.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19416 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agooh la la, always compile before commit, I'm very sorry.
gd [Thu, 19 Oct 2006 15:47:19 +0000 (15:47 +0000)]
oh la la, always compile before commit, I'm very sorry.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19415 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agogencache is getting really important now, make sure that lp_lockdir
gd [Thu, 19 Oct 2006 15:43:25 +0000 (15:43 +0000)]
gencache is getting really important now, make sure that lp_lockdir
always exists so that the gencache.tdb can get created there.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19414 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoNow we're calling init_dc_connection, this code
jra [Thu, 19 Oct 2006 13:32:00 +0000 (13:32 +0000)]
Now we're calling init_dc_connection, this code
is completely useless (and in fact harmful :-) in
that it causes a winbindd error where there should
be none.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19413 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoNow Guenther discovered one crash dereferencing domain->backends,
jra [Wed, 18 Oct 2006 21:24:20 +0000 (21:24 +0000)]
Now Guenther discovered one crash dereferencing domain->backends,
get paranoid. I don't think this can really happen, but let's be
sure.
Jeremy.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19399 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoWhen we fail to get the list of trusted domains, make sure to return
gd [Wed, 18 Oct 2006 16:09:42 +0000 (16:09 +0000)]
When we fail to get the list of trusted domains, make sure to return
WINBINDD_ERROR.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19394 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoFix crash bug within the winbind caching method.
gd [Wed, 18 Oct 2006 14:22:08 +0000 (14:22 +0000)]
Fix crash bug within the winbind caching method.

That one was hard to find: when coming from offline mode and switching
to online, a refresh sequence number call (using the default MS-RPC
mechanism) may reset domain->backend to NULL (by the set_domain_online
event). We need to make sure to reidentify the remote domain in that
case.

Guenther

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19391 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoAdd some tests that are known failing against samba3.
jelmer [Wed, 18 Oct 2006 12:23:58 +0000 (12:23 +0000)]
Add some tests that are known failing against samba3.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19390 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoLimit the size of the connection bitmap to <64K entries.
jpeach [Wed, 18 Oct 2006 03:34:31 +0000 (03:34 +0000)]
Limit the size of the connection bitmap to <64K entries.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19386 0c0555d6-39d7-0310-84fc-f1cc0bd64818

17 years agoThese replaced symbols should have a rep_ prefix.
jpeach [Wed, 18 Oct 2006 03:26:58 +0000 (03:26 +0000)]
These replaced symbols should have a rep_ prefix.

git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0@19385 0c0555d6-39d7-0310-84fc-f1cc0bd64818