obnox/wireshark/wip.git
15 years agoPowervalue is in units of 100mW, print effective value and unit
jmayer [Tue, 9 Jun 2009 16:51:04 +0000 (16:51 +0000)]
Powervalue is in units of 100mW, print effective value and unit

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28674 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoEnable Lua tcp tap userdata.
stig [Tue, 9 Jun 2009 14:51:00 +0000 (14:51 +0000)]
Enable Lua tcp tap userdata.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28673 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRFC3576 states, that some messages will use port 3799 instead
jmayer [Tue, 9 Jun 2009 10:52:28 +0000 (10:52 +0000)]
RFC3576 states, that some messages will use port 3799 instead
of the "standard" radius ports. Register radius to that port
as well.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28672 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate the services file from IANA's port-numbers.
stig [Tue, 9 Jun 2009 07:39:58 +0000 (07:39 +0000)]
Update the services file from IANA's port-numbers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28671 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoReverted part of SVN 27411. The "home" and "end" key bindings overruled
sake [Tue, 9 Jun 2009 06:23:37 +0000 (06:23 +0000)]
Reverted part of SVN 27411. The "home" and "end" key bindings overruled
the use of these keys while editing a filter in the filter toolbar.
The keys "ctrl-home" and "ctrl-end" already provide the functionality to
go to the first or last packet in the packet-list. I added these as
accelerator keys and updated the users guide accordingly.

Of course we can also make "home" and "end" work, without breaking
functionality in the filter toolbar, but that takes a little more
work (at least for me... maybe not after going to Steve's session
at Sharkfest :-)).

(will add this to inclusion list for 1.0.9 and 1.2.0)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28670 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFixed some indents.
stig [Mon, 8 Jun 2009 19:59:31 +0000 (19:59 +0000)]
Fixed some indents.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28669 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded a missing check for expired TreeItem.
stig [Mon, 8 Jun 2009 19:45:53 +0000 (19:45 +0000)]
Added a missing check for expired TreeItem.
Fixed some indents.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28668 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMove init.lua from MAINTAINERCLEANFILES to DISTCLEANFILES.
gerald [Mon, 8 Jun 2009 19:02:49 +0000 (19:02 +0000)]
Move init.lua from MAINTAINERCLEANFILES to DISTCLEANFILES.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28666 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCheck for libpcap 1.0's broken pcap-config, which put a space between -L
guy [Mon, 8 Jun 2009 17:23:00 +0000 (17:23 +0000)]
Check for libpcap 1.0's broken pcap-config, which put a space between -L
and its argument - that doesn't work on some platforms (e.g., OS X).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28664 f5534014-38df-0310-8fa8-9805f1628bb7

15 years ago(Trivial) Remove an obsolete comment related to GTK 1
wmeier [Mon, 8 Jun 2009 12:49:05 +0000 (12:49 +0000)]
(Trivial) Remove an obsolete comment related to GTK 1

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28661 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMove declaration of yymx.
stig [Mon, 8 Jun 2009 11:54:38 +0000 (11:54 +0000)]
Move declaration of yymx.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28660 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRemove resetting useCnt in errsym, as it seems to disable some error checking
stig [Mon, 8 Jun 2009 10:03:41 +0000 (10:03 +0000)]
Remove resetting useCnt in errsym, as it seems to disable some error checking
we need to validate the filter syntax.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28659 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFixed check for no_of_bits in tvb_get_bits16(), tvb_get_bits32() and
stig [Mon, 8 Jun 2009 08:28:42 +0000 (08:28 +0000)]
Fixed check for no_of_bits in tvb_get_bits16(), tvb_get_bits32() and
tvb_get_bits64().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28658 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAllocate correct lengths for int64 and uint64.
stig [Mon, 8 Jun 2009 08:15:29 +0000 (08:15 +0000)]
Allocate correct lengths for int64 and uint64.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28657 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Sam Roberts:
stig [Mon, 8 Jun 2009 08:14:36 +0000 (08:14 +0000)]
From Sam Roberts:
Added TvbRange:range()

From me:
Added TvbRange:bitfield()
Fixed some indents.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28656 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoChanged g_strdup_printf -> ep_strdup_printf.
stig [Mon, 8 Jun 2009 08:02:15 +0000 (08:02 +0000)]
Changed g_strdup_printf -> ep_strdup_printf.
Use correct modifier for converting gint64 and guint64 to string.
Added __gc for Int64 and UInt64.
Fixed some indents.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28655 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCheck for a pcap-config script (as provided by libpcap 1.x) and, if we
guy [Mon, 8 Jun 2009 02:12:23 +0000 (02:12 +0000)]
Check for a pcap-config script (as provided by libpcap 1.x) and, if we
find it, use it to determine where to find libpcap and what additional
libraries it requires.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28653 f5534014-38df-0310-8fa8-9805f1628bb7

15 years ago[Automatic manuf and enterprise-numbers update for 2009-06-07]
gerald [Sun, 7 Jun 2009 15:03:32 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-06-07]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28651 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCheck for leftover bytes following Status PDU.
martinm [Sun, 7 Jun 2009 13:35:17 +0000 (13:35 +0000)]
Check for leftover bytes following Status PDU.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28650 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd time stamp to the list.
etxrab [Sat, 6 Jun 2009 17:08:01 +0000 (17:08 +0000)]
Add time stamp to the list.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28649 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoHandle Detach and Service request, make it possible to set direction on link(UL/DL).
etxrab [Sat, 6 Jun 2009 17:03:34 +0000 (17:03 +0000)]
Handle Detach and Service request, make it possible to set direction on link(UL/DL).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28648 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoGive a routine a name that indicates in more detail exactly what the
guy [Sat, 6 Jun 2009 00:21:40 +0000 (00:21 +0000)]
Give a routine a name that indicates in more detail exactly what the
routine does (it doesn't get arbitrary text, it gets a filter that
matches patches with a particular value of a particular column).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28647 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoClean up white space.
guy [Sat, 6 Jun 2009 00:12:43 +0000 (00:12 +0000)]
Clean up white space.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28646 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoHave tap listeners specify whether the "packet" routine requires
guy [Fri, 5 Jun 2009 22:42:47 +0000 (22:42 +0000)]
Have tap listeners specify whether the "packet" routine requires

a protocol tree;

the column values.

This includes stats-tree listeners.

Have the routines to build the packet list, and to retap packets, honor
those requirements.  This means that cf_retap_packets() no longer needs
an argument to specify whether to construct the column values or not, so
get rid of that argument.

This also means that there's no need for a tap to have a fake filter
to ensure that the protocol tree will be built, so don't set up a fake
"frame" filter.

While we're at it, clean up some cases where "no filter" was represented
as a null string rather than a null pointer.

Have a routine to return an indication of the number of tap listeners
with filters; use that rather than the global num_tap_filters.

Clean up some indentation and some gboolean vs. gint items.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28645 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAnd again.
guy [Fri, 5 Jun 2009 19:12:30 +0000 (19:12 +0000)]
And again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28644 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUse time_stat_init() to initialize the statistics for procedures.
guy [Fri, 5 Jun 2009 19:04:05 +0000 (19:04 +0000)]
Use time_stat_init() to initialize the statistics for procedures.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28643 f5534014-38df-0310-8fa8-9805f1628bb7

15 years ago* Fix name of Irene in AUTHORS.
tuexen [Fri, 5 Jun 2009 13:33:18 +0000 (13:33 +0000)]
* Fix name of Irene in AUTHORS.
* Add Varun Notibala to AUTHORS.
* Add support for NR-SACK and fix stability problems.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28642 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMicrosoft PKCS#12 local machine keyset bag attribute
gal [Fri, 5 Jun 2009 12:04:24 +0000 (12:04 +0000)]
Microsoft PKCS#12 local machine keyset bag attribute

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28641 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jakub Zawadzki:
jake [Thu, 4 Jun 2009 17:37:48 +0000 (17:37 +0000)]
From Jakub Zawadzki:
Fix edonkey dissector a little, by using gint type for tvb_length_remaining() result.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28640 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoShow total number of frames, UEs in stats window title.
martinm [Thu, 4 Jun 2009 15:10:28 +0000 (15:10 +0000)]
Show total number of frames, UEs in stats window title.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28639 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix typos, and make filter strings more consistent.
martinm [Thu, 4 Jun 2009 15:08:56 +0000 (15:08 +0000)]
Fix typos, and make filter strings more consistent.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28638 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoChanged expert infos from PI_DEBUG to PI_UNDECODED for Lua errors.
stig [Thu, 4 Jun 2009 14:23:30 +0000 (14:23 +0000)]
Changed expert infos from PI_DEBUG to PI_UNDECODED for Lua errors.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28637 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded missing PI_DEBUG to expert_group_vals[].
stig [Thu, 4 Jun 2009 14:22:16 +0000 (14:22 +0000)]
Added missing PI_DEBUG to expert_group_vals[].

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28636 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix Windows build warning:
wmeier [Thu, 4 Jun 2009 12:27:09 +0000 (12:27 +0000)]
Fix Windows build warning:
cl : Command line warning D9024 : unrecognized source file type 'ascend-grammar.h', object file assumed
cl : Command line warning D9027 : source file 'ascend-grammar.h' ignored

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28635 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoA segmented DATA SPDU sequence of length one has user information.
gal [Thu, 4 Jun 2009 08:30:03 +0000 (08:30 +0000)]
A segmented DATA SPDU sequence of length one has user information.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28634 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Sam Roberts:
stig [Thu, 4 Jun 2009 08:21:51 +0000 (08:21 +0000)]
From Sam Roberts:
The value_string_from_table()'s use of the lua stack is not balanced,
if a table is iterated, it pops one more time than it should.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28633 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTo quote the Wikipedia entry for the University of Duisburg-Essen, "In
guy [Wed, 3 Jun 2009 22:58:07 +0000 (22:58 +0000)]
To quote the Wikipedia entry for the University of Duisburg-Essen, "In
2003 the Gerhard-Mercator-University and the University of Essen merged
to the University of Duisburg-Essen.", so the two entries for Thomas
Dreibholz are probably for the same person; merge them.

teluna.org is the site for a Joost Damad and an Isabelle Marien, and
following the links to his blog indicates that he's a Debian user and at
least uses openMSX.  A search for Joost Yervante Damad also finds a
recommendation to accept a Joost Yervante Damad as a Debian developer;
he says he maintains openMSX and is "a software developer and integrator
for a large multinational".  My guess is that said large multinational
is Siemens, so I'm assuming the two Joost Yervante Damad entries are for
the same person.

That leaves the two Thomas Palmers; they might be the same person, but
it's conceivable that they're not, so I'll do a bit more digging before
combining those entries.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28632 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoEliminate some duplicate entries. If the e-mail addresses are the same,
guy [Wed, 3 Jun 2009 22:13:53 +0000 (22:13 +0000)]
Eliminate some duplicate entries.  If the e-mail addresses are the same,
it's an obvious duplicate; if the addresses are in the same domain, it's
almost certainly a duplicate; if the addresses are in different domains,
but one company bought some of the product line for another company, we
assume it's a duplicate (e.g., we presume Martijn Schipper moved from
Intersil to GlobespanVirata when Intersil sold the PRISM 802.11 chipset
lines to GlobespanVirata, although he now appears to be at Magna Carta).

This still leaves Joost Yervante Damad, Thomas Dreibholz, and Thomas
Palmer as duplicates - probably the same people, but I'll ask The Great
Gazoogle a few questions first.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28631 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoMerge another author entry.
jake [Wed, 3 Jun 2009 20:46:15 +0000 (20:46 +0000)]
Merge another author entry.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28630 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUnit is now ms.
etxrab [Wed, 3 Jun 2009 19:17:35 +0000 (19:17 +0000)]
Unit is now ms.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28629 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRemove duplicate CAPWAP dissector author.
jake [Wed, 3 Jun 2009 19:03:56 +0000 (19:03 +0000)]
Remove duplicate CAPWAP dissector author.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28628 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCorrect error dialog with correct tap name.
jake [Wed, 3 Jun 2009 18:54:48 +0000 (18:54 +0000)]
Correct error dialog with correct tap name.
Cleanup source code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28627 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdd CAPWAP dissector author.
jake [Wed, 3 Jun 2009 18:41:40 +0000 (18:41 +0000)]
Add CAPWAP dissector author.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28626 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDon't reuse lua_dir in a for loop.
stig [Wed, 3 Jun 2009 15:40:12 +0000 (15:40 +0000)]
Don't reuse lua_dir in a for loop.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28625 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFixed setting of LUA_INCLUDES when having extraneous lua heder directory.
stig [Wed, 3 Jun 2009 15:28:30 +0000 (15:28 +0000)]
Fixed setting of LUA_INCLUDES when having extraneous lua heder directory.
Fixed resetting flags after negative check for Lua.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28624 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoOnly give a failure message if configuring with --with-lua=yes.
stig [Wed, 3 Jun 2009 13:45:48 +0000 (13:45 +0000)]
Only give a failure message if configuring with --with-lua=yes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28623 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded check for extraneous lua header directories, as some systems
stig [Wed, 3 Jun 2009 13:21:48 +0000 (13:21 +0000)]
Added check for extraneous lua header directories, as some systems
apparently put the headers in a "lua5.1" subdirectory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28622 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUse liblua by default, if available.
stig [Wed, 3 Jun 2009 12:13:07 +0000 (12:13 +0000)]
Use liblua by default, if available.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28621 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFixed bit position for wlan_mgt.fixed.delba.param.initiator.
stig [Wed, 3 Jun 2009 10:38:07 +0000 (10:38 +0000)]
Fixed bit position for wlan_mgt.fixed.delba.param.initiator.

This fixes bug 3505.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28620 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded a preference to define more udp ports to use for TFTP.
stig [Wed, 3 Jun 2009 09:57:22 +0000 (09:57 +0000)]
Added a preference to define more udp ports to use for TFTP.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28619 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix pod errors in man pods.
rbalint [Wed, 3 Jun 2009 06:38:21 +0000 (06:38 +0000)]
Fix pod errors in man pods.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28618 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoIf no valid packages was found in the input file we write an empty
stig [Tue, 2 Jun 2009 23:14:19 +0000 (23:14 +0000)]
If no valid packages was found in the input file we write an empty
header in the output file.  This way we at least create a file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28617 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoEscape ? in echo text the Windows way ....
wmeier [Tue, 2 Jun 2009 22:02:13 +0000 (22:02 +0000)]
Escape ? in echo text the Windows way ....

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28616 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRemove the module globals.
jake [Tue, 2 Jun 2009 21:44:00 +0000 (21:44 +0000)]
Remove the module globals.
Clean up the source code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28615 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoOptimized check if file is a nstrace file.
stig [Tue, 2 Jun 2009 20:59:48 +0000 (20:59 +0000)]
Optimized check if file is a nstrace file.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28614 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix some small memory leaks.
wmeier [Tue, 2 Jun 2009 20:57:57 +0000 (20:57 +0000)]
Fix some small memory leaks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28613 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix a small memory leak
wmeier [Tue, 2 Jun 2009 20:16:23 +0000 (20:16 +0000)]
Fix a small memory leak

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28612 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix "tap-rtp-common.c:440: warning: ‘current_diff’ may be used uninitialized...
etxrab [Tue, 2 Jun 2009 20:01:01 +0000 (20:01 +0000)]
Fix "tap-rtp-common.c:440: warning: Ã¢â‚¬Ëœcurrent_diff’ may be used uninitialized in this function"

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28611 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDo find_dissector_handles once-only in proto_reg_handoff...
wmeier [Tue, 2 Jun 2009 19:41:35 +0000 (19:41 +0000)]
Do find_dissector_handles once-only in proto_reg_handoff...
lenght ==> length in a few places;

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28610 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFixed the type for key_len in dissect_key().
stig [Tue, 2 Jun 2009 19:35:45 +0000 (19:35 +0000)]
Fixed the type for key_len in dissect_key().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28609 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoio_stat save & filewall rule save: rework "save dialog" slightly:
wmeier [Tue, 2 Jun 2009 19:16:08 +0000 (19:16 +0000)]
io_stat save & filewall rule save: rework "save dialog" slightly:
     - Prevent "dead" save-as window if error opening/writing file
        or if a directory is entered as the filename;
        Work-around is to always kill save-as window whether success
         or an error causing alert-box popup;
     - Enable "check for file overwrite" (if GTK 2.8 or greater);
     - Fix some memory leaks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28608 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoWhen doing a seek-and-read, don't check the packet size, as we don't
guy [Tue, 2 Jun 2009 19:06:05 +0000 (19:06 +0000)]
When doing a seek-and-read, don't check the packet size, as we don't
have it (we have the size with the pseudo-header length already
removed); we've already read the packet, and thus have already checked
it.  Fixes bug 3501.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28607 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCalculate skew and clock drift, make it possible to copy the label.
etxrab [Tue, 2 Jun 2009 19:05:20 +0000 (19:05 +0000)]
Calculate skew and clock drift, make it possible to copy the label.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28606 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Graham Bloice via bug 3504:
stig [Tue, 2 Jun 2009 18:47:36 +0000 (18:47 +0000)]
From Graham Bloice via bug 3504:
Fix concurrent name resolution for c-ares.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28605 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agopacket_hip: (Minor): Remove unused data_handle; move proto_register... to just before...
wmeier [Tue, 2 Jun 2009 18:47:20 +0000 (18:47 +0000)]
packet_hip: (Minor): Remove unused data_handle; move proto_register... to just before proto_reg-handoff...

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28604 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Alexis La Goutte via bug 3488:
stig [Tue, 2 Jun 2009 18:39:38 +0000 (18:39 +0000)]
From Alexis La Goutte via bug 3488:
Add support for decoding CAPWAP Control Packet (RFC5415)

From me:
Adjusted some names.
Some space cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28603 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoOnly call wtap_dump_close() if we have an open file.
stig [Tue, 2 Jun 2009 17:22:40 +0000 (17:22 +0000)]
Only call wtap_dump_close() if we have an open file.

We can have a situation where a file only contains a valid file header
without any packages, so this will avoid a crash.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28602 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRewrote to add IPv6 addresses correctly and rewrote some proto_item_add_bytes()
stig [Tue, 2 Jun 2009 15:46:55 +0000 (15:46 +0000)]
Rewrote to add IPv6 addresses correctly and rewrote some proto_item_add_bytes()
to avoid using tvb_get_ptr().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28601 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofollow_stream: Enable "check for file overwrite" (if GTK 2.8 or greater);
wmeier [Tue, 2 Jun 2009 15:39:20 +0000 (15:39 +0000)]
follow_stream: Enable "check for file overwrite" (if GTK 2.8 or greater);

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28600 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoDecode SCCP cause values in SUA (using value_strings exported from the SCCP
morriss [Tue, 2 Jun 2009 15:34:17 +0000 (15:34 +0000)]
Decode SCCP cause values in SUA (using value_strings exported from the SCCP
dissector).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28599 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRemoved a unused preference setting, some unused includes and
stig [Tue, 2 Jun 2009 15:22:33 +0000 (15:22 +0000)]
Removed a unused preference setting, some unused includes and
some unused code.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28598 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agortp_stream_dlg: rework dtp_stream "save as" slightly:
wmeier [Tue, 2 Jun 2009 15:17:35 +0000 (15:17 +0000)]
rtp_stream_dlg: rework dtp_stream "save as" slightly:
    - Prevent "dead" save-as window if error opening/writing file
       or if a directory is entered as the filename;
       Work-around is to always kill save-as window whether success
        or an error causing alert-box popup;
    - Enable "check for file overwrite" (if GTK 2.8 or greater);
    - Fix some memory leaks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28597 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Samu Varjonen via bug 3378:
stig [Tue, 2 Jun 2009 15:10:04 +0000 (15:10 +0000)]
From Samu Varjonen via bug 3378:
Added support for Host Identity Protocol (HIP).

From me:
- Adjusted location of "Checksum" and "HIP Controls", as they seems to have
  switched place in the bytes window
- Rewrote some proto_tree_add_uint -> proto_tree_add_item (some still remain)
- Rewrote to not use tvb_memcpy()
- Corrected some proto_tree_add_item's as the format seems to be big-endian
- Terminate ALL value_string's with { 0, NULL }
- No need to zero-terminate value_string strings.
- Removed call to check_col()
- Removed some prototypes
- Removed unused hf_hip_tlv_id, hf_hip_res and hf_hip_tlv_enc_iv (please check)
- Rewrote some C++ comments

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28596 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoBetter heuristics for detecting BER encoded file, especially when initial tag is...
gal [Tue, 2 Jun 2009 14:36:42 +0000 (14:36 +0000)]
Better heuristics for detecting BER encoded file, especially when initial tag is indefinite length encoded.
Checked that the I4B traces reported in http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1972 still loads as expected.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28595 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate to install latest WinPcap and silently install/uninstall the Visual C++ 2008...
gal [Tue, 2 Jun 2009 11:56:28 +0000 (11:56 +0000)]
Update to install latest WinPcap and silently install/uninstall the Visual C++ 2008 Redistributable.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28594 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUpdate to:
gal [Tue, 2 Jun 2009 11:04:14 +0000 (11:04 +0000)]
Update to:
* support the P3 protocol in addition to the P1 protocol; and
* reduce the number of changes to the ASN.1 modules (as asn2wrs now handles more of the ASN.1 constructs).
P3 is currently only supported over ROS (and not RTSE)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28593 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Jim Young (bug 2504):
stig [Tue, 2 Jun 2009 10:40:58 +0000 (10:40 +0000)]
From Jim Young (bug 2504):
Quick fix to sync expert_tapdata_s.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28592 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSmall typo.
gal [Tue, 2 Jun 2009 09:50:09 +0000 (09:50 +0000)]
Small typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28591 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoSupport for the Entrust VersionInfo certificate extension
gal [Tue, 2 Jun 2009 09:46:03 +0000 (09:46 +0000)]
Support for the Entrust VersionInfo certificate extension

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28590 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRestore the generation and display of LDAP DNs from RDN components
gal [Tue, 2 Jun 2009 09:44:52 +0000 (09:44 +0000)]
Restore the generation and display of LDAP DNs from RDN components

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28589 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCorrected nspm_signature_version() again.
stig [Tue, 2 Jun 2009 09:23:48 +0000 (09:23 +0000)]
Corrected nspm_signature_version() again.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28588 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoCorrect LDAP certificate attribute name
gal [Tue, 2 Jun 2009 09:20:10 +0000 (09:20 +0000)]
Correct LDAP certificate attribute name

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28587 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded support for the UserNotice certificate extension.
gal [Tue, 2 Jun 2009 09:17:16 +0000 (09:17 +0000)]
Added support for the UserNotice certificate extension.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28586 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAvoid infinite loop in nspm_signature_version().
stig [Tue, 2 Jun 2009 08:47:45 +0000 (08:47 +0000)]
Avoid infinite loop in nspm_signature_version().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28585 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoNo newlines in the additional-error-information string, please.
guy [Tue, 2 Jun 2009 07:18:18 +0000 (07:18 +0000)]
No newlines in the additional-error-information string, please.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28584 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFrom Matt Deckard:
jake [Tue, 2 Jun 2009 06:37:21 +0000 (06:37 +0000)]
From Matt Deckard:
Add support for the DIS protocol dissector to more fully interpret the PDU
types "Data Query", "Data", and "Set Data". It should interpret the
originating and receiving entity IDs, request ID, number of fixed and variable
datum fields, and the ID and values of each datum field in the PDU.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28583 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoUnescape telnet suboption data if needed.
rbalint [Tue, 2 Jun 2009 00:04:55 +0000 (00:04 +0000)]
Unescape telnet suboption data if needed.
This fixes bug 191.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28582 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRevert 28580.
rbalint [Mon, 1 Jun 2009 22:41:48 +0000 (22:41 +0000)]
Revert 28580.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28581 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix dissection of telnet window size suboption.
rbalint [Mon, 1 Jun 2009 22:27:00 +0000 (22:27 +0000)]
Fix dissection of telnet window size suboption.
This fixes bug 191.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28580 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoTry Jakub's casting with GPOINTER_TO_INT().
stig [Mon, 1 Jun 2009 21:47:45 +0000 (21:47 +0000)]
Try Jakub's casting with GPOINTER_TO_INT().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28579 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdding casts, take 3.
stig [Mon, 1 Jun 2009 21:26:50 +0000 (21:26 +0000)]
Adding casts, take 3.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28578 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoproto_main_draw: rework packet bytes "save as" slightly:
wmeier [Mon, 1 Jun 2009 20:52:53 +0000 (20:52 +0000)]
proto_main_draw:  rework packet bytes "save as" slightly:
   - Prevent "dead" save-as window if error opening/writing file
      or if a directory is entered as the filename;
      Work-around is to always kill save-as window whether success
       or an error causing alert-box popup;
   - Enable "check for file overwrite" (if GTK 2.8 or greater);
   - Fix some memory leaks.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28577 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdding casts, take 2.
stig [Mon, 1 Jun 2009 19:55:57 +0000 (19:55 +0000)]
Adding casts, take 2.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28576 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded/Changed some more casts to build.
stig [Mon, 1 Jun 2009 19:46:40 +0000 (19:46 +0000)]
Added/Changed some more casts to build.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28575 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agofollow_stream: rework "save as" slightly:
wmeier [Mon, 1 Jun 2009 19:43:58 +0000 (19:43 +0000)]
follow_stream: rework "save as" slightly:
  - Prevent "dead" save-as window if unable to open file for write
     or if a directory is entered as the filename;
     Work-around is to always kill save-as window whether success
      or an error causing alert-box popup;
  - Fix a memory leak.
  - Define certain functions used only in follow_stream.c as static;
    (Remove declarations for them from follow_stream.h)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28574 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded some casts to remove some warnings.
stig [Mon, 1 Jun 2009 18:50:16 +0000 (18:50 +0000)]
Added some casts to remove some warnings.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28573 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRemoved _U_ for an used argument.
stig [Mon, 1 Jun 2009 18:24:42 +0000 (18:24 +0000)]
Removed _U_ for an used argument.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28572 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoRemoved some unused hf_ entries.
stig [Mon, 1 Jun 2009 18:17:52 +0000 (18:17 +0000)]
Removed some unused hf_ entries.
Renamed filter abbrev from ns. to nstrace.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28571 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoAdded the wspython Makefile.nmake from bug 3500 to satisfy the
stig [Mon, 1 Jun 2009 18:09:07 +0000 (18:09 +0000)]
Added the wspython Makefile.nmake from bug 3500 to satisfy the
Ubuntu buildbot.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28570 f5534014-38df-0310-8fa8-9805f1628bb7

15 years agoFix a printf to make the label correct.
stig [Mon, 1 Jun 2009 17:52:14 +0000 (17:52 +0000)]
Fix a printf to make the label correct.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28569 f5534014-38df-0310-8fa8-9805f1628bb7