Stefan Metzmacher [Mon, 19 Nov 2012 05:59:33 +0000 (06:59 +0100)]
s4:dsdb/extended_dn_in: do helper searches AS_SYSTEM and with SHOW_RECYCLED
Note that SHOW_RECYCLED implies SHOW_DELETED.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Mon, 19 Nov 2012 05:59:33 +0000 (06:59 +0100)]
s4:dsdb/objectclass: do helper searches AS_SYSTEM and with SHOW_RECYCLED
Note that SHOW_RECYCLED implies SHOW_DELETED.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Mon, 12 Nov 2012 13:19:34 +0000 (14:19 +0100)]
s4:dsdb/rootdse: do helper searches AS_SYSTEM
As anonymous users can read all rootdse attributes,
we should do helper searches with DSDB_FLAG_AS_SYSTEM
in order to avoid unnecessary access checks.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Mon, 26 Nov 2012 12:38:07 +0000 (13:38 +0100)]
s4:dsdb/rootdse: remove unused variable
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Michael Adam [Tue, 27 Nov 2012 15:43:25 +0000 (16:43 +0100)]
s4:tests/samba_tool/gpo.py: fix accidential line break
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Tue, 20 Nov 2012 14:02:05 +0000 (15:02 +0100)]
s4:tests/samba_tool/gpo.py: add test_show_as_admin()
This calls samba-tool gpo show as admin (which should be able to
see the full nTSecurityDescriptor.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Tue, 20 Nov 2012 13:58:13 +0000 (14:58 +0100)]
s4:netcmd/gpo.py: let get_gpo_info explicitly ask for the full ntSecurityDescriptor
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Tue, 20 Nov 2012 13:56:56 +0000 (14:56 +0100)]
s4:netcmd/gpo.py: only ask for OWNER/GROUP/DACL when validating the nTSecurityDescriptor
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Sat, 17 Nov 2012 06:13:40 +0000 (07:13 +0100)]
s4:netcmd/gpo.py: the nTSecurityDescriptor may not be visible for the current user
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Tue, 20 Nov 2012 13:51:46 +0000 (14:51 +0100)]
s4:netcmd/gpo.py: s/ntSecurityDescriptor/nTSecurityDescriptor
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Thu, 22 Nov 2012 07:59:40 +0000 (08:59 +0100)]
s4:dsdb/dirsync: explicitly ask for sdctr->secinfo_flags = 0xF
A value of 0 is mapped to 0xF.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 21 Nov 2012 08:51:45 +0000 (09:51 +0100)]
s4:dsdb/dirsync: use the correct nc_root to fetch replUpToDateVector
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Tue, 27 Nov 2012 13:49:11 +0000 (14:49 +0100)]
s4:dsdb/dirsync: check result of replUpToDateVector fetch on nc_root
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 21 Nov 2012 15:12:22 +0000 (16:12 +0100)]
s4:dsdb/schema_data: fix debug message in schema_data_modify()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 28 Nov 2012 20:55:47 +0000 (21:55 +0100)]
ldb: fix a typo in the comment for ldb_req_is_untrusted()
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Nov 30 15:44:46 CET 2012 on sn-devel-104
Michael Adam [Fri, 30 Nov 2012 11:31:55 +0000 (12:31 +0100)]
libnet: Fix a typo in dbsync error message.
Signed-off-by: Michael Adam <obnox@samba.org>
Andreas Schneider [Fri, 30 Nov 2012 10:01:47 +0000 (11:01 +0100)]
libnet: Fix copy and paste error in dbsync error message.
Andreas Schneider [Fri, 30 Nov 2012 09:59:06 +0000 (10:59 +0100)]
torture: Fix copy and paste error in debug message.
Found by Coverity.
Andreas Schneider [Fri, 30 Nov 2012 09:57:39 +0000 (10:57 +0100)]
torture: Fix copy and paste error.
Found by Coverity.
Andreas Schneider [Fri, 30 Nov 2012 09:53:55 +0000 (10:53 +0100)]
s3-reg: Fix copy and paste error in debug message.
Found by coverity.
Stefan Metzmacher [Fri, 30 Nov 2012 11:07:39 +0000 (12:07 +0100)]
s3:popt_common: Fix password processing.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Nov 30 14:01:08 CET 2012 on sn-devel-104
Stefan Metzmacher [Fri, 30 Nov 2012 08:31:34 +0000 (09:31 +0100)]
s3:util: fix usage of popt_burn_cmdline_password()
We should only call popt_burn_cmdline_password() after poptFreeContext(),
otherwise we remove the password to early.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Thu, 29 Nov 2012 13:31:19 +0000 (14:31 +0100)]
s3-winbind: use new reconnect logic in rpc_lookup_sids() also.
Volker, please check.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Thu, 29 Nov 2012 11:03:53 +0000 (12:03 +0100)]
s3-winbindd: rework reconnect logic in winbindd_lookup_names().
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Thu, 29 Nov 2012 11:03:16 +0000 (12:03 +0100)]
s3-winbindd: rework reconnect logic in winbindd_lookup_sids().
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Wed, 28 Nov 2012 19:41:21 +0000 (20:41 +0100)]
s3-winbindd: remove lookup_sids_fn_t.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Wed, 28 Nov 2012 16:03:40 +0000 (17:03 +0100)]
s3-winbindd: remove lookup_names_fn_t.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Wed, 28 Nov 2012 16:00:49 +0000 (17:00 +0100)]
s3-rpc_client: make dcerpc_lsa_lookup_names_generic() public.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Wed, 28 Nov 2012 15:57:57 +0000 (16:57 +0100)]
s3-rpc_cli: make dcerpc_lsa_lookup_sids_generic() public.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Wed, 28 Nov 2012 15:57:24 +0000 (16:57 +0100)]
s3-winbindd: add cm_connect_lsat().
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Wed, 28 Nov 2012 13:53:27 +0000 (14:53 +0100)]
s3-rpc_cli: Remove some unused wrapping code.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Volker Lendecke [Tue, 27 Nov 2012 22:58:09 +0000 (14:58 -0800)]
Fix Bug 9422 - large read requests cause server to issue malformed reply
Reviewed by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri Nov 30 03:27:07 CET 2012 on sn-devel-104
Volker Lendecke [Thu, 29 Nov 2012 15:45:15 +0000 (16:45 +0100)]
dbwrap: Do not rely on dbwrap_record_get_value to return a talloc object
db_tdb_fetch_locked returns the value as part of a larger talloc object
that also contains the key. This means we can not realloc, but have to
freshly alloc.
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Nov 29 20:21:51 CET 2012 on sn-devel-104
Volker Lendecke [Thu, 29 Nov 2012 14:04:33 +0000 (15:04 +0100)]
dbwrap: Remove an unnecessary if-statement
TALLOC_FREE can live with a NULL pointer
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 29 Nov 2012 14:03:20 +0000 (15:03 +0100)]
dbwrap: No need to NULL out a talloc_zero'ed structure element
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 29 Nov 2012 14:02:43 +0000 (15:02 +0100)]
dbwrap: Use talloc_zero in db_open_rbt
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 29 Nov 2012 14:02:15 +0000 (15:02 +0100)]
dbwrap: Use talloc_zero in db_open_cache
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Mon, 12 Nov 2012 12:42:23 +0000 (13:42 +0100)]
s3: Remove db_ctdb_fetch
Note that this also makes the request for read only copies
much more explicity visible in the code.
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Mon, 12 Nov 2012 12:36:48 +0000 (13:36 +0100)]
s3: Directly parse local existing records in db_ctdb_parse_record
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Mon, 12 Nov 2012 12:27:07 +0000 (13:27 +0100)]
s3: Factor out db_ctdb_can_use_local_hdr from db_ctdb_can_use_local_copy
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Mon, 12 Nov 2012 12:06:38 +0000 (13:06 +0100)]
s3: Remove unused code for fetching persistent ctdb records
The only entry point here is parse_record, and this catches the persistent
case with a direct parse now
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Mon, 12 Nov 2012 12:03:56 +0000 (13:03 +0100)]
s3: Avoid db_ctdb_fetch for persistent databases
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Mon, 12 Nov 2012 11:13:39 +0000 (12:13 +0100)]
s3: Factor out parse_newest_in_marshall_buffer from pull_newest_from_marshall_buffer
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Sat, 10 Nov 2012 14:03:35 +0000 (15:03 +0100)]
s3: reduce db_ctdb_marshall_loop_next to specialized db_ctdb_marshall_buf_parse
now that the db_ctdb_marshall_loop_next_key has been factored out.
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Sat, 10 Nov 2012 13:46:10 +0000 (14:46 +0100)]
s3: Factor out db_ctdb_marshall_loop_next_key from db_ctdb_marshall_loop_next
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Sat, 10 Nov 2012 13:42:21 +0000 (14:42 +0100)]
s3: Slightly simplify db_ctdb_marshall_loop_next
Both callers give a key argument
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 8 Nov 2012 11:00:11 +0000 (12:00 +0100)]
s3: Use db_ctdb_ltdb_parse in db_ctdb_fetch_db_seqnum_from_db
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 8 Nov 2012 10:52:43 +0000 (11:52 +0100)]
s3: Use db_ctdb_ltdb_parse in db_ctdb_ltdb_fetch
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 8 Nov 2012 10:37:30 +0000 (11:37 +0100)]
s3: Add db_ctdb_ltdb_parse
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Wed, 7 Nov 2012 15:39:16 +0000 (16:39 +0100)]
s3: Slightly simplify db_ctdb_transaction_commit
Avoid an unnecessary "else".
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Wed, 7 Nov 2012 15:25:31 +0000 (16:25 +0100)]
s3: Remove header==NULL code from db_ctdb_marshall_record
The only call chain (via db_ctdb_marshall_add) has header != NULL
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Wed, 7 Nov 2012 20:24:27 +0000 (21:24 +0100)]
s3: test dbwrap_ctdb
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 8 Nov 2012 13:15:25 +0000 (14:15 +0100)]
dbwrap: Use dbwrap_parse_record in dbwrap_fetch_uint32_bystring
Reviewed-by: Michael Adam <obnox@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:15:49 +0000 (10:15 +0100)]
docs: man oLschema2ldif: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Nov 29 15:27:45 CET 2012 on sn-devel-104
Karolin Seeger [Thu, 29 Nov 2012 09:15:07 +0000 (10:15 +0100)]
docs: man ntlm_auth4: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:14:15 +0000 (10:14 +0100)]
docs: man smbtorture: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:09:07 +0000 (10:09 +0100)]
docs: man masktest: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:04:43 +0000 (10:04 +0100)]
docs: man locktest: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:04:26 +0000 (10:04 +0100)]
docs: man gentest: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:03:52 +0000 (10:03 +0100)]
docs: man 8 samba: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:03:19 +0000 (10:03 +0100)]
docs: man regtree: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:02:51 +0000 (10:02 +0100)]
docs: man regshell: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:02:30 +0000 (10:02 +0100)]
docs: man regpatch: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:02:12 +0000 (10:02 +0100)]
docs: man regdiff: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:01:39 +0000 (10:01 +0100)]
docs: man ndrdump: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:01:06 +0000 (10:01 +0100)]
docs: man tdbtool: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:00:45 +0000 (10:00 +0100)]
docs: man talloc: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 09:00:10 +0000 (10:00 +0100)]
docs: man ldbsearch: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 08:59:52 +0000 (09:59 +0100)]
docs: man ldbrename: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 08:59:32 +0000 (09:59 +0100)]
docs: man ldbmodify: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 08:59:15 +0000 (09:59 +0100)]
docs: man ldbedit: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 08:58:52 +0000 (09:58 +0100)]
docs: man ldbdel: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 08:58:23 +0000 (09:58 +0100)]
docs: man ldbadd: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Karolin Seeger [Thu, 29 Nov 2012 08:56:25 +0000 (09:56 +0100)]
docs: man ldb.3: Add missing meta data.
This avoids warnings during the waf build and removes "FIXME" entries from the
manpage.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
David Disseldorp [Tue, 27 Nov 2012 13:39:41 +0000 (14:39 +0100)]
s3-printing: add missing carriage return to debug str
Reviewed-by: Andreas Schneider <asn@samba.org>
David Disseldorp [Thu, 29 Nov 2012 11:22:48 +0000 (12:22 +0100)]
rpcclient: fix usage docs for rpcclient adddriver
The printer driver name is incorrectly referred to as the printer name.
Reviewed-by: Andreas Schneider <asn@samba.org>
David Disseldorp [Thu, 29 Nov 2012 11:10:45 +0000 (12:10 +0100)]
selftest: configure printer with default devmode = no
This allows us to reproduce the segfault described in bug 9433.
Reviewed-by: Andreas Schneider <asn@samba.org>
David Disseldorp [Tue, 27 Nov 2012 15:10:28 +0000 (16:10 +0100)]
spoolss: fix segfault when "default devmode" is disabled
Currently when "default devmode" is explicitly disabled, and a printer
is added with a null device mode, spoolssd crashes in copy_devicemode().
Both construct_printer_info2() and construct_printer_info8() code paths
currently unconditionally attempt to copy a printers device mode,
without checking whether one is present.
This change fixes this regression such that construct_printer_info*()
functions check for a null device mode before copying.
https://bugzilla.samba.org/show_bug.cgi?id=9433
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Nov 29 13:03:05 CET 2012 on sn-devel-104
Karolin Seeger [Wed, 28 Nov 2012 11:46:31 +0000 (12:46 +0100)]
docs: Rename man ntlm_auth.
Rename man ntlm_auth to ntlm_auth4.
Karolin
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Nov 28 20:41:48 CET 2012 on sn-devel-104
Volker Lendecke [Tue, 27 Nov 2012 14:40:06 +0000 (15:40 +0100)]
s3: Use dbwrap_parse_record in fetch_share_mode_unlocked
Reviewed-by: Andreas Schneider <asn@samba.org>
Andreas Schneider [Wed, 28 Nov 2012 11:53:39 +0000 (12:53 +0100)]
BUG 9436: Fix leaking sockets of SMB connections to a DC.
As this is a burst of 3 unbound sockets with each try to reach a DC
we're running out of file descriptors pretty fast. So winbind is then
mostly spinning in an accept loop failing with EMFILE.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jim McDonough <jmcd@samba.org>
Autobuild-User(master): Jim McDonough <jmcd@samba.org>
Autobuild-Date(master): Wed Nov 28 17:17:21 CET 2012 on sn-devel-104
Stefan Metzmacher [Wed, 28 Nov 2012 10:44:58 +0000 (11:44 +0100)]
s3:vfs_gpfs: add no memory check in gpfs2smb_acl()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Nov 28 14:06:27 CET 2012 on sn-devel-104
Stefan Metzmacher [Wed, 28 Nov 2012 10:44:15 +0000 (11:44 +0100)]
s3:vfs_gpfs: make sure we return the correct errno in gpfs2smb_acl()
TALLOC_FREE() could overwrite errno.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 28 Nov 2012 10:38:13 +0000 (11:38 +0100)]
s4:smbd/open: add missing TALLOC_FREE(frame) to inherit_new_acl()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 28 Nov 2012 10:21:51 +0000 (11:21 +0100)]
s3:vfs_aixacl2: make use of vfs_aixacl_util.h
This should fix the build.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Tue, 20 Nov 2012 09:02:07 +0000 (10:02 +0100)]
s3: Open gencache_notrans with TDB_NOSYNC
We are doing CLEAR_IF_FIRST here, and we are doing the transactions only to
protect gencache_stabilize against concurrent writers. tdb's transaction.c
says:
- if TDB_NOSYNC is passed to flags in tdb_open then transactions are
still available, but no fsync/msync calls are made. This means we
are still proof against a process dying during transaction commit,
but not against machine reboot.
For gencache_notrans.tdb this is exactly what we want and avoids some expensive
disk syncs.
Reviewed by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Nov 28 03:13:56 CET 2012 on sn-devel-104
Volker Lendecke [Tue, 20 Nov 2012 08:50:57 +0000 (09:50 +0100)]
s3: Avoid some transaction_commit on gencache.tdb
Commits are expensive, and in some scenarios we are overwriting existing values
again and again.
Reviewed by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Tue, 27 Nov 2012 10:46:38 +0000 (11:46 +0100)]
docs: Add some binaries to the "SEE ALSO" section
of man smb.conf.
Karolin
Reviewed by: Jeremy Allison <jra@samba.org>
Karolin Seeger [Tue, 27 Nov 2012 10:29:26 +0000 (11:29 +0100)]
docs: Fix version in man smb.conf.
Karolin
Reviewed by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Sat, 24 Nov 2012 10:39:02 +0000 (11:39 +0100)]
s3: Fix bug 9428 -- inotify detection broken
Reviewed by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Nov 27 01:20:24 CET 2012 on sn-devel-104
Volker Lendecke [Sun, 25 Nov 2012 14:19:32 +0000 (14:19 +0000)]
s3: Do not free a string where we should not
Reviewed by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Nov 26 22:03:05 CET 2012 on sn-devel-104
Volker Lendecke [Sun, 25 Nov 2012 14:19:32 +0000 (14:19 +0000)]
s3: Do not free a string where we should not
Reviewed by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Sun, 25 Nov 2012 09:19:23 +0000 (10:19 +0100)]
s3: Fix Coverity ID 741407 -- resource leak
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Nov 26 19:20:05 CET 2012 on sn-devel-104
Günther Deschner [Fri, 23 Nov 2012 17:15:30 +0000 (18:15 +0100)]
s3-rpc_client: try to use socket_addr if available in rpc_pipe_open_tcp() (bug #9426)
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Mon Nov 26 17:36:20 CET 2012 on sn-devel-104
Stefan Metzmacher [Sat, 24 Nov 2012 10:28:57 +0000 (11:28 +0100)]
s4:torture/rpc/handles: try to make all assoc_group tests less flakey
Just incrementing the assoc_group_id makes it too likely to hit
a number that is already in use.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Nov 26 13:53:22 CET 2012 on sn-devel-104
Michael Adam [Fri, 23 Nov 2012 11:21:49 +0000 (12:21 +0100)]
configure(waf): Fail "configure --with-ads" if ads support is not available
Fix for bug #9350
This establishes the "auto" mode as default for ads-support, when
neither "--with-ads" nor "--without-ads" is specified for configure.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Björn Baumbach <bb@sernet.de>
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Fri Nov 23 19:34:55 CET 2012 on sn-devel-104
Günther Deschner [Fri, 23 Nov 2012 12:19:53 +0000 (13:19 +0100)]
s3-rpc_client: lookup nametype 0x20 in rpc_pipe_open_tcp_port(). (bug #9426)
The server name type (0x20) is much more likely to be available in the name cache, as
this type gets stored by winbind itself - the primary user of the ncacn_ip_tcp
code currently.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Nov 23 16:30:57 CET 2012 on sn-devel-104
Matthieu Patou [Wed, 21 Nov 2012 20:07:42 +0000 (12:07 -0800)]
Fix MD5 detection in the autoconf build
This is a front port of patches made in 3.6.x branch for bugs:
* 9037
* 9086
* 9094
* 9418
It checks if there is a library for md5 related functions (libmd or
libmd5) and if so it checks for the presence of md5.h headers it also
respect the need for osX build to not use samba's md5 implementation as
it's already present in the system libs.
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Fri Nov 23 10:05:34 CET 2012 on sn-devel-104
Jelmer Vernooij [Thu, 22 Nov 2012 00:47:00 +0000 (00:47 +0000)]
web_server: Load SWAT if it is available.
Reviewed-by: Matthieu Patou <mat@matws.net>
Autobuild-User(master): Matthieu Patou <mat@samba.org>
Autobuild-Date(master): Fri Nov 23 01:39:38 CET 2012 on sn-devel-104
Jelmer Vernooij [Thu, 22 Nov 2012 00:46:59 +0000 (00:46 +0000)]
web_server: the web server is not multi-process, indicate so in WSGI.
This is a requirement for some of the paster middleware used by SWAT2.
Reviewed-by: Matthieu Patou <mat@matws.net>
git.samba.org / nivanova / samba-autobuild / .git / log