obnox/wireshark/wip.git
14 years agoFix typo.
guy [Tue, 30 Jun 2009 19:10:11 +0000 (19:10 +0000)]
Fix typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28894 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix typo.
guy [Tue, 30 Jun 2009 19:09:18 +0000 (19:09 +0000)]
Fix typo.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28893 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIntroduce experimental new feature: GTK2 tree view based packet list
sfisher [Tue, 30 Jun 2009 18:05:04 +0000 (18:05 +0000)]
Introduce experimental new feature: GTK2 tree view based packet list

To use the GTK2 based packet list, define NEW_PACKET_LIST when compiling.
To do this with gcc, set the environment variable CPPFLAGS to
"-DNEW_PACKET_LIST" and re-run configure.

Many features do not yet work.  This work began with prototypes by Ulf
quite a while back.  I've put quite a bit of work into this so far and
as discussed with a few of the core team members at Sharkfest09 and it was
decided that it would be best to commit what I have so far to allow others to
help work on this.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28892 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agopacket-radius: Fix exception CLEANUP handling when malformed attribute list/pair...
wmeier [Tue, 30 Jun 2009 13:57:26 +0000 (13:57 +0000)]
packet-radius: Fix exception CLEANUP handling when malformed attribute list/pair seen;
Fixes crash reported in Bug #3578. [https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3578]
Essentially: CLEANUP_CALL_AND_POP wasn't being executed for certain error exits from
 dissect_attribute_pairs() thus leaving a CLEANUP entry on the exception stack.
Also: vsa_buffer_table wasn't being destroyed if an exception occurred in dissect_attribute_pairs.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28891 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAlways register to tcp.port to be able to decode as.
stig [Tue, 30 Jun 2009 12:26:11 +0000 (12:26 +0000)]
Always register to tcp.port to be able to decode as.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28890 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChanged check for having multiple ldap PDU's in one frame.
stig [Tue, 30 Jun 2009 10:38:00 +0000 (10:38 +0000)]
Changed check for having multiple ldap PDU's in one frame.
The previous check is incorrect when the first ldap frame in the capture is
selected and the filter is changed, or selecting "Follow TCP Stream".

Also removed check_col().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28889 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCleanup protocol name for ldap.
stig [Tue, 30 Jun 2009 08:28:21 +0000 (08:28 +0000)]
Cleanup protocol name for ldap.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28888 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoPut in missing newline at the end.
guy [Tue, 30 Jun 2009 00:32:20 +0000 (00:32 +0000)]
Put in missing newline at the end.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28887 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix a couple of AirPcap channel/offset bugs. Remove an unused
gerald [Mon, 29 Jun 2009 23:08:05 +0000 (23:08 +0000)]
Fix a couple of AirPcap channel/offset bugs. Remove an unused
routine. Fixup whitespace in a couple of places.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28886 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdded option to show not dissected packet data on a separate packet bytes pane.
rbalint [Mon, 29 Jun 2009 22:22:30 +0000 (22:22 +0000)]
Added option to show not dissected packet data on a separate packet bytes pane.
It makes offsets in the not dissected data easier to follow.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28885 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam: Fix for Bug #3572
wmeier [Mon, 29 Jun 2009 20:59:26 +0000 (20:59 +0000)]
From  Kovarththanan Rajaratnam: Fix for Bug #3572
[http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3572]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28884 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd value for vfstate: active
jmayer [Mon, 29 Jun 2009 20:35:47 +0000 (20:35 +0000)]
Add value for vfstate: active

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28883 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWiresharkPortable.ini -> WiresharkPortable.tmpl
stig [Mon, 29 Jun 2009 20:16:20 +0000 (20:16 +0000)]
WiresharkPortable.ini -> WiresharkPortable.tmpl

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28882 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Artem Tamazov:
etxrab [Mon, 29 Jun 2009 19:24:14 +0000 (19:24 +0000)]
From Artem Tamazov:
Added: PW ATM 1:1, AAL5 SDU, AAL5 PDU support + BFD fix + PW ATM OAM fix

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28881 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChanges to address bug 3547:
gal [Mon, 29 Jun 2009 13:01:54 +0000 (13:01 +0000)]
Changes to address bug 3547:

1) Make sure WiresharkPortable.nsi uses correct WinPcap version (from config.nmake), and also vcredist.
2) Automatically generate WiresharkPortable.ini with correct default values
3) Include readme.txt in the distribution so that users know how to use WiresharkPortable.ini

Thanks to Kovarththanan Rajaratnam for basic patch.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28880 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agofix bug #3439 (thanks to Kovarththanan Rajaratnam), make WS compilable under MSVC2005...
ulfl [Sun, 28 Jun 2009 21:13:51 +0000 (21:13 +0000)]
fix bug #3439 (thanks to Kovarththanan Rajaratnam), make WS compilable under MSVC2005(EE) again.

Some definitions are not available on MSVC2005. This fix "detects" the MSVC version used, it might still not work with MSVC2008EE though (I guess the required definitions are depending on the Windows SDK installed).

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28879 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAnalyze!Enabled Protocols: Fix so type-ahead find OK w/o needing to first select...
wmeier [Sun, 28 Jun 2009 20:01:37 +0000 (20:01 +0000)]
Analyze!Enabled Protocols: Fix so type-ahead find OK w/o needing to first select a row.
 Ditto when clicking on a column header to change the sort order.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28878 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd support for DLT_PPP_WITH_DIR. This fixes bug 3619.
tuexen [Sun, 28 Jun 2009 18:22:15 +0000 (18:22 +0000)]
Add support for DLT_PPP_WITH_DIR. This fixes bug 3619.
Thanks for Tyson Key for reporting the issue.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28877 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWe only support GLib 2.x/GTK+ 2.x, which uses pkg-config, not
guy [Sun, 28 Jun 2009 17:23:07 +0000 (17:23 +0000)]
We only support GLib 2.x/GTK+ 2.x, which uses pkg-config, not
gtk-config; use it instead.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28876 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMake dissector handle unexpected data better.
jake [Sun, 28 Jun 2009 16:39:31 +0000 (16:39 +0000)]
Make dissector handle unexpected data better.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28875 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDetect gnutls via pkg-config instead of the deprecated libgnutls-config.
rbalint [Sun, 28 Jun 2009 16:31:27 +0000 (16:31 +0000)]
Detect gnutls via pkg-config instead of the deprecated libgnutls-config.
Based on patch from Andreas Metzler.
This fixes bug 3627.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28874 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Sean Walberg:
etxrab [Sun, 28 Jun 2009 15:22:43 +0000 (15:22 +0000)]
From   Sean Walberg:
The title in the TCP sequence graphs is too short.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3556

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28873 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Jon Smirl:
etxrab [Sun, 28 Jun 2009 15:18:27 +0000 (15:18 +0000)]
From Jon Smirl:
More packet decoding for Intellon powerline devices.

From me put proto_register_homeplug() last in the file and whitespace changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28872 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago[Automatic manuf and enterprise-numbers update for 2009-06-28]
gerald [Sun, 28 Jun 2009 15:03:26 +0000 (15:03 +0000)]
[Automatic manuf and enterprise-numbers update for 2009-06-28]

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28869 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoStop loading a pcapng file with multiple section header blocks.
tuexen [Sun, 28 Jun 2009 11:09:24 +0000 (11:09 +0000)]
Stop loading a pcapng file with multiple section header blocks.
This fixes a bug reported by Tyson Key as a follow up of Bug 3560.
Also some cleanups and debug output improvements.

Thanks to Tyson Key for reporting the bug and providing a tracefile.
This fix will be included in Wireshark 1.2.1 and higher.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28868 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoStrictly require flex instead of allowing lex, too.
rbalint [Sun, 28 Jun 2009 04:20:10 +0000 (04:20 +0000)]
Strictly require flex instead of allowing lex, too.
It compiles now.
This fixes bug 1641.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28867 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAccept file snaplen larger than WTAP_MAX_PACKET_SIZE,
tuexen [Sat, 27 Jun 2009 18:50:13 +0000 (18:50 +0000)]
Accept file snaplen larger than WTAP_MAX_PACKET_SIZE,
text2pcap uses 102400.
This fixes bug 3620. Thanks to Tyson Key for reporting the bug
and providing capture files.
This fix should be included in Wireshark 1.2.1 and higher.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28866 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix copy/paste error introduced in rev. 28863.
tuexen [Sat, 27 Jun 2009 18:10:10 +0000 (18:10 +0000)]
Fix copy/paste error introduced in rev. 28863.
Thanks to Guy for finding and reporting it.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28865 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAnother cleanup. We are now back to Ulf's original
tuexen [Sat, 27 Jun 2009 17:33:23 +0000 (17:33 +0000)]
Another cleanup. We are now back to Ulf's original
model of data handling.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28864 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCleanup. Should be included in Wireshark 1.2.1 and higher to keep
tuexen [Sat, 27 Jun 2009 16:08:18 +0000 (16:08 +0000)]
Cleanup. Should be included in Wireshark 1.2.1 and higher to keep
merging future bug fixes simple.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28863 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd support for writing pcapng files with multiple
tuexen [Sat, 27 Jun 2009 15:20:44 +0000 (15:20 +0000)]
Add support for writing pcapng files with multiple
encapsulations.
This fixes a bug reported by Sake during the
Sharkfest 09. Thanks for providing a
Netscreen tracefile with multiple link layer
types.
This patch will be included in Wireshark 1.2.1
and higher.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28862 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom yin sun:
etxrab [Sat, 27 Jun 2009 13:37:03 +0000 (13:37 +0000)]
From   yin sun:
h248 term wildcard enhancement

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28861 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Greg Schwendimann:
etxrab [Sat, 27 Jun 2009 12:41:39 +0000 (12:41 +0000)]
From Greg Schwendimann:
802.11 decryption is broken
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3590

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28860 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThis patch
tuexen [Sat, 27 Jun 2009 12:41:06 +0000 (12:41 +0000)]
This patch
* adds an encapsulation argument to pcap_write_phdr.
* writes the pseudo header when writing pcapng files.

This fixes a bug where you could not write pcapng files
when using encapsulations requiring pseudo headers.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28859 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoIf all interfaces use the same encapsulation, use
tuexen [Sat, 27 Jun 2009 12:14:18 +0000 (12:14 +0000)]
If all interfaces use the same encapsulation, use
this a the file encapsulation.

This fixes a bug where you can not save a file
in libpcap format when you captured it as a
pcapng one.

This fix will be scheduled for Wireshark 1.2.1
and higher.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28858 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoThis commit
tuexen [Sat, 27 Jun 2009 11:39:47 +0000 (11:39 +0000)]
This commit
* adds an encap argument to pcap_process_pseudo_header.
* adds support for reading pseudo headers.
It fixes Bug 3560.
Thanks to Tyson Key for reporting the bug and providing
trace files. This fix will be scheduled for inclusion in
Wireshark 1.2.1 and higher.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28857 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam:
etxrab [Sat, 27 Jun 2009 10:31:42 +0000 (10:31 +0000)]
From Kovarththanan Rajaratnam:
- Fix ncp2222.py and all the epan/dissectors/dcerpc dissectors. The
latter required changes to idl2wrs which used variadic macros (not supported in MSVC 6.0).

- Cleanup PIDL conformance files

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28856 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRevert commit 28854.
rbalint [Sat, 27 Jun 2009 08:13:39 +0000 (08:13 +0000)]
Revert commit 28854.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28855 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoStrictly require flex instead of allowing lex, too.
rbalint [Sat, 27 Jun 2009 06:32:52 +0000 (06:32 +0000)]
Strictly require flex instead of allowing lex, too.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28854 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd a tooltip in case it's not obvious how to rearrange the columns.
gerald [Fri, 26 Jun 2009 23:05:04 +0000 (23:05 +0000)]
Add a tooltip in case it's not obvious how to rearrange the columns.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28853 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUnfortunately, r28452 seems to cause more problems than it fixes. Back
gerald [Fri, 26 Jun 2009 21:25:09 +0000 (21:25 +0000)]
Unfortunately, r28452 seems to cause more problems than it fixes. Back
out the change for now.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28852 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDisable debug output.
tuexen [Fri, 26 Jun 2009 15:25:22 +0000 (15:25 +0000)]
Disable debug output.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28851 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago* Allocate enough memory for reading a packet.
tuexen [Fri, 26 Jun 2009 15:08:04 +0000 (15:08 +0000)]
* Allocate enough memory for reading a packet.
* Initialize pseudoheader.
* Add some input validation / protection code.
* Fix some return values.
* Clean up some whitespaces.

This fixes Bug 3565. Thanks to Tyson Key how reported
the issue and provided capture files for debugging.

This fix is scheduled for inclusion in Wireshark 1.2.1
and higher.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28850 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Sebastien Decugis:
etxrab [Fri, 26 Jun 2009 05:48:03 +0000 (05:48 +0000)]
From Sebastien Decugis:
Add Missing Diameter EAP support.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3600

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28849 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRe-generate asn1 dissectors after hf_register_info cleanup.
stig [Fri, 26 Jun 2009 03:59:01 +0000 (03:59 +0000)]
Re-generate asn1 dissectors after hf_register_info cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28848 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoSmall whitespace cleanup.
stig [Fri, 26 Jun 2009 03:37:30 +0000 (03:37 +0000)]
Small whitespace cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28847 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUse NULL for empty blurb.
stig [Fri, 26 Jun 2009 03:24:08 +0000 (03:24 +0000)]
Use NULL for empty blurb.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28846 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agotvb_child_new_real_data() -> tvb_new_child_real_data()
stig [Fri, 26 Jun 2009 03:20:12 +0000 (03:20 +0000)]
tvb_child_new_real_data() -> tvb_new_child_real_data()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28845 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Joakim Wiberg via bug 3103:
stig [Fri, 26 Jun 2009 02:38:23 +0000 (02:38 +0000)]
From Joakim Wiberg via bug 3103:
Various improvements to the CIP and ENIP dissectors.

From me:
Updated to latest trunk changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28844 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agotvb_new_real_data()->tvb_child_new_real_data()
etxrab [Thu, 25 Jun 2009 05:59:04 +0000 (05:59 +0000)]
tvb_new_real_data()->tvb_child_new_real_data()

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28843 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUnsigned does not have msign.
stig [Thu, 25 Jun 2009 02:13:35 +0000 (02:13 +0000)]
Unsigned does not have msign.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28842 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Nathan Hartwell via bug 2733:
stig [Thu, 25 Jun 2009 02:08:06 +0000 (02:08 +0000)]
From Nathan Hartwell via bug 2733:
Use time_secs_to_str_unsigned().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28841 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Nathan Hartwell via bug 2733:
stig [Thu, 25 Jun 2009 02:07:17 +0000 (02:07 +0000)]
From Nathan Hartwell via bug 2733:
Added time_secs_to_str_unsigned().

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28840 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove a tvb_free() call.
stig [Thu, 25 Jun 2009 01:50:56 +0000 (01:50 +0000)]
Remove a tvb_free() call.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28839 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Duncan Salerno:
jake [Wed, 24 Jun 2009 20:27:58 +0000 (20:27 +0000)]
From Duncan Salerno:
Ensure dct3trac packets never longer than 23 bytes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28838 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam via bug 3555:
stig [Wed, 24 Jun 2009 19:10:50 +0000 (19:10 +0000)]
From Kovarththanan Rajaratnam via bug 3555:
Cancel hostname lookup timers if c-ares is not initialized.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28837 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Artem Tamazov:
jake [Wed, 24 Jun 2009 06:21:45 +0000 (06:21 +0000)]
From Artem Tamazov:
Added: ESMC support as per G.8264 (Slow Protocol Subtype 0x0a).
* QL codes are dissected according to G.781 5.5.1.1 "Option I SDH".
Added: support for Timestamp entities in ESMC PDU as per WD56 proposal.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28836 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFixed field types for some reserved fields.
stig [Wed, 24 Jun 2009 05:54:19 +0000 (05:54 +0000)]
Fixed field types for some reserved fields.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28835 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore hf_register_info related cleanup.
stig [Wed, 24 Jun 2009 03:03:25 +0000 (03:03 +0000)]
More hf_register_info related cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28834 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove superflous code; #include <stdio.h> not needed.
wmeier [Wed, 24 Jun 2009 02:42:43 +0000 (02:42 +0000)]
Remove superflous code; #include <stdio.h> not needed.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28833 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam:
stig [Wed, 24 Jun 2009 02:17:12 +0000 (02:17 +0000)]
From Kovarththanan Rajaratnam:
More hf_register_info related cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28832 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam:
stig [Wed, 24 Jun 2009 02:12:13 +0000 (02:12 +0000)]
From Kovarththanan Rajaratnam:
Move hf_register_info declarations in packet-m2m.c to function scope

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28831 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam:
stig [Wed, 24 Jun 2009 02:11:11 +0000 (02:11 +0000)]
From Kovarththanan Rajaratnam:
Cleanup hf_register_info declaration passed to llc_add_oui(). While there,
change the declaration to an array in order to be consistent with the rest
of packet-*.c files.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28830 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange hf_nisplus_dummy to use "dummy" as name instead of " "
stig [Wed, 24 Jun 2009 02:08:14 +0000 (02:08 +0000)]
Change hf_nisplus_dummy to use "dummy" as name instead of " "
(this is the only place where " " was used)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28829 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam:
stig [Wed, 24 Jun 2009 02:07:16 +0000 (02:07 +0000)]
From Kovarththanan Rajaratnam:
More hf_register_info related cleanup
* Fix process-x11-fields.pl (packet-x11.c)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28828 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore hf_register_info related cleanup.
stig [Wed, 24 Jun 2009 02:05:51 +0000 (02:05 +0000)]
More hf_register_info related cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28827 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam:
stig [Wed, 24 Jun 2009 01:40:54 +0000 (01:40 +0000)]
From Kovarththanan Rajaratnam:
More asn1/* header field info cleanup

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28826 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRemove two unused includes
wmeier [Wed, 24 Jun 2009 00:49:54 +0000 (00:49 +0000)]
Remove two unused includes

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28825 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoif (!initialized) ... not req'd + other addt'l minor revisions;
wmeier [Wed, 24 Jun 2009 00:29:54 +0000 (00:29 +0000)]
if (!initialized) ... not req'd + other addt'l minor revisions;
Also: add packet-hpteam.c to Makefile.common so it gets built as part oif Wireshark.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28824 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Nathan Hartwell:
jake [Tue, 23 Jun 2009 21:05:47 +0000 (21:05 +0000)]
From Nathan Hartwell:
This patch attempt should more closely align with the Wireshark "layout" of using
a dissector rather than a "hack" to the packet-llc dissector.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28823 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate 3GPP AVP:s
etxrab [Tue, 23 Jun 2009 16:01:55 +0000 (16:01 +0000)]
Update 3GPP AVP:s

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28822 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoRevert(Try to fix indentation a bit.)
etxrab [Tue, 23 Jun 2009 14:16:28 +0000 (14:16 +0000)]
Revert(Try to fix indentation a bit.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28821 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoTry to fix indentation a bit.
etxrab [Tue, 23 Jun 2009 13:49:46 +0000 (13:49 +0000)]
Try to fix indentation a bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28820 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam:
jake [Tue, 23 Jun 2009 06:49:38 +0000 (06:49 +0000)]
From Kovarththanan Rajaratnam:
The Bluetooth AMP Manager protocol was recently adopted by the Bluetooth SIG.
This protocol sits on top of L2CAP and requires a few changes in order to
accommodate the new move/create channel request.

This patch includes:
* a new Bluetooth AMP Manager Protocol dissector
* changes to L2CAP to handle the new move/create channel signals
* introduce a dissector table for fixed channel, allowing btamp dissector to
handle the BT AMP Manager Protocol channel
* Preliminary changes in L2CAP to support the new enhanced L2CAP modes
(enhanced retransmission/streaming mode)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28819 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Shinsuke SUZUKI:
jake [Tue, 23 Jun 2009 06:45:59 +0000 (06:45 +0000)]
From Shinsuke SUZUKI:
Due to an incorrect offset setting in packet-icmpv6.c Wireshark cannot parse RA router-lifetime and RA flags properly.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28818 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam:
stig [Tue, 23 Jun 2009 06:02:12 +0000 (06:02 +0000)]
From Kovarththanan Rajaratnam:
Clean up header field info in asn1/*-template.c files.

From me:
Fixed a few typos in the patch.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28817 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoCopy AUTHORS-SHORT to the top-level directory so Help->About can find it when run...
morriss [Mon, 22 Jun 2009 22:48:35 +0000 (22:48 +0000)]
Copy AUTHORS-SHORT to the top-level directory so Help->About can find it when run from the build directory.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28816 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoInstead of tvb_get_ptr + ep_alloc + proto_tree_add_string to fetch a string and
gerald [Mon, 22 Jun 2009 22:38:29 +0000 (22:38 +0000)]
Instead of tvb_get_ptr + ep_alloc + proto_tree_add_string to fetch a string and
add it to the tree, just call proto_tree_add_item. Fixes bug 3564.

Replace another tvb_get_ptr call with tvb_format_text.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28815 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam:
stig [Mon, 22 Jun 2009 18:23:58 +0000 (18:23 +0000)]
From Kovarththanan Rajaratnam:
More header field info cleanup in plugins/* and epan/dissectors/*

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28811 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange window_new() to dlg_window_new() and destroy the window with the top level...
etxrab [Mon, 22 Jun 2009 15:22:37 +0000 (15:22 +0000)]
Change window_new() to dlg_window_new() and destroy the window with the top level window.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28810 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoImprove heuristic for packetlogger file format detection.
tuexen [Mon, 22 Jun 2009 12:13:12 +0000 (12:13 +0000)]
Improve heuristic for packetlogger file format detection.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28809 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd protection code to avoid crashed when .erf files
tuexen [Mon, 22 Jun 2009 11:45:28 +0000 (11:45 +0000)]
Add protection code to avoid crashed when .erf files
are wrongly identified as packetlogger ones.
Will be scheduled for 1.2.1.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28808 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix my 'fix': guint8 > 0 is always true
jmayer [Mon, 22 Jun 2009 07:27:14 +0000 (07:27 +0000)]
Fix my 'fix': guint8 > 0 is always true

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28807 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd -Wextra (ok, it was already there as -W) and -Wlogical-op
jmayer [Mon, 22 Jun 2009 06:31:11 +0000 (06:31 +0000)]
Add -Wextra (ok, it was already there as -W) and -Wlogical-op

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28806 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix warning: always evaluates to true/false
jmayer [Mon, 22 Jun 2009 06:29:32 +0000 (06:29 +0000)]
Fix warning: always evaluates to true/false

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28805 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoLots of additional decoding, still quite a few things missing.
jmayer [Mon, 22 Jun 2009 06:28:10 +0000 (06:28 +0000)]
Lots of additional decoding, still quite a few things missing.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28804 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoDefault to BASE_NONE for FT_BOOLEAN with zero value for display.
stig [Mon, 22 Jun 2009 06:16:39 +0000 (06:16 +0000)]
Default to BASE_NONE for FT_BOOLEAN with zero value for display.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28803 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore header_field_info cleanup.
stig [Mon, 22 Jun 2009 06:02:36 +0000 (06:02 +0000)]
More header_field_info cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28802 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFix for bug 3559:
jake [Mon, 22 Jun 2009 05:57:44 +0000 (05:57 +0000)]
Fix for bug 3559:
Don't let the index run over the size of the array.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28801 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore header_field_info cleanup.
stig [Mon, 22 Jun 2009 05:45:00 +0000 (05:45 +0000)]
More header_field_info cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28800 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore header_field_info cleanup.
stig [Mon, 22 Jun 2009 05:35:47 +0000 (05:35 +0000)]
More header_field_info cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28799 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoMore header_field_info cleanup.
stig [Mon, 22 Jun 2009 05:18:37 +0000 (05:18 +0000)]
More header_field_info cleanup.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28798 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam:
stig [Mon, 22 Jun 2009 04:58:08 +0000 (04:58 +0000)]
From Kovarththanan Rajaratnam:
Move header field info declarations into function scope.

This is the first step. Another patch will be submitted which actually scrubs
the header field info declarations (remove empty blurbs, etc.)

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28797 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoChange window_new() to dlg_window_new() and destroy the window with the top level...
etxrab [Sun, 21 Jun 2009 20:42:07 +0000 (20:42 +0000)]
Change window_new() to dlg_window_new() and destroy the window with the top level window.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28796 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoUpdate for main_menu.[ch] -> menus.[ch] change.
guy [Sun, 21 Jun 2009 19:30:19 +0000 (19:30 +0000)]
Update for main_menu.[ch] -> menus.[ch] change.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28795 f5534014-38df-0310-8fa8-9805f1628bb7

14 years ago"main_menu.[ch]" -> "menus.[ch]"; it handles not only the main menu, but
guy [Sun, 21 Jun 2009 19:16:37 +0000 (19:16 +0000)]
"main_menu.[ch]" -> "menus.[ch]"; it handles not only the main menu, but
context menus.

Note why we have an empty hex dump pane context menu.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28794 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoClean up the "available XXX type" messages a bit.
guy [Sun, 21 Jun 2009 18:55:32 +0000 (18:55 +0000)]
Clean up the "available XXX type" messages a bit.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28793 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoFrom Kovarththanan Rajaratnam via bug 3548:
stig [Sun, 21 Jun 2009 18:45:56 +0000 (18:45 +0000)]
From Kovarththanan Rajaratnam via bug 3548:
More header_field_info cleanup.

From me:
Don't fix the empty name for hf_nisplus_dummy.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28792 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoAdd duration to the tap info.
etxrab [Sun, 21 Jun 2009 18:27:34 +0000 (18:27 +0000)]
Add duration to the tap info.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28791 f5534014-38df-0310-8fa8-9805f1628bb7

14 years agoWhite space changes.
etxrab [Sun, 21 Jun 2009 18:24:03 +0000 (18:24 +0000)]
White space changes.

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@28790 f5534014-38df-0310-8fa8-9805f1628bb7