ASoC: Intel: bytcr_rt5651: align quirk override handling
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Fri, 19 Apr 2019 20:12:18 +0000 (15:12 -0500)
committerMark Brown <broonie@kernel.org>
Thu, 25 Apr 2019 19:23:21 +0000 (20:23 +0100)
As discussed on alsa-devel, a zero value is useful to get rid of all
quirks. Set default to -1 and align types as done in other machine
drivers.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/bytcr_rt5651.c

index 21c6675abd19af25e3aaf373d67399af3b80b1e1..ca657c3e5726d952d463464653d5b086b43a59c6 100644 (file)
@@ -102,8 +102,8 @@ static const struct acpi_gpio_mapping *byt_rt5651_gpios;
 static unsigned long byt_rt5651_quirk = BYT_RT5651_DEFAULT_QUIRKS |
                                        BYT_RT5651_IN2_MAP;
 
-static unsigned int quirk_override;
-module_param_named(quirk, quirk_override, uint, 0444);
+static int quirk_override = -1;
+module_param_named(quirk, quirk_override, int, 0444);
 MODULE_PARM_DESC(quirk, "Board-specific quirk override");
 
 static void log_quirks(struct device *dev)
@@ -987,7 +987,7 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
        /* check quirks before creating card */
        dmi_check_system(byt_rt5651_quirk_table);
 
-       if (quirk_override) {
+       if (quirk_override != -1) {
                dev_info(&pdev->dev, "Overriding quirk 0x%x => 0x%x\n",
                         (unsigned int)byt_rt5651_quirk, quirk_override);
                byt_rt5651_quirk = quirk_override;