irqchip: gic-pm: Use pm_runtime_resume_and_get() in gic_probe()
authorShang XiaoJing <shangxiaojing@huawei.com>
Thu, 24 Nov 2022 06:51:50 +0000 (14:51 +0800)
committerMarc Zyngier <maz@kernel.org>
Sat, 26 Nov 2022 13:29:42 +0000 (13:29 +0000)
gic_probe() calls pm_runtime_get_sync() and added fail path as
rpm_put to put usage_counter. However, pm_runtime_get_sync()
will increment usage_counter even it failed. Fix it by replacing it with
pm_runtime_resume_and_get() to keep usage counter balanced.

Fixes: 9c8edddfc992 ("irqchip/gic: Add platform driver for non-root GICs that require RPM")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20221124065150.22809-1-shangxiaojing@huawei.com
drivers/irqchip/irq-gic-pm.c

index b60e1853593f4282df1cb52f51ed088ea0ffcf83..3989d16f997b399b4e2beb24dd364f3afb328aa1 100644 (file)
@@ -102,7 +102,7 @@ static int gic_probe(struct platform_device *pdev)
 
        pm_runtime_enable(dev);
 
-       ret = pm_runtime_get_sync(dev);
+       ret = pm_runtime_resume_and_get(dev);
        if (ret < 0)
                goto rpm_disable;