r18800: fix a write behind the buffer bug...

Thanks Herb for finding this:-)

This was my bug, I typed it in on gd's laptop and he just run 'svn ci'

metze
(This used to be commit 3c08e29f4fdde586084bdcf1b36eaf92ae944750)

diff --git a/source4/torture/rpc/samr.c b/source4/torture/rpc/samr.c
index f9bd25dc37bd76c8a28d8cc1f3d25793dcfd1667..b387ec70bf3b1f6be5ff7a49f62a90b1f38ade51 100644 (file)
--- a/source4/torture/rpc/samr.c
+++ b/source4/torture/rpc/samr.c
@@ -1887,10 +1887,8 @@ static BOOL test_ChangePassword(struct dcerpc_pipe *p, TALLOC_CTX *mem_ctx,
                char *v = generate_random_str(mem_ctx, 1);
                int i;
 
-               for (i=0; i <ARRAY_SIZE(simple_pass); i++) {
-                       simple_pass[i] = *v;
-               }
-               simple_pass[i] = '\0';
+               ZERO_STRUCT(simple_pass);
+               memset(simple_pass, *v, sizeof(simple_pass) - 1);
 
                /* test what happens when picking a simple password */
                if (!test_ChangePasswordUser3(p, mem_ctx, acct_name, 0, password, simple_pass, 0, True)) {