KVM: arm64: Fix host-programmed guest events in nVHE
authorOliver Upton <oliver.upton@linux.dev>
Tue, 5 Mar 2024 18:48:39 +0000 (18:48 +0000)
committerOliver Upton <oliver.upton@linux.dev>
Tue, 26 Mar 2024 08:51:44 +0000 (01:51 -0700)
Programming PMU events in the host that count during guest execution is
a feature supported by perf, e.g.

  perf stat -e cpu_cycles:G ./lkvm run

While this works for VHE, the guest/host event bitmaps are not carried
through to the hypervisor in the nVHE configuration. Make
kvm_pmu_update_vcpu_events() conditional on whether or not _hardware_
supports PMUv3 rather than if the vCPU as vPMU enabled.

Cc: stable@vger.kernel.org
Fixes: 84d751a019a9 ("KVM: arm64: Pass pmu events to hyp via vcpu")
Reviewed-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20240305184840.636212-3-oliver.upton@linux.dev
Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
include/kvm/arm_pmu.h

index eb4c369a79eb31b705aa78ec28437d3de69b97b7..35d4ca4f6122c7d50e2541dbc56b1b25c93d69d6 100644 (file)
@@ -86,7 +86,7 @@ void kvm_vcpu_pmu_resync_el0(void);
  */
 #define kvm_pmu_update_vcpu_events(vcpu)                               \
        do {                                                            \
-               if (!has_vhe() && kvm_vcpu_has_pmu(vcpu))               \
+               if (!has_vhe() && kvm_arm_support_pmu_v3())             \
                        vcpu->arch.pmu.events = *kvm_get_pmu_events();  \
        } while (0)