SUNRPC: Fix a bogus get/put in generic_key_to_expire()
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Mon, 12 Nov 2018 21:06:51 +0000 (16:06 -0500)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Mon, 12 Nov 2018 21:39:13 +0000 (16:39 -0500)
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
net/sunrpc/auth_generic.c

index d8831b988b1e7a3273c73ee2457615b26c24b529..ab4a3be1542a0a6fcfb35153da1a62b3f852c2b6 100644 (file)
@@ -281,13 +281,7 @@ static bool generic_key_to_expire(struct rpc_cred *cred)
 {
        struct auth_cred *acred = &container_of(cred, struct generic_cred,
                                                gc_base)->acred;
-       bool ret;
-
-       get_rpccred(cred);
-       ret = test_bit(RPC_CRED_KEY_EXPIRE_SOON, &acred->ac_flags);
-       put_rpccred(cred);
-
-       return ret;
+       return test_bit(RPC_CRED_KEY_EXPIRE_SOON, &acred->ac_flags);
 }
 
 static const struct rpc_credops generic_credops = {