sctp: remove redundant assignment when call sctp_get_port_local
authorMao Wenan <maowenan@huawei.com>
Thu, 12 Sep 2019 04:02:18 +0000 (12:02 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 13 Sep 2019 20:06:20 +0000 (22:06 +0200)
There are more parentheses in if clause when call sctp_get_port_local
in sctp_do_bind, and redundant assignment to 'ret'. This patch is to
do cleanup.

Signed-off-by: Mao Wenan <maowenan@huawei.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/socket.c

index 1e26606683a8917ae5d5ea390f3085a2ea7a7b16..5fe26ca6edbd2d706d8982bf66a7715300265ce0 100644 (file)
@@ -399,9 +399,8 @@ static int sctp_do_bind(struct sock *sk, union sctp_addr *addr, int len)
         * detection.
         */
        addr->v4.sin_port = htons(snum);
-       if ((ret = sctp_get_port_local(sk, addr))) {
+       if (sctp_get_port_local(sk, addr))
                return -EADDRINUSE;
-       }
 
        /* Refresh ephemeral port.  */
        if (!bp->port)