wifi: iwlwifi: pcie: get_crf_id() can be void
authorJohannes Berg <johannes.berg@intel.com>
Thu, 7 Dec 2023 02:50:13 +0000 (04:50 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 12 Dec 2023 09:37:00 +0000 (10:37 +0100)
This never returns an error and the return value is never
checked anyway, so it can just be void.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20231207044813.898b7e99206f.I61378115093fe70e6f5baca7f334651e4190eb3b@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/intel/iwlwifi/pcie/drv.c

index 26a0953603ab4f4e234dd7872cd40ce825dd7d6b..2c9b98c8184b527363dca6aaf4aa7bb0d6cb51e3 100644 (file)
@@ -1121,9 +1121,8 @@ static const struct iwl_dev_info iwl_dev_info_table[] = {
 /*
  * Read rf id and cdb info from prph register and store it
  */
-static int get_crf_id(struct iwl_trans *iwl_trans)
+static void get_crf_id(struct iwl_trans *iwl_trans)
 {
-       int ret = 0;
        u32 sd_reg_ver_addr;
        u32 val = 0;
 
@@ -1150,8 +1149,6 @@ static int get_crf_id(struct iwl_trans *iwl_trans)
        IWL_INFO(iwl_trans, "Detected crf-id 0x%x, cnv-id 0x%x wfpm id 0x%x\n",
                 iwl_trans->hw_crf_id, iwl_trans->hw_cnv_id,
                 iwl_trans->hw_wfpm_id);
-
-       return ret;
 }
 
 /*