wifi: rtw89: 8852c: Fix TSSI causes transmit power inaccuracy

Modify TSSI ADC FIFO Clock follow RX ADC Clock can avoid
transmit power inaccuracy.

Signed-off-by: Kuan-Chung Chen <damon.chen@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230830092849.153251-3-pkshih@realtek.com

diff --git a/drivers/net/wireless/realtek/rtw89/reg.h b/drivers/net/wireless/realtek/rtw89/reg.h
index f9b15a1cc7907b6342721650ce37d242a091b839..7d25b76d90f5be34f7820a961715e02d480edfbb 100644 (file)
--- a/drivers/net/wireless/realtek/rtw89/reg.h
+++ b/drivers/net/wireless/realtek/rtw89/reg.h
@@ -4539,6 +4539,8 @@
 #define B_P0_TSSI_ALIM2 GENMASK(29, 0)
 #define R_P0_TSSI_ALIM4 0x5640
 #define R_TSSI_PA_K8 0x5644
+#define R_P0_TSSI_ADC_CLK 0x566c
+#define B_P0_TSSI_ADC_CLK GENMASK(17, 16)
 #define R_UPD_CLK 0x5670
 #define B_DAC_VAL BIT(31)
 #define B_ACK_VAL GENMASK(30, 29)
@@ -4651,6 +4653,8 @@
 #define B_P1_TSSI_ALIM31 GENMASK(9, 0)
 #define R_P1_TSSI_ALIM2 0x763c
 #define B_P1_TSSI_ALIM2 GENMASK(29, 0)
+#define R_P1_TSSI_ADC_CLK 0x766c
+#define B_P1_TSSI_ADC_CLK GENMASK(17, 16)
 #define R_P1_TSSIC 0x7814
 #define B_P1_TSSIC_BYPASS BIT(11)
 #define R_P1_TMETER 0x7810

diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c b/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c
index de7714f871d588955d6273ca522e77f9a440effa..7636368c8659e949be4ba6ee444fb1a7c5df8f94 100644 (file)
--- a/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c
@@ -2893,18 +2893,37 @@ static void _tssi_set_sys(struct rtw89_dev *rtwdev, enum rtw89_phy_idx phy,
                          enum rtw89_rf_path path)
 {
        const struct rtw89_chan *chan = rtw89_chan_get(rtwdev, RTW89_SUB_ENTITY_0);
+       enum rtw89_bandwidth bw = chan->band_width;
        enum rtw89_band band = chan->band_type;
+       u32 clk = 0x0;
 
        rtw89_rfk_parser(rtwdev, &rtw8852c_tssi_sys_defs_tbl);
 
-       if (path == RF_PATH_A)
+       switch (bw) {
+       case RTW89_CHANNEL_WIDTH_80:
+               clk = 0x1;
+               break;
+       case RTW89_CHANNEL_WIDTH_80_80:
+       case RTW89_CHANNEL_WIDTH_160:
+               clk = 0x2;
+               break;
+       default:
+               break;
+       }
+
+       if (path == RF_PATH_A) {
+               rtw89_phy_write32_mask(rtwdev, R_P0_TSSI_ADC_CLK,
+                                      B_P0_TSSI_ADC_CLK, clk);
                rtw89_rfk_parser_by_cond(rtwdev, band == RTW89_BAND_2G,
                                         &rtw8852c_tssi_sys_defs_2g_a_tbl,
                                         &rtw8852c_tssi_sys_defs_5g_a_tbl);
-       else
+       } else {
+               rtw89_phy_write32_mask(rtwdev, R_P1_TSSI_ADC_CLK,
+                                      B_P1_TSSI_ADC_CLK, clk);
                rtw89_rfk_parser_by_cond(rtwdev, band == RTW89_BAND_2G,
                                         &rtw8852c_tssi_sys_defs_2g_b_tbl,
                                         &rtw8852c_tssi_sys_defs_5g_b_tbl);
+       }
 }
 
 static void _tssi_ini_txpwr_ctrl_bb(struct rtw89_dev *rtwdev, enum rtw89_phy_idx phy,

diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk_table.c b/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk_table.c
index d727d528b36511a365ca4b4f17429d5538813e41..e5b0c2a686f0b6a6cf4a720ce56a764dedba4906 100644 (file)
--- a/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk_table.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852c_rfk_table.c
@@ -165,11 +165,11 @@ static const struct rtw89_reg5_def rtw8852c_tssi_sys_defs[] = {
        RTW89_DECL_RFK_WM(0x12bc, 0x000ffff0, 0xb5b5),
        RTW89_DECL_RFK_WM(0x32bc, 0x000ffff0, 0xb5b5),
        RTW89_DECL_RFK_WM(0x0300, 0xff000000, 0x16),
-       RTW89_DECL_RFK_WM(0x0304, 0x0000ffff, 0x1f19),
-       RTW89_DECL_RFK_WM(0x0308, 0xff000000, 0x1c),
+       RTW89_DECL_RFK_WM(0x0304, 0x0000ffff, 0x1313),
+       RTW89_DECL_RFK_WM(0x0308, 0xff000000, 0x13),
        RTW89_DECL_RFK_WM(0x0314, 0xffff0000, 0x2041),
-       RTW89_DECL_RFK_WM(0x0318, 0xffffffff, 0x20012041),
-       RTW89_DECL_RFK_WM(0x0324, 0xffff0000, 0x2001),
+       RTW89_DECL_RFK_WM(0x0318, 0xffffffff, 0x00410041),
+       RTW89_DECL_RFK_WM(0x0324, 0xffff0000, 0x0041),
        RTW89_DECL_RFK_WM(0x0020, 0x00006000, 0x3),
        RTW89_DECL_RFK_WM(0x0024, 0x00006000, 0x3),
        RTW89_DECL_RFK_WM(0x0704, 0xffff0000, 0x601e),
@@ -222,7 +222,7 @@ static const struct rtw89_reg5_def rtw8852c_tssi_txpwr_ctrl_bb_defs_a[] = {
        RTW89_DECL_RFK_WM(0x5810, 0xffffffff, 0x59010000),
        RTW89_DECL_RFK_WM(0x5814, 0x01ffffff, 0x026d000),
        RTW89_DECL_RFK_WM(0x5814, 0xf8000000, 0x00),
-       RTW89_DECL_RFK_WM(0x5818, 0xffffffff, 0x002c1800),
+       RTW89_DECL_RFK_WM(0x5818, 0xffffffff, 0x002c18e8),
        RTW89_DECL_RFK_WM(0x581c, 0x3fffffff, 0x3dc80280),
        RTW89_DECL_RFK_WM(0x5820, 0xffffffff, 0x00000080),
        RTW89_DECL_RFK_WM(0x58e8, 0x0000003f, 0x03),
@@ -251,7 +251,7 @@ static const struct rtw89_reg5_def rtw8852c_tssi_txpwr_ctrl_bb_defs_a[] = {
        RTW89_DECL_RFK_WM(0x58d4, 0x07fc0000, 0x100),
        RTW89_DECL_RFK_WM(0x58d8, 0xffffffff, 0x8008016c),
        RTW89_DECL_RFK_WM(0x58dc, 0x0001ffff, 0x0807f),
-       RTW89_DECL_RFK_WM(0x58dc, 0xfff00000, 0x800),
+       RTW89_DECL_RFK_WM(0x58dc, 0xfff00000, 0xc00),
        RTW89_DECL_RFK_WM(0x58f0, 0x0003ffff, 0x001ff),
        RTW89_DECL_RFK_WM(0x58f4, 0x000fffff, 0x000),
        RTW89_DECL_RFK_WM(0x58f8, 0x000fffff, 0x000),
@@ -260,14 +260,14 @@ static const struct rtw89_reg5_def rtw8852c_tssi_txpwr_ctrl_bb_defs_a[] = {
 RTW89_DECLARE_RFK_TBL(rtw8852c_tssi_txpwr_ctrl_bb_defs_a);
 
 static const struct rtw89_reg5_def rtw8852c_tssi_txpwr_ctrl_bb_defs_b[] = {
-       RTW89_DECL_RFK_WM(0x566c, 0x00001000, 0x0),
+       RTW89_DECL_RFK_WM(0x766c, 0x00001000, 0x0),
        RTW89_DECL_RFK_WM(0x7800, 0xffffffff, 0x003f807f),
        RTW89_DECL_RFK_WM(0x780c, 0x0000007f, 0x40),
        RTW89_DECL_RFK_WM(0x780c, 0x0fffff00, 0x00040),
        RTW89_DECL_RFK_WM(0x7810, 0xffffffff, 0x59010000),
        RTW89_DECL_RFK_WM(0x7814, 0x01ffffff, 0x026d000),
        RTW89_DECL_RFK_WM(0x7814, 0xf8000000, 0x00),
-       RTW89_DECL_RFK_WM(0x7818, 0xffffffff, 0x002c1800),
+       RTW89_DECL_RFK_WM(0x7818, 0xffffffff, 0x002c18e8),
        RTW89_DECL_RFK_WM(0x781c, 0x3fffffff, 0x3dc80280),
        RTW89_DECL_RFK_WM(0x7820, 0xffffffff, 0x00000080),
        RTW89_DECL_RFK_WM(0x78e8, 0x0000003f, 0x03),
@@ -296,7 +296,7 @@ static const struct rtw89_reg5_def rtw8852c_tssi_txpwr_ctrl_bb_defs_b[] = {
        RTW89_DECL_RFK_WM(0x78d4, 0x07fc0000, 0x100),
        RTW89_DECL_RFK_WM(0x78d8, 0xffffffff, 0x8008016c),
        RTW89_DECL_RFK_WM(0x78dc, 0x0001ffff, 0x0807f),
-       RTW89_DECL_RFK_WM(0x78dc, 0xfff00000, 0x800),
+       RTW89_DECL_RFK_WM(0x78dc, 0xfff00000, 0xc00),
        RTW89_DECL_RFK_WM(0x78f0, 0x0003ffff, 0x001ff),
        RTW89_DECL_RFK_WM(0x78f4, 0x000fffff, 0x000),
        RTW89_DECL_RFK_WM(0x78f8, 0x000fffff, 0x000),
@@ -511,9 +511,9 @@ static const struct rtw89_reg5_def rtw8852c_tssi_set_aligk_default_defs_5g_a[] =
        RTW89_DECL_RFK_WM(0x563c, 0x3fffffff, 0x00000000),
        RTW89_DECL_RFK_WM(0x5640, 0x000003ff, 0x000),
        RTW89_DECL_RFK_WM(0x5640, 0x000ffc00, 0x000),
-       RTW89_DECL_RFK_WM(0x5640, 0x3ff00000, 0x000),
-       RTW89_DECL_RFK_WM(0x5644, 0x000003ff, 0x000),
-       RTW89_DECL_RFK_WM(0x5644, 0x000ffc00, 0x000),
+       RTW89_DECL_RFK_WM(0x5640, 0x3ff00000, 0x3e9),
+       RTW89_DECL_RFK_WM(0x5644, 0x000003ff, 0x039),
+       RTW89_DECL_RFK_WM(0x5644, 0x000ffc00, 0x07d),
 };
 
 RTW89_DECLARE_RFK_TBL(rtw8852c_tssi_set_aligk_default_defs_5g_a);
@@ -531,9 +531,9 @@ static const struct rtw89_reg5_def rtw8852c_tssi_set_aligk_default_defs_5g_b[] =
        RTW89_DECL_RFK_WM(0x763c, 0x3fffffff, 0x00000000),
        RTW89_DECL_RFK_WM(0x7640, 0x000003ff, 0x000),
        RTW89_DECL_RFK_WM(0x7640, 0x000ffc00, 0x000),
-       RTW89_DECL_RFK_WM(0x7640, 0x3ff00000, 0x000),
-       RTW89_DECL_RFK_WM(0x7644, 0x000003ff, 0x000),
-       RTW89_DECL_RFK_WM(0x7644, 0x000ffc00, 0x000),
+       RTW89_DECL_RFK_WM(0x7640, 0x3ff00000, 0x3e9),
+       RTW89_DECL_RFK_WM(0x7644, 0x000003ff, 0x039),
+       RTW89_DECL_RFK_WM(0x7644, 0x000ffc00, 0x07d),
 };
 
 RTW89_DECLARE_RFK_TBL(rtw8852c_tssi_set_aligk_default_defs_5g_b);
@@ -551,9 +551,9 @@ static const struct rtw89_reg5_def rtw8852c_tssi_set_aligk_default_defs_6g_a[] =
        RTW89_DECL_RFK_WM(0x563c, 0x3fffffff, 0x00000000),
        RTW89_DECL_RFK_WM(0x5640, 0x000003ff, 0x000),
        RTW89_DECL_RFK_WM(0x5640, 0x000ffc00, 0x000),
-       RTW89_DECL_RFK_WM(0x5640, 0x3ff00000, 0x000),
-       RTW89_DECL_RFK_WM(0x5644, 0x000003ff, 0x000),
-       RTW89_DECL_RFK_WM(0x5644, 0x000ffc00, 0x000),
+       RTW89_DECL_RFK_WM(0x5640, 0x3ff00000, 0x3e9),
+       RTW89_DECL_RFK_WM(0x5644, 0x000003ff, 0x039),
+       RTW89_DECL_RFK_WM(0x5644, 0x000ffc00, 0x080),
 };
 
 RTW89_DECLARE_RFK_TBL(rtw8852c_tssi_set_aligk_default_defs_6g_a);
@@ -571,9 +571,9 @@ static const struct rtw89_reg5_def rtw8852c_tssi_set_aligk_default_defs_6g_b[] =
        RTW89_DECL_RFK_WM(0x763c, 0x3fffffff, 0x00000000),
        RTW89_DECL_RFK_WM(0x7640, 0x000003ff, 0x000),
        RTW89_DECL_RFK_WM(0x7640, 0x000ffc00, 0x000),
-       RTW89_DECL_RFK_WM(0x7640, 0x3ff00000, 0x000),
-       RTW89_DECL_RFK_WM(0x7644, 0x000003ff, 0x000),
-       RTW89_DECL_RFK_WM(0x7644, 0x000ffc00, 0x000),
+       RTW89_DECL_RFK_WM(0x7640, 0x3ff00000, 0x3e9),
+       RTW89_DECL_RFK_WM(0x7644, 0x000003ff, 0x039),
+       RTW89_DECL_RFK_WM(0x7644, 0x000ffc00, 0x080),
 };
 
 RTW89_DECLARE_RFK_TBL(rtw8852c_tssi_set_aligk_default_defs_6g_b);