winbind: check for allowed domains in winbindd_pam_auth_pac_verify()
authorRalph Boehme <slow@samba.org>
Thu, 14 Jan 2021 09:42:53 +0000 (10:42 +0100)
committerJeremy Allison <jra@samba.org>
Thu, 21 Jan 2021 21:48:30 +0000 (21:48 +0000)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14602

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
selftest/knownfail.d/samba3.blackbox.winbind_ignore_domain [deleted file]
source3/winbindd/winbindd_pam.c

diff --git a/selftest/knownfail.d/samba3.blackbox.winbind_ignore_domain b/selftest/knownfail.d/samba3.blackbox.winbind_ignore_domain
deleted file mode 100644 (file)
index e1eedc9..0000000
+++ /dev/null
@@ -1,2 +0,0 @@
-^samba3.blackbox.winbind_ignore_domain.test_winbind_ignore_domains_fail_ntlm_fqdn\(ad_member_idmap_ad:local\)
-^samba3.blackbox.winbind_ignore_domain.test_winbind_ignore_domains_fail_krb5\(ad_member_idmap_ad:local\)
index 3375af66821c48ecc953e7fecfb2fe8ea888a1db..f27802ee065495256f8eb04e910bce757a5f14e6 100644 (file)
@@ -3325,6 +3325,14 @@ NTSTATUS winbindd_pam_auth_pac_verify(struct winbindd_cli_state *state,
                return result;
        }
 
+       if (!is_allowed_domain(info6->base.logon_domain.string)) {
+               DBG_NOTICE("Authentication failed for user [%s] "
+                          "from firewalled domain [%s]\n",
+                          info6->base.account_name.string,
+                          info6->base.logon_domain.string);
+               return NT_STATUS_AUTHENTICATION_FIREWALL_FAILED;
+       }
+
        result = map_info6_to_validation(state->mem_ctx,
                                         info6,
                                         &validation_level,