r24058: Fix some memory leaks in ads_secrets_verify_ticket.
authorVolker Lendecke <vlendec@samba.org>
Thu, 26 Jul 2007 17:27:03 +0000 (17:27 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 17:29:00 +0000 (12:29 -0500)
Jeremy, Günther, please review!

Thanks,

Volker
(This used to be commit 000e096c277a71ca30c1c109aae62241ad466bee)

source3/libads/kerberos_verify.c

index 378258ee0877e6d8f4a007135d291cc42964e2b3..ed889d027a961b73e159d98764bf3e6cc0ca94a2 100644 (file)
@@ -274,6 +274,7 @@ static krb5_error_code ads_secrets_verify_ticket(krb5_context context,
                        auth_ok = True;
                        krb5_copy_keyblock(context, key, keyblock);
                        krb5_free_keyblock(context, key);
+                       SAFE_FREE(key);
                        break;
                }
 
@@ -285,10 +286,12 @@ static krb5_error_code ads_secrets_verify_ticket(krb5_context context,
                if (ret == KRB5KRB_AP_ERR_TKT_NYV || 
                    ret == KRB5KRB_AP_ERR_TKT_EXPIRED ||
                    ret == KRB5KRB_AP_ERR_SKEW) {
+                       SAFE_FREE(key);
                        break;
                }
 
                krb5_free_keyblock(context, key);
+               SAFE_FREE(key);
 
        }