winbind: Use dom_sid_str_buf
authorVolker Lendecke <vl@samba.org>
Fri, 23 Nov 2018 07:53:45 +0000 (08:53 +0100)
committerRalph Boehme <slow@samba.org>
Tue, 27 Nov 2018 06:13:14 +0000 (07:13 +0100)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/winbindd/winbindd_getusersids.c

index 024bad2b9e5d27e86c3df7e706134ee628488c7b..9a6a24107b9653a9a48acba9180a0ffd4d554c05 100644 (file)
@@ -104,13 +104,11 @@ NTSTATUS winbindd_getusersids_recv(struct tevent_req *req,
        }
 
        for (i=0; i<state->num_sids; i++) {
-               char *str = sid_string_tos(&state->sids[i]);
-               if (str == NULL) {
-                       TALLOC_FREE(result);
-                       return NT_STATUS_NO_MEMORY;
-               }
-               result = talloc_asprintf_append_buffer(result, "%s\n", str);
-               TALLOC_FREE(str);
+               struct dom_sid_buf sidbuf;
+               result = talloc_asprintf_append_buffer(
+                       result,
+                       "%s\n",
+                       dom_sid_str_buf(&state->sids[i], &sidbuf));
                if (result == NULL) {
                        return NT_STATUS_NO_MEMORY;
                }