Fix checkapi detected errors.

Missing log message:
From Vincent Helfre:
GSM RLC MAC dissector

There are 2 things remaining to do:

-  Update to Rel 8 the control messages such as Packet Measurement Order, Packet Measurement Report, Packet Cell Change Order, Packet Cell Change Notification…

-  Improve the display by replacing the strings describing the type by a hf field

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@36088 f5534014-38df-0310-8fa8-9805f1628bb7

diff --git a/epan/dissectors/packet-gsm_rlcmac.c b/epan/dissectors/packet-gsm_rlcmac.c
index 72e9cc2c53bb2a60c7433998f08884d975b76f3d..330b35aefa26903cb2fbd47e6b2a9b294513a007 100644 (file)
--- a/epan/dissectors/packet-gsm_rlcmac.c
+++ b/epan/dissectors/packet-gsm_rlcmac.c
@@ -2775,7 +2775,7 @@ CSN_DESCR_END  (RepeatedEUTRAN_NeighbourCells_t)
 const
 CSN_DESCR_BEGIN(PCID_Pattern_t)
   M_UINT       (PCID_Pattern_t, PCID_Pattern_length, 3),
-  M_VAR_BITMAP (PCID_Pattern_t, PCID_Pattern, PCID_Pattern_length, 1), // offset 1, 44.060 12.57
+  M_VAR_BITMAP (PCID_Pattern_t, PCID_Pattern, PCID_Pattern_length, 1), /* offset 1, 44.060 12.57 */
   M_UINT       (PCID_Pattern_t, PCID_Pattern_sense, 1),
 CSN_DESCR_END  (PCID_Pattern_t)
 
@@ -3830,7 +3830,7 @@ dissect_gsm_rlcmac_uplink(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tre
   proto_item   *ti;
   proto_tree *rlcmac_tree = NULL;
   guint8 payload_type = tvb_get_bits8(tvb, 0, 2);
-  RlcMacUplink_t * data = (RlcMacUplink_t *)malloc(sizeof(RlcMacUplink_t));
+  RlcMacUplink_t * data = (RlcMacUplink_t *)ep_alloc(sizeof(RlcMacUplink_t));
 
   if (payload_type == PAYLOAD_TYPE_DATA)
   {
@@ -3934,7 +3934,6 @@ dissect_gsm_rlcmac_uplink(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *tre
       ret = -1; 
       break;
   }
-  free(data);
 }
 
 static void
@@ -3943,7 +3942,7 @@ dissect_gsm_rlcmac_downlink(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *t
   csnStream_t  ar;
   proto_item   *ti;
   proto_tree *rlcmac_tree = NULL;
-  RlcMacDownlink_t * data =(RlcMacDownlink_t *) malloc(sizeof(RlcMacDownlink_t));
+  RlcMacDownlink_t * data =(RlcMacDownlink_t *) ep_alloc(sizeof(RlcMacDownlink_t));
   MSGGPRS_Status_t ret;
 
   /* See RLC/MAC downlink control block structure in TS 44.060 / 10.3.1 */
@@ -4127,7 +4126,6 @@ dissect_gsm_rlcmac_downlink(tvbuff_t *tvb, packet_info *pinfo _U_, proto_tree *t
     default: ret = -1; 
       break;
   }
-  free(data);
 }
 
 
@@ -4144,98 +4142,98 @@ proto_register_gsm_rlcmac(void)
       { "Payload Type", 
        "gsm_rlcmac_dl.pt", 
        FT_UINT8, BASE_DEC, NULL, 0x0,
-       "Payload Type", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_rrbp, 
       { "RRBP",
        "gsm_rlcmac_dl.rrbp", 
        FT_UINT8, BASE_DEC, NULL, 0x0, 
-       "RRBP", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_s_p,
       { "S/P", 
        "gsm_rlcmac_dl.s_p", 
        FT_BOOLEAN, BASE_NONE, NULL, 0x0,
-       "S/P", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_usf, 
       { "USF",
        "gsm_rlcmac_dl.usf", 
        FT_UINT8, BASE_DEC, NULL, 0x0, 
-       "USF", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_rbsn,
       { "RBSN", 
        "gsm_rlcmac_dl.rbsn", 
        FT_BOOLEAN,BASE_NONE, NULL, 0x0,
-       "RBSN", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_rti, 
       { "RTI",
        "gsm_rlcmac_dl.rti", 
        FT_UINT8, BASE_DEC, NULL, 0x0, 
-       "RTI", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_fs,
       { "FS", 
        "gsm_rlcmac_dl.fs", 
        FT_BOOLEAN,BASE_NONE, NULL, 0x0,
-       "FS", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_ac, 
       { "AC",
        "gsm_rlcmac_dl.ac", 
        FT_BOOLEAN,BASE_NONE, NULL, 0x0, 
-       "AC", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_pr, 
       { "PR",
        "gsm_rlcmac_dl.pr", 
        FT_UINT8, BASE_DEC, NULL, 0x0, 
-       "PR", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_tfi, 
       { "TFI",
        "gsm_rlcmac_dl.tfi", 
        FT_UINT8, BASE_DEC, NULL, 0x0, 
-       "TFI", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_d, 
       { "D",
        "gsm_rlcmac_dl.d", 
        FT_BOOLEAN,BASE_NONE, NULL, 0x0, 
-       "D", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_rbsn_e, 
       { "RBSNe",
        "gsm_rlcmac_dl.rbsn_e", 
        FT_UINT8, BASE_DEC, NULL, 0x0, 
-       "RBSNe", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_fs_e, 
       { "FSe",
        "gsm_rlcmac_dl.fs_e", 
        FT_BOOLEAN,BASE_NONE, NULL, 0x0, 
-       "FSe", HFILL 
+       NULL, HFILL 
       }
     },
     { &hf_dl_ctrl_spare, 
       { "spare",
        "gsm_rlcmac_dl.spare", 
        FT_UINT8, BASE_DEC, NULL, 0x0, 
-       "spare", HFILL 
+       NULL, HFILL 
       }
     },
   };