r19757: Don't do the strrchr twice. Pointed out by Martin Kuhl.

Andrew Bartlett
(This used to be commit c4bf9cc09b36d8dcc465608b55bbf5dc07aed9e4)

diff --git a/source4/dsdb/samdb/ldb_modules/samba3sam.c b/source4/dsdb/samdb/ldb_modules/samba3sam.c
index 6c7c3c70662a7ceb966df01a447f24f2c4d58936..be60dd7b4c5710220452501452f834a6cbd05b14 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/samba3sam.c
+++ b/source4/dsdb/samdb/ldb_modules/samba3sam.c
@@ -70,7 +70,7 @@ static struct ldb_message_element *generate_primaryGroupID(struct ldb_module *mo
        el->name = talloc_strdup(ctx, "primaryGroupID");
        el->num_values = 1;
        el->values = talloc_array(ctx, struct ldb_val, 1);
-       el->values[0].data = (uint8_t *)talloc_strdup(el->values, strrchr(sid, '-')+1);
+       el->values[0].data = (uint8_t *)talloc_strdup(el->values, p+1);
        el->values[0].length = strlen((char *)el->values[0].data);
 
        return el;