drm/tegra: Fix vmapping of prime buffers
authorDmitry Osipenko <dmitry.osipenko@collabora.com>
Tue, 28 Jun 2022 22:42:39 +0000 (01:42 +0300)
committerThierry Reding <treding@nvidia.com>
Fri, 8 Jul 2022 14:49:48 +0000 (16:49 +0200)
The code assumes that Tegra GEM is permanently vmapped, which is not
true for the scattered buffers. After converting Tegra video decoder
driver to V4L API, we're now getting a BUG_ON from dma-buf core on playing
video using libvdpau-tegra on T30+ because tegra_gem_prime_vmap() sets
vaddr to NULL. Older pre-V4L video decoder driver wasn't vmapping dma-bufs.
Fix it by actually vmapping the exported GEMs.

Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/tegra/gem.c

index 7c7dd84e6db84ad1fcf5eadc3c6d7f5285d9e9f0..81991090adcc93bc83b12f0107a9eaeb9ecc7121 100644 (file)
@@ -704,14 +704,23 @@ static int tegra_gem_prime_vmap(struct dma_buf *buf, struct iosys_map *map)
 {
        struct drm_gem_object *gem = buf->priv;
        struct tegra_bo *bo = to_tegra_bo(gem);
+       void *vaddr;
 
-       iosys_map_set_vaddr(map, bo->vaddr);
+       vaddr = tegra_bo_mmap(&bo->base);
+       if (IS_ERR(vaddr))
+               return PTR_ERR(vaddr);
+
+       iosys_map_set_vaddr(map, vaddr);
 
        return 0;
 }
 
 static void tegra_gem_prime_vunmap(struct dma_buf *buf, struct iosys_map *map)
 {
+       struct drm_gem_object *gem = buf->priv;
+       struct tegra_bo *bo = to_tegra_bo(gem);
+
+       tegra_bo_munmap(&bo->base, map->vaddr);
 }
 
 static const struct dma_buf_ops tegra_gem_prime_dmabuf_ops = {