lib: Fix talloc hierarchy in init_lsa_ref_domain_list

The sid is copied, so the name should also be copied.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/lib/lsa.c b/source3/lib/lsa.c
index 0046fdac588c7a391fac556411babcfbb2c3db80..6b9015ad6e237bfa6e164b686d380d1c29af937e 100644 (file)
--- a/source3/lib/lsa.c
+++ b/source3/lib/lsa.c
@@ -57,7 +57,11 @@ int init_lsa_ref_domain_list(TALLOC_CTX *mem_ctx,
 
        ZERO_STRUCT(ref->domains[num]);
 
-       ref->domains[num].name.string = dom_name;
+       ref->domains[num].name.string = talloc_strdup(mem_ctx, dom_name);
+       if (!ref->domains[num].name.string) {
+               return -1;
+       }
+
        ref->domains[num].sid = dom_sid_dup(mem_ctx, dom_sid);
        if (!ref->domains[num].sid) {
                return -1;