r8152: Check for unplug in r8153b_ups_en() / r8153c_ups_en()
authorDouglas Anderson <dianders@chromium.org>
Fri, 20 Oct 2023 21:06:57 +0000 (14:06 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 22 Oct 2023 10:46:18 +0000 (11:46 +0100)
If the adapter is unplugged while we're looping in r8153b_ups_en() /
r8153c_ups_en() we could end up looping for 10 seconds (20 ms * 500
loops). Add code similar to what's done in other places in the driver
to check for unplug and bail.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/r8152.c

index 9888bc43e90382b101139fcdc26470cf45e45568..982f9ca03e7a612022a79c2ad73108ea99cc7a22 100644 (file)
@@ -3663,6 +3663,8 @@ static void r8153b_ups_en(struct r8152 *tp, bool enable)
                        int i;
 
                        for (i = 0; i < 500; i++) {
+                               if (test_bit(RTL8152_UNPLUG, &tp->flags))
+                                       return;
                                if (ocp_read_word(tp, MCU_TYPE_PLA, PLA_BOOT_CTRL) &
                                    AUTOLOAD_DONE)
                                        break;
@@ -3703,6 +3705,8 @@ static void r8153c_ups_en(struct r8152 *tp, bool enable)
                        int i;
 
                        for (i = 0; i < 500; i++) {
+                               if (test_bit(RTL8152_UNPLUG, &tp->flags))
+                                       return;
                                if (ocp_read_word(tp, MCU_TYPE_PLA, PLA_BOOT_CTRL) &
                                    AUTOLOAD_DONE)
                                        break;