s3:smbd: Add missing newlines to logging messages

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source3/smbd/file_access.c b/source3/smbd/file_access.c
index 476aead590dcd3399e67aab21ba790b2914d1aa7..0ddad227ca1bf106e7363f2c4b9ff20edf7e4ed7 100644 (file)
--- a/source3/smbd/file_access.c
+++ b/source3/smbd/file_access.c
@@ -103,7 +103,7 @@ bool can_delete_file_in_directory(connection_struct *conn,
                        smb_fname_parent->st.st_ex_uid) &&
                    (get_current_uid(conn) != smb_fname->st.st_ex_uid)) {
                        DEBUG(10,("can_delete_file_in_directory: not "
-                                 "owner of file %s or directory %s",
+                                 "owner of file %s or directory %s\n",
                                  smb_fname_str_dbg(smb_fname),
                                  smb_fname_str_dbg(smb_fname_parent)));
                        ret = false;

diff --git a/source3/smbd/mangle_hash2.c b/source3/smbd/mangle_hash2.c
index 9c80cde312fcf2df8802383d6728ac830920f205..0075d3bfcba4dab08f70d18197b032212602216e 100644 (file)
--- a/source3/smbd/mangle_hash2.c
+++ b/source3/smbd/mangle_hash2.c
@@ -575,7 +575,7 @@ static bool lookup_name_from_8_3(TALLOC_CTX *ctx,
        TALLOC_FREE(prefix);
 
        if (!*pp_out) {
-               M_DEBUG(0,("talloc_fail"));
+               M_DEBUG(0,("talloc_fail\n"));
                return False;
        }
 

diff --git a/source3/smbd/msdfs.c b/source3/smbd/msdfs.c
index dfe11e65d2a0d09a199379a314153c26db726ad6..2772ece19f1308c1a215ab06708d222e61c69643 100644 (file)
--- a/source3/smbd/msdfs.c
+++ b/source3/smbd/msdfs.c
@@ -1683,7 +1683,7 @@ static int form_junctions(TALLOC_CTX *ctx,
 
                if (cnt >= jn_remain) {
                        DEBUG(2, ("form_junctions: ran out of MSDFS "
-                               "junction slots"));
+                               "junction slots\n"));
                        TALLOC_FREE(talloced);
                        goto out;
                }

diff --git a/source3/smbd/oplock_linux.c b/source3/smbd/oplock_linux.c
index b7c4d6d8208c362a8c778a3848fa93d337e4eb78..3ed20015d6deae4befff3065d9fe3e0846d8249d 100644 (file)
--- a/source3/smbd/oplock_linux.c
+++ b/source3/smbd/oplock_linux.c
@@ -227,7 +227,7 @@ struct kernel_oplocks *linux_init_kernel_oplocks(struct smbd_server_connection *
                               linux_oplock_signal_handler,
                               ctx);
        if (!se) {
-               DBG_ERR("Failed to setup RT_SIGNAL_LEASE handler");
+               DBG_ERR("Failed to setup RT_SIGNAL_LEASE handler\n");
                TALLOC_FREE(ctx);
                return NULL;
        }

diff --git a/source3/smbd/posix_acls.c b/source3/smbd/posix_acls.c
index 6fc6e667f1ecaaaff9e78cf389533e45ea64fc24..75f92d469117eea325e1b2e2243cf0c05c3fbfb4 100644 (file)
--- a/source3/smbd/posix_acls.c
+++ b/source3/smbd/posix_acls.c
@@ -4853,7 +4853,7 @@ NTSTATUS make_default_filesystem_acl(
                break;
 
        default:
-               DBG_ERR("unknown acl style %d", acl_style);
+               DBG_ERR("unknown acl style %d\n", acl_style);
                status = NT_STATUS_INTERNAL_ERROR;
                break;
        }

diff --git a/source3/smbd/scavenger.c b/source3/smbd/scavenger.c
index ce2a58a4ae4811d7b0bd3d3bad7399187dfa871e..5500a9f1565d68e4c630e98f3d5ebbe90126b33c 100644 (file)
--- a/source3/smbd/scavenger.c
+++ b/source3/smbd/scavenger.c
@@ -222,7 +222,7 @@ static bool smbd_scavenger_start(struct smbd_scavenger_state *state)
 
        ret = socketpair(AF_UNIX, SOCK_STREAM, 0, fds);
        if (ret == -1) {
-               DEBUG(2, ("socketpair failed: %s", strerror(errno)));
+               DEBUG(2, ("socketpair failed: %s\n", strerror(errno)));
                goto fail;
        }
 
@@ -234,7 +234,7 @@ static bool smbd_scavenger_start(struct smbd_scavenger_state *state)
                int err = errno;
                close(fds[0]);
                close(fds[1]);
-               DEBUG(0, ("fork failed: %s", strerror(err)));
+               DEBUG(0, ("fork failed: %s\n", strerror(err)));
                goto fail;
        }
 

diff --git a/source3/smbd/smb1_lanman.c b/source3/smbd/smb1_lanman.c
index 6cdf48a120c658f4c48cb06d549c7710caf2107e..9f703ebe1841f1cb5999e87e39bfcd80c1251202 100644 (file)
--- a/source3/smbd/smb1_lanman.c
+++ b/source3/smbd/smb1_lanman.c
@@ -2324,7 +2324,7 @@ static bool api_RNetShareAdd(struct smbd_server_connection *sconn,
        if (!pull_ascii_talloc(talloc_tos(), &pathname,
                               offset ? (data+offset) : "", &converted_size))
        {
-               DEBUG(0,("api_RNetShareAdd: pull_ascii_talloc failed: %s",
+               DEBUG(0,("api_RNetShareAdd: pull_ascii_talloc failed: %s\n",
                         strerror(errno)));
        }
 

diff --git a/source3/smbd/smb1_negprot.c b/source3/smbd/smb1_negprot.c
index 9b4b51e4b55d9d52e8867a5472d842ceec6aa070..7171c663f41b5fc14791bff20783c19c2af4373c 100644 (file)
--- a/source3/smbd/smb1_negprot.c
+++ b/source3/smbd/smb1_negprot.c
@@ -53,7 +53,7 @@ static void get_challenge(struct smbXsrv_connection *xconn, uint8_t buff[8])
        nt_status = make_auth4_context(
                xconn, &xconn->smb1.negprot.auth_context);
        if (!NT_STATUS_IS_OK(nt_status)) {
-               DEBUG(0, ("make_auth_context_subsystem returned %s",
+               DEBUG(0, ("make_auth_context_subsystem returned %s\n",
                          nt_errstr(nt_status)));
                smb_panic("cannot make_negprot_global_auth_context!");
        }

diff --git a/source3/smbd/smb1_nttrans.c b/source3/smbd/smb1_nttrans.c
index b9c9033649080347b4bcb7ea2e0e2e3960fa34f6..d1c45e7a4593068f3d38b4a7947d69a590ad368f 100644 (file)
--- a/source3/smbd/smb1_nttrans.c
+++ b/source3/smbd/smb1_nttrans.c
@@ -2099,7 +2099,7 @@ static void call_nt_transact_get_user_quota(connection_struct *conn,
 
        if (!NDR_ERR_CODE_IS_SUCCESS(err)) {
                DEBUG(0,("TRANSACT_GET_USER_QUOTA: failed to pull "
-                        "query_quota_params."));
+                        "query_quota_params.\n"));
                nt_status = NT_STATUS_INVALID_PARAMETER;
                goto error;
        }

diff --git a/source3/smbd/smb1_trans2.c b/source3/smbd/smb1_trans2.c
index 6a10437713326abb0eb2355878caeeaf2ac8f4e8..ba4aa37df129ae4dc01f6924808bfae4cb0db5c5 100644 (file)
--- a/source3/smbd/smb1_trans2.c
+++ b/source3/smbd/smb1_trans2.c
@@ -137,7 +137,7 @@ static void send_trans2_replies(connection_struct *conn,
 
        if (useable_space < 0) {
                DEBUG(0, ("send_trans2_replies failed sanity useable_space "
-                         "= %d!!!", useable_space));
+                         "= %d!!!\n", useable_space));
                exit_server_cleanly("send_trans2_replies: Not enough space");
        }
 
@@ -472,7 +472,7 @@ static struct ea_list *read_ea_name_list(TALLOC_CTX *ctx, const char *pdata, siz
                if (!pull_ascii_talloc(ctx, &eal->ea.name, &pdata[offset],
                                       &converted_size)) {
                        DEBUG(0,("read_ea_name_list: pull_ascii_talloc "
-                                "failed: %s", strerror(errno)));
+                                "failed: %s\n", strerror(errno)));
                }
                if (!eal->ea.name) {
                        return NULL;