staging: rtl8723bs: use is_zero_ether_addr() instead of memcmp()

Use is_zero_ether_addr() instead of memcmp to check
if the ethernet address is all zeros.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20230804083841.1321554-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 7e2c61c75150c1780ad4a99fcf15c0eb5320a744..b59d510956b09be444d75cd98d052eb9d453dcb7 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -226,9 +226,8 @@ struct wlan_network *_rtw_find_network(struct __queue *scanned_queue, u8 *addr)
 {
        struct list_head        *phead, *plist;
        struct  wlan_network *pnetwork = NULL;
-       u8 zero_addr[ETH_ALEN] = {0, 0, 0, 0, 0, 0};
 
-       if (!memcmp(zero_addr, addr, ETH_ALEN)) {
+       if (is_zero_ether_addr(addr)) {
                pnetwork = NULL;
                goto exit;
        }

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 7c7b6495965f5ae859c960d772cf4e66058fb9c7..7be11dc3d7258e1a499b40b596b9045cf80fa3ef 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -670,9 +670,9 @@ static signed int sta2sta_data_frame(struct adapter *adapter, union recv_frame *
                        goto exit;
                }
 
-               if (!memcmp(pattrib->bssid, "\x0\x0\x0\x0\x0\x0", ETH_ALEN) ||
-                  !memcmp(mybssid, "\x0\x0\x0\x0\x0\x0", ETH_ALEN) ||
-                  (memcmp(pattrib->bssid, mybssid, ETH_ALEN))) {
+               if (is_zero_ether_addr(pattrib->bssid) ||
+                   is_zero_ether_addr(mybssid) ||
+                   (memcmp(pattrib->bssid, mybssid, ETH_ALEN))) {
                        ret = _FAIL;
                        goto exit;
                }
@@ -762,9 +762,9 @@ static signed int ap2sta_data_frame(struct adapter *adapter, union recv_frame *p
 
 
                /*  check BSSID */
-               if (!memcmp(pattrib->bssid, "\x0\x0\x0\x0\x0\x0", ETH_ALEN) ||
-                    !memcmp(mybssid, "\x0\x0\x0\x0\x0\x0", ETH_ALEN) ||
-                    (memcmp(pattrib->bssid, mybssid, ETH_ALEN))) {
+               if (is_zero_ether_addr(pattrib->bssid) ||
+                   is_zero_ether_addr(mybssid) ||
+                   (memcmp(pattrib->bssid, mybssid, ETH_ALEN))) {
 
                        if (!bmcast)
                                issue_deauth(adapter, pattrib->bssid, WLAN_REASON_CLASS3_FRAME_FROM_NONASSOC_STA);

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 292cba045023dced4c783568bfd2870c3ede9327..af155fca39b8ca2a6ccc422a0c74dfa5f5649495 100644 (file)
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -1850,9 +1850,8 @@ static int cfg80211_rtw_set_pmksa(struct wiphy *wiphy,
        u8 index, blInserted = false;
        struct adapter *padapter = rtw_netdev_priv(ndev);
        struct security_priv *psecuritypriv = &padapter->securitypriv;
-       u8 strZeroMacAddress[ETH_ALEN] = { 0x00 };
 
-       if (!memcmp((u8 *)pmksa->bssid, strZeroMacAddress, ETH_ALEN))
+       if (is_zero_ether_addr((u8 *)pmksa->bssid))
                return -EINVAL;
 
        blInserted = false;