ldb-samba: remove redundant negative check
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Sun, 21 Mar 2021 07:49:32 +0000 (20:49 +1300)
committerJeremy Allison <jra@samba.org>
Tue, 30 Mar 2021 18:55:28 +0000 (18:55 +0000)
smb_strtoull() already checks for negative numbers, but does
it properly, catching " -2" as well as "-2".

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Mar 30 18:55:28 UTC 2021 on sn-devel-184

lib/ldb-samba/ldb_matching_rules.c

index 2c9d78fea8c50a7b03b1bb0d362ddff39d95a479..73d957df3d9da3091fbc25f6b60be199e345bfe2 100644 (file)
@@ -390,7 +390,7 @@ static int dsdb_match_for_dns_to_tombstone_time(struct ldb_context *ldb,
 
                memcpy(s, value_to_match->data, value_to_match->length);
                s[value_to_match->length] = 0;
-               if (s[0] == '\0' || s[0] == '-') {
+               if (s[0] == '\0') {
                        DBG_ERR("Empty timestamp passed\n");
                        return LDB_ERR_INVALID_ATTRIBUTE_SYNTAX;
                }