]> git.samba.org - sfrench/cifs-2.6.git/commitdiff
sctp: Fix crc32c calculations on big-endian arhes.
authorVlad Yasevich <vladislav.yasevich@hp.com>
Thu, 22 Jan 2009 22:52:23 +0000 (14:52 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 22 Jan 2009 22:52:23 +0000 (14:52 -0800)
crc32c algorithm provides a byteswaped result.  On little-endian
arches, the result ends up in big-endian/network byte order.
On big-endinan arches, the result ends up in little-endian
order and needs to be byte swapped again.  Thus calling cpu_to_le32
gives the right output.

Tested-by: Jukka Taimisto <jukka.taimisto@mail.suomi.net>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/sctp/checksum.h

index b799fb21519aafd4331f52c55b09d7484ec62265..2fec3c366e81cb18a0d10da0f2d506ea44008e9b 100644 (file)
@@ -79,5 +79,5 @@ static inline __be32 sctp_update_cksum(__u8 *buffer, __u16 length, __be32 crc32)
 
 static inline __be32 sctp_end_cksum(__be32 crc32)
 {
-       return ~crc32;
+       return (__force __be32)~cpu_to_le32((__force u32)crc32);
 }