net: phy: hide the PHYLIB_LEDS knob
authorPaolo Abeni <pabeni@redhat.com>
Wed, 26 Apr 2023 08:15:31 +0000 (10:15 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Wed, 26 Apr 2023 09:54:50 +0000 (11:54 +0200)
commit 4bb7aac70b5d ("net: phy: fix circular LEDS_CLASS dependencies")
solved a build failure, but introduces a new config knob with a default
'y' value: PHYLIB_LEDS.

The latter is against the current new config policy. The exception
was raised to allow the user to catch bad configurations without led
support.

Anyway the current definition of PHYLIB_LEDS does not fit the above
goal: if LEDS_CLASS is disabled, the new config will be available
only with PHYLIB disabled, too.

Hide the mentioned config, to preserve the randconfig testing done so
far, while respecting the mentioned policy.

Suggested-by: Andrew Lunn <andrew@lunn.ch>
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Link: https://lore.kernel.org/r/d82489be8ed911c383c3447e9abf469995ccf39a.1682496488.git.pabeni@redhat.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/phy/Kconfig

index 2f3ddc446cbb811ae703da5cfb8763adf4fe29b3..93b8efc79227373bf196d5abcf24674a8363a907 100644 (file)
@@ -45,10 +45,8 @@ config LED_TRIGGER_PHY
                for any speed known to the PHY.
 
 config PHYLIB_LEDS
-       bool "Support probing LEDs from device tree"
+       def_bool OF
        depends on LEDS_CLASS=y || LEDS_CLASS=PHYLIB
-       depends on OF
-       default y
        help
          When LED class support is enabled, phylib can automatically
          probe LED setting from device tree.