auth3: Use talloc_move() instead of talloc_steal()
authorVolker Lendecke <vl@samba.org>
Tue, 13 Apr 2021 14:45:54 +0000 (14:45 +0000)
committerJeremy Allison <jra@samba.org>
Mon, 19 Apr 2021 18:18:31 +0000 (18:18 +0000)
More recent coding style, avoid ambiguities about ownership

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/auth/auth_generic.c
source3/auth/auth_util.c
source3/auth/server_info.c
source3/auth/server_info_sam.c

index e62585e919c8f5adce892b185b3ebe4e25b9b55c..1b6e85c1cf0b28c11354b1e382b7f840b821b07f 100644 (file)
@@ -399,7 +399,7 @@ NTSTATUS auth_generic_prepare(TALLOC_CTX *mem_ctx,
                return nt_status;
        }
 
-       *gensec_security_out = talloc_steal(mem_ctx, gensec_security);
+       *gensec_security_out = talloc_move(mem_ctx, &gensec_security);
        TALLOC_FREE(tmp_ctx);
        return NT_STATUS_OK;
 }
index 4686b29111e8a38ffc08c6dcf8059b1eb2c38830..162adeb5527ab1cca010140aa54fda2de9a66dea 100644 (file)
@@ -1292,7 +1292,7 @@ NTSTATUS make_server_info_pw(TALLOC_CTX *mem_ctx,
        result->utok.uid = pwd->pw_uid;
        result->utok.gid = pwd->pw_gid;
 
-       *server_info = talloc_steal(mem_ctx, result);
+       *server_info = talloc_move(mem_ctx, &result);
        status = NT_STATUS_OK;
 done:
        talloc_free(tmp_ctx);
index f3e2b3b25f82a77e1cd0792b0dc9eda81218506e..e5debd45b97f9305d1830120f43907d5cb6cbfee 100644 (file)
@@ -781,7 +781,7 @@ NTSTATUS passwd_to_SamInfo3(TALLOC_CTX *mem_ctx,
                }
        }
 
-       *pinfo3 = talloc_steal(mem_ctx, info3);
+       *pinfo3 = talloc_move(mem_ctx, &info3);
 
        status = NT_STATUS_OK;
 done:
index fef60c2fbd6482bff4b5524f805e444b494a29ea..755791c1be45ca47e483556c02a446abd05908b2 100644 (file)
@@ -96,7 +96,7 @@ NTSTATUS make_server_info_sam(TALLOC_CTX *mem_ctx,
                goto out;
        }
 
-       server_info->unix_name = talloc_steal(server_info, pwd->pw_name);
+       server_info->unix_name = talloc_move(server_info, &pwd->pw_name);
 
        server_info->utok.gid = pwd->pw_gid;
        server_info->utok.uid = pwd->pw_uid;
@@ -121,7 +121,7 @@ NTSTATUS make_server_info_sam(TALLOC_CTX *mem_ctx,
        DEBUG(5,("make_server_info_sam: made server info for user %s -> %s\n",
                 pdb_get_username(sampass), server_info->unix_name));
 
-       *pserver_info = talloc_steal(mem_ctx, server_info);
+       *pserver_info = talloc_move(mem_ctx, &server_info);
 
        status = NT_STATUS_OK;
 out: