drm/bridge: analogix_dp: Don't read EDID if panel present
authorSean Paul <seanpaul@chromium.org>
Wed, 24 Aug 2016 14:58:26 +0000 (10:58 -0400)
committerArchit Taneja <architt@codeaurora.org>
Sat, 24 Sep 2016 06:26:34 +0000 (11:56 +0530)
If there's a panel connected to the analogix_dp bridge, rely on
the panel driver for modes, rather than reading EDID *and* calling
get_modes() on the panel.

This allows panels with a valid EDID to read it in the panel driver
(e.g. simple_panel), and panels with invalid EDID to homebrew modes
in their get_modes implementation.

Signed-off-by: Sean Paul <seanpaul@chromium.org>
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

index 774cc7963e10bf30aa555a1b58293dd239fc46f2..e9c9aebffe442f3305f80fb568debc4500b5397b 100644 (file)
@@ -930,15 +930,17 @@ int analogix_dp_get_modes(struct drm_connector *connector)
                return 0;
        }
 
-       edid = drm_get_edid(connector, &dp->aux.ddc);
-       if (edid) {
-               drm_mode_connector_update_edid_property(&dp->connector, edid);
-               num_modes += drm_add_edid_modes(&dp->connector, edid);
-               kfree(edid);
-       }
-
-       if (dp->plat_data->panel)
+       if (dp->plat_data->panel) {
                num_modes += drm_panel_get_modes(dp->plat_data->panel);
+       } else {
+               edid = drm_get_edid(connector, &dp->aux.ddc);
+               if (edid) {
+                       drm_mode_connector_update_edid_property(&dp->connector,
+                                                               edid);
+                       num_modes += drm_add_edid_modes(&dp->connector, edid);
+                       kfree(edid);
+               }
+       }
 
        if (dp->plat_data->get_modes)
                num_modes += dp->plat_data->get_modes(dp->plat_data, connector);