clk: meson: Mark some things static
authorStephen Boyd <sboyd@kernel.org>
Mon, 3 Dec 2018 21:52:56 +0000 (13:52 -0800)
committerStephen Boyd <sboyd@kernel.org>
Mon, 3 Dec 2018 21:52:56 +0000 (13:52 -0800)
These are missing 'static' so sparse complains:

drivers/clk/meson/vid-pll-div.c:58:26: warning: symbol '_get_table_val' was not declared. Should it be static?
drivers/clk/meson/gxbb.c:1585:12: warning: symbol 'gxbb_vid_pll_parent_names' was not declared. Should it be static?
drivers/clk/meson/gxbb.c:1620:12: warning: symbol 'gxbb_vclk_parent_names' was not declared. Should it be static?
drivers/clk/meson/gxbb.c:1980:12: warning: symbol 'gxbb_cts_parent_names' was not declared. Should it be static?
drivers/clk/meson/gxbb.c:2036:12: warning: symbol 'gxbb_cts_hdmi_tx_parent_names' was not declared. Should it be static?

Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/meson/gxbb.c
drivers/clk/meson/vid-pll-div.c

index 30fbf8f1f190443528b3c3b2b934e68722784761..b92df222f55338640da8984aa347fd1c4eacf290 100644 (file)
@@ -1582,7 +1582,7 @@ static struct clk_regmap gxbb_vid_pll_div = {
        },
 };
 
-const char *gxbb_vid_pll_parent_names[] = { "vid_pll_div", "hdmi_pll" };
+static const char * const gxbb_vid_pll_parent_names[] = { "vid_pll_div", "hdmi_pll" };
 
 static struct clk_regmap gxbb_vid_pll_sel = {
        .data = &(struct clk_regmap_mux_data){
@@ -1617,7 +1617,7 @@ static struct clk_regmap gxbb_vid_pll = {
        },
 };
 
-const char *gxbb_vclk_parent_names[] = {
+static const char * const gxbb_vclk_parent_names[] = {
        "vid_pll", "fclk_div4", "fclk_div3", "fclk_div5", "vid_pll",
        "fclk_div7", "mpll1",
 };
@@ -1977,7 +1977,7 @@ static struct clk_fixed_factor gxbb_vclk2_div12 = {
 };
 
 static u32 mux_table_cts_sel[] = { 0, 1, 2, 3, 4, 8, 9, 10, 11, 12 };
-const char *gxbb_cts_parent_names[] = {
+static const char * const gxbb_cts_parent_names[] = {
        "vclk_div1", "vclk_div2", "vclk_div4", "vclk_div6",
        "vclk_div12", "vclk2_div1", "vclk2_div2", "vclk2_div4",
        "vclk2_div6", "vclk2_div12"
@@ -2033,7 +2033,7 @@ static struct clk_regmap gxbb_cts_vdac_sel = {
 
 /* TOFIX: add support for cts_tcon */
 static u32 mux_table_hdmi_tx_sel[] = { 0, 1, 2, 3, 4, 8, 9, 10, 11, 12 };
-const char *gxbb_cts_hdmi_tx_parent_names[] = {
+static const char * const gxbb_cts_hdmi_tx_parent_names[] = {
        "vclk_div1", "vclk_div2", "vclk_div4", "vclk_div6",
        "vclk_div12", "vclk2_div1", "vclk2_div2", "vclk2_div4",
        "vclk2_div6", "vclk2_div12"
index b3370ea7beac496d6e62493c7f2f64af1b12fd61..88af0e282ea06c21d57b68de09aa1ef4c7964b92 100644 (file)
@@ -55,8 +55,8 @@ static const struct vid_pll_div vid_pll_div_table[] = {
 #define to_meson_vid_pll_div(_hw) \
        container_of(_hw, struct meson_vid_pll_div, hw)
 
-const struct vid_pll_div *_get_table_val(unsigned int shift_val,
-                                        unsigned int shift_sel)
+static const struct vid_pll_div *_get_table_val(unsigned int shift_val,
+                                               unsigned int shift_sel)
 {
        int i;