s3: smbd: Prepare to remove wildcard matching from rename_internals().
authorJeremy Allison <jra@samba.org>
Thu, 2 Dec 2021 00:25:03 +0000 (16:25 -0800)
committerRalph Boehme <slow@samba.org>
Thu, 9 Dec 2021 18:06:35 +0000 (18:06 +0000)
src_has_wild and dest_has_wild can never be true.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/reply.c

index fabeb4000460604cd5980563e20fa20d8d03ae7b..9a94693d9377972b24703bbcb1aff1f5e9487b48 100644 (file)
@@ -7872,20 +7872,6 @@ NTSTATUS rename_internals(TALLOC_CTX *ctx,
                goto out;
        }
 
-       if (!(smb_fname_src->flags & SMB_FILENAME_POSIX_PATH)) {
-               /*
-                * Check the wildcard mask *before*
-                * unmangling. As mangling is done
-                * for names that can't be returned
-                * to Windows the unmangled name may
-                * contain Windows wildcard characters.
-                */
-               if (src_original_lcomp != NULL) {
-                       src_has_wild = ms_has_wild(src_original_lcomp);
-               }
-               dest_has_wild = ms_has_wild(dst_original_lcomp);
-       }
-
        /*
         * We should only check the mangled cache
         * here if unix_convert failed. This means