block: fix offset/size check in bio_trim()
authorMing Lei <ming.lei@redhat.com>
Thu, 14 Apr 2022 08:44:43 +0000 (16:44 +0800)
committerJens Axboe <axboe@kernel.dk>
Thu, 14 Apr 2022 16:15:24 +0000 (10:15 -0600)
Unit of bio->bi_iter.bi_size is bytes, but unit of offset/size
is sector.

Fix the above issue in checking offset/size in bio_trim().

Fixes: e83502ca5f1e ("block: fix argument type of bio_trim()")
Cc: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20220414084443.1736850-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bio.c

index cdd7b2915c532c1590abafe0019594402b98cbc3..4259125e16ab24075d902f989f424f8b046c9bee 100644 (file)
@@ -1598,7 +1598,7 @@ EXPORT_SYMBOL(bio_split);
 void bio_trim(struct bio *bio, sector_t offset, sector_t size)
 {
        if (WARN_ON_ONCE(offset > BIO_MAX_SECTORS || size > BIO_MAX_SECTORS ||
-                        offset + size > bio->bi_iter.bi_size))
+                        offset + size > bio_sectors(bio)))
                return;
 
        size <<= 9;