s3-spoolss: Fixed a possible crash bug.
authorAndreas Schneider <asn@samba.org>
Mon, 6 Sep 2010 14:07:24 +0000 (16:07 +0200)
committerAndreas Schneider <asn@samba.org>
Wed, 8 Sep 2010 15:38:29 +0000 (17:38 +0200)
source3/rpc_server/srv_spoolss_util.c

index 5fbdc0b40651c531d1f98176c294525aaa23d56b..927bb5ed0c62705ae0fd4e89b63243d1b57fb549 100644 (file)
@@ -2337,9 +2337,23 @@ WERROR winreg_get_printer_secdesc(TALLOC_CTX *mem_ctx,
        goto done;
 
 create_default:
+       result = winreg_printer_openkey(tmp_ctx,
+                                       server_info,
+                                       msg_ctx,
+                                       &winreg_pipe,
+                                       path,
+                                       "",
+                                       true,
+                                       access_mask,
+                                       &hive_hnd,
+                                       &key_hnd);
+       if (!W_ERROR_IS_OK(result)) {
+               goto done;
+       }
+
        result = spoolss_create_default_secdesc(tmp_ctx, &secdesc);
        if (!W_ERROR_IS_OK(result)) {
-               return result;
+               goto done;
        }
 
        /* If security descriptor is owned by S-1-1-0 and winbindd is up,