printing: add more 'const' to read only input pointers
authorStefan Metzmacher <metze@samba.org>
Thu, 24 May 2018 15:40:27 +0000 (17:40 +0200)
committerStefan Metzmacher <metze@samba.org>
Thu, 14 Jun 2018 18:52:22 +0000 (20:52 +0200)
This makes it clearer that they won't be changed.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/include/nt_printing.h
source3/printing/nt_printing.c

index 688c6b9969e36556529c0d250bc79192d82a4f97..f01ffe5b32ff33bf8b2af7bccc7a143fe678a963 100644 (file)
@@ -164,13 +164,13 @@ bool printer_driver_files_in_use(TALLOC_CTX *mem_ctx,
 bool delete_driver_files(const struct auth_session_info *server_info,
                         const struct spoolss_DriverInfo8 *r);
 
-WERROR move_driver_to_download_area(struct auth_session_info *session_info,
-                                   struct spoolss_AddDriverInfoCtr *r,
+WERROR move_driver_to_download_area(const struct auth_session_info *session_info,
+                                   const struct spoolss_AddDriverInfoCtr *r,
                                    const char *driver_directory);
 
 WERROR clean_up_driver_struct(TALLOC_CTX *mem_ctx,
-                             struct auth_session_info *session_info,
-                             struct spoolss_AddDriverInfoCtr *r,
+                             const struct auth_session_info *session_info,
+                             const struct spoolss_AddDriverInfoCtr *r,
                              uint32_t flags,
                              const char **driver_directory);
 
index 1639bfd440661e91a8d93d2519d6724e68d0104c..52bba6fcb3d714a2e5eeafe5f4208d9c4ab31bc8 100644 (file)
@@ -980,7 +980,7 @@ static int file_version_is_newer(connection_struct *conn, fstring new_file, fstr
 /****************************************************************************
 Determine the correct cVersion associated with an architecture and driver
 ****************************************************************************/
-static uint32_t get_correct_cversion(struct auth_session_info *session_info,
+static uint32_t get_correct_cversion(const struct auth_session_info *session_info,
                                   const char *architecture,
                                   const char *driverpath_in,
                                   const char *driver_directory,
@@ -1191,7 +1191,7 @@ static uint32_t get_correct_cversion(struct auth_session_info *session_info,
 } while (0);
 
 static WERROR clean_up_driver_struct_level(TALLOC_CTX *mem_ctx,
-                                          struct auth_session_info *session_info,
+                                          const struct auth_session_info *session_info,
                                           const char *architecture,
                                           const char **driver_path,
                                           const char **data_file,
@@ -1306,8 +1306,8 @@ static WERROR clean_up_driver_struct_level(TALLOC_CTX *mem_ctx,
 ****************************************************************************/
 
 WERROR clean_up_driver_struct(TALLOC_CTX *mem_ctx,
-                             struct auth_session_info *session_info,
-                             struct spoolss_AddDriverInfoCtr *r,
+                             const struct auth_session_info *session_info,
+                             const struct spoolss_AddDriverInfoCtr *r,
                              uint32_t flags,
                              const char **driver_directory)
 {
@@ -1472,8 +1472,8 @@ static WERROR move_driver_file_to_download_area(TALLOC_CTX *mem_ctx,
        return ret;
 }
 
-WERROR move_driver_to_download_area(struct auth_session_info *session_info,
-                                   struct spoolss_AddDriverInfoCtr *r,
+WERROR move_driver_to_download_area(const struct auth_session_info *session_info,
+                                   const struct spoolss_AddDriverInfoCtr *r,
                                    const char *driver_directory)
 {
        struct spoolss_AddDriverInfo3 *driver;