bpf: fix link error without CONFIG_NET
authorArnd Bergmann <arnd@arndb.de>
Thu, 2 Nov 2017 11:05:51 +0000 (12:05 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Nov 2017 05:20:22 +0000 (14:20 +0900)
I ran into this link error with the latest net-next plus linux-next
trees when networking is disabled:

kernel/bpf/verifier.o:(.rodata+0x2958): undefined reference to `tc_cls_act_analyzer_ops'
kernel/bpf/verifier.o:(.rodata+0x2970): undefined reference to `xdp_analyzer_ops'

It seems that the code was written to deal with varying contents of
the arrray, but the actual #ifdef was missing. Both tc_cls_act_analyzer_ops
and xdp_analyzer_ops are defined in the core networking code, so adding
a check for CONFIG_NET seems appropriate here, and I've verified this with
many randconfig builds

Fixes: 4f9218aaf8a4 ("bpf: move knowledge about post-translation offsets out of verifier")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
kernel/bpf/verifier.c

index 530b68550fd232b602d4fd6f6a36104b6824ab8b..5f3799dcba019d4b44be878ae9c783e67b27ee9c 100644 (file)
@@ -4588,8 +4588,10 @@ err_free_env:
 }
 
 static const struct bpf_verifier_ops * const bpf_analyzer_ops[] = {
+#ifdef CONFIG_NET
        [BPF_PROG_TYPE_XDP]             = &xdp_analyzer_ops,
        [BPF_PROG_TYPE_SCHED_CLS]       = &tc_cls_act_analyzer_ops,
+#endif
 };
 
 int bpf_analyzer(struct bpf_prog *prog, const struct bpf_ext_analyzer_ops *ops,