MIPS: perf: Remove unnecessary "fallthrough" pseudo keywords
authorHuacai Chen <chenhc@lemote.com>
Sat, 2 May 2020 10:46:24 +0000 (18:46 +0800)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Sat, 2 May 2020 11:21:09 +0000 (13:21 +0200)
The last branch of switch-case doesn't need a "fallthrough" pseudo
keyword, and it will cause errors when building a kernel with -Werror:

   arch/mips/kernel/perf_event_mipsxx.c: In function 'reset_counters':
   include/linux/compiler_attributes.h:200:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
     200 | # define fallthrough                    __attribute__((__fallthrough__))
         |                                         ^~~~~~~~~~~~~
>> arch/mips/kernel/perf_event_mipsxx.c:932:3: note: in expansion of macro 'fallthrough'
     932 |   fallthrough;
         |   ^~~~~~~~~~~
   arch/mips/kernel/perf_event_mipsxx.c: In function 'loongson3_reset_counters':
   include/linux/compiler_attributes.h:200:41: error: attribute 'fallthrough' not preceding a case label or default label [-Werror]
     200 | # define fallthrough                    __attribute__((__fallthrough__))
         |                                         ^~~~~~~~~~~~~
   arch/mips/kernel/perf_event_mipsxx.c:903:3: note: in expansion of macro 'fallthrough'
     903 |   fallthrough;
         |   ^~~~~~~~~~~
   cc1: all warnings being treated as errors

Fix it by removing unnecessary "fallthrough" pseudo keywords.

Fixes: e9dfbaaeef1c9fe ("MIPS: perf: Add hardware perf events support for new Loongson-3")
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Huacai Chen <chenhc@lemote.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/kernel/perf_event_mipsxx.c

index a14974ca6d13e45b73e7f89b5138052d5146118c..efce5defcc5cfd1548d66c52ab8b7460e3e40237 100644 (file)
@@ -900,7 +900,7 @@ static void loongson3_reset_counters(void *arg)
                mipspmu.write_counter(0, 0);
                mipsxx_pmu_write_control(0, 575<<5);
                mipspmu.write_counter(0, 0);
-               fallthrough;
+               break;
        }
 }
 
@@ -929,7 +929,7 @@ static void reset_counters(void *arg)
        case 1:
                mipsxx_pmu_write_control(0, 0);
                mipspmu.write_counter(0, 0);
-               fallthrough;
+               break;
        }
 }