x86/mm/pae: Don't (ab)use atomic64
authorPeter Zijlstra <peterz@infradead.org>
Thu, 26 Nov 2020 16:38:42 +0000 (17:38 +0100)
committerDave Hansen <dave.hansen@linux.intel.com>
Thu, 15 Dec 2022 18:37:27 +0000 (10:37 -0800)
PAE implies CX8, write readable code.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20221022114424.971450128%40infradead.org
arch/x86/include/asm/pgtable-3level.h

index 94f50b0100a51c2d1c6c0cc049993b9e0cdaab95..0a1b81dc72c04b41777a4034c9ff2c33dea93ae6 100644 (file)
@@ -2,8 +2,6 @@
 #ifndef _ASM_X86_PGTABLE_3LEVEL_H
 #define _ASM_X86_PGTABLE_3LEVEL_H
 
-#include <asm/atomic64_32.h>
-
 /*
  * Intel Physical Address Extension (PAE) Mode - three-level page
  * tables on PPro+ CPUs.
@@ -95,11 +93,12 @@ static inline void pud_clear(pud_t *pudp)
 #ifdef CONFIG_SMP
 static inline pte_t native_ptep_get_and_clear(pte_t *ptep)
 {
-       pte_t res;
+       pte_t old = *ptep;
 
-       res.pte = (pteval_t)arch_atomic64_xchg((atomic64_t *)ptep, 0);
+       do {
+       } while (!try_cmpxchg64(&ptep->pte, &old.pte, 0ULL));
 
-       return res;
+       return old;
 }
 #else
 #define native_ptep_get_and_clear(xp) native_local_ptep_get_and_clear(xp)