cpuidle: teo: Avoid unnecessary variable assignments
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 22 Aug 2023 11:28:02 +0000 (13:28 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 23 Aug 2023 16:25:04 +0000 (18:25 +0200)
Notice that it is not necessary to assign tick_intercept_sum in every
iteration of the first loop over idle states in teo_select(), because
the intercept_sum value does not change after the assignment in a
given iteration of the loop, so its value after the last iteration of
the loop can be used for computing the tick_intercept_sum value
directly.

Modify the code accordingly.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpuidle/governors/teo.c

index 31050fdc633f201b22deb8da11e702417bb9b24f..7244f71c59c5dd4a4b64141af307ef76ee2fcc77 100644 (file)
@@ -450,8 +450,6 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev,
                hit_sum += prev_bin->hits;
                recent_sum += prev_bin->recent;
 
-               tick_intercept_sum = intercept_sum;
-
                if (dev->states_usage[i].disable)
                        continue;
 
@@ -484,7 +482,8 @@ static int teo_select(struct cpuidle_driver *drv, struct cpuidle_device *dev,
                goto end;
        }
 
-       tick_intercept_sum += cpu_data->state_bins[drv->state_count-1].intercepts;
+       tick_intercept_sum = intercept_sum +
+                       cpu_data->state_bins[drv->state_count-1].intercepts;
 
        /*
         * If the sum of the intercepts metric for all of the idle states