gpio: xra1403: Make use of for_each_requested_gpio()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 15 Jun 2020 15:05:44 +0000 (18:05 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Sat, 20 Jun 2020 21:13:27 +0000 (23:13 +0200)
Make use of for_each_requested_gpio() instead of home grown analogue.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Nandor Han <nandor.han@ge.com>
Cc: Semi Malinen <semi.malinen@ge.com>
Link: https://lore.kernel.org/r/20200615150545.87964-5-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-xra1403.c

index 31b5072b2df0efe0e7043cc0d39371e14754ebe2..e2cac12092afa9d06eec52f2e7bf92a8dcac2d34 100644 (file)
@@ -121,6 +121,7 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip)
        struct xra1403 *xra = gpiochip_get_data(chip);
        int value[XRA_LAST];
        int i;
+       const char *label;
        unsigned int gcr;
        unsigned int gsr;
 
@@ -136,12 +137,7 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 
        gcr = value[XRA_GCR + 1] << 8 | value[XRA_GCR];
        gsr = value[XRA_GSR + 1] << 8 | value[XRA_GSR];
-       for (i = 0; i < chip->ngpio; i++) {
-               const char *label = gpiochip_is_requested(chip, i);
-
-               if (!label)
-                       continue;
-
+       for_each_requested_gpio(chip, i, label) {
                seq_printf(s, " gpio-%-3d (%-12s) %s %s\n",
                           chip->base + i, label,
                           (gcr & BIT(i)) ? "in" : "out",