ldb: Don’t leak ‘el’
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 6 Jul 2023 22:43:15 +0000 (10:43 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 8 Aug 2023 04:39:37 +0000 (04:39 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib/ldb/pyldb.c

index 25c7bb17f41196f196f464450b8d82c33275128e..874a64f554e5f6b9369869db3622600a3fdcc871 100644 (file)
@@ -3854,6 +3854,7 @@ static int py_ldb_msg_setitem(PyLdbMessageObject *self, PyObject *name, PyObject
                ret = ldb_msg_add(pyldb_Message_AsMessage(self), el, el->flags);
                if (ret != LDB_SUCCESS) {
                        PyErr_SetLdbError(PyExc_LdbError, ret, NULL);
+                       talloc_unlink(self->msg, el);
                        return -1;
                }
        }